Re: NEW new dll stuff (was Re: DLL stuff (working!))
25 years, 7 months
Hrvoje Niksic
Hrvoje Niksic
"J. Kean Johnston" <jkj(a)sco.com> writes:
> On Mon, Sep 21, 1998 at 02:26:25PM +0200, Hrvoje Niksic wrote:
> > * Why is the syntax of declaring dynamic SUBR's different from the
> > rest of XEmacs? I'm not sure this is acceptable, really.
> I fixed that. There was a reason at the time, I understand a few
> things better now and its gone away with the new patch (the one to
> symbols.c).
Cool, thanks.
> > * Why are you using specialized error functions instead of the Emacs
> > ones? As a reminder, Emacs has error(), signal_simple_error(), and
> > a bunch of others. See eval.c for details.
>
> For a good reason ( think). When I need to signal an error I need to
> make sure that I unwind any modules that were partially loaded or
> that were loaded as part of a dependancy chain, and I need to do
> that before I call the error functions, which will asynchronously
> terminate my code, leaving things in a mess. I could simply call
> error() but I wanted the control.
You are not thinking Emacsy. :-) The way this kind of thing is
normally done in Emacs is to set up an unwind-protect to be called
when a block of code exits, either locally or non-locally. There are
examples of this all over XEmacs; you just need to look for
record_unwind_protect(). I recommend looking at Fdirectory_files()
and close_directory_unwind() in dired.c.
The problem with your approach is that it requires a different set of
error functions to be used for each particular purpose which is
wasteful and harder to maintain. Also, the unwind-protect approach
protects you from other errors, such as QUIT or external signals.
> > Also, your error messages are at odds with the usual Emacs error
> > conventions. Please look them up, or mail me privately if you need
> > more details on what exactly I mean.
>
> I need more details.
* Your code says:
error ("Error: Dynamic module name cannot be NIL or empty!!!");
Errors in Emacs don't begin with `Error: '. They also don't end
with three exclamation marks, nor do they end with a period, for
that matter. Also, it is highly unclear what you mean by "NIL" in
this context. Not to mention that your code would crash if anything
but a string would be passed to it. You might want to write that
sequence like this:
CHECK_STRING (file);
if (XSTRING_LENGTH (file) == 0)
signal_simple_error ("Empty file name", file);
* Another example:
cemacs_error ("Cannot open dynamic load file %s", module);
should say:
signal_simple_error ("Unable to locate file", file);
Almost all the occurrences of `error()' should be replaced with
other more specific functions. Also, Emacs doesn't use single
quotes '%s'. You either write "MESSAGE: %s" (which is what
signal_simple_error() does), or you write "MESSAGE `%s'
MORE-MESSAGE".
> > * I believe your code is not Mule-clean, and as such not eligible for
> > application to XEmacs. Hint: casting XSTRING_DATA (foo) to `char *'
> > is something that should *NOT* be done. Again, ask if you need more
> > explanations.
>
> Yes, please. I am not sure what the requirements are but things can
> be changed easily.
I've written a guideline for Mule-correct coding and posted it to
xemacs-patches (it's a patch to `Internals' manual). I have attached
the patch below.
> > * dll-list-modules should really return a list, not a vector. Vectors
> > should be used only for data structures that require random access,
> > as opposed to front-to-end searches.
> Done.
Oh, yes. Each element of that list should be in some way extensible,
perhaps by turning it into a plist. We should make it easy to extend
the interface in the future, rather than casting it in stone. These
things have bitten XEmacs in the past.
> Everythings in the new attached tar file. Applying this to a virgin
> b55 tree should work seamlessly. Please check this out and let me
> know what you think?
Thanks.
I've taken a look at the code, and I have some more questions:
* Why are the docstrings ignored? I think it's important that we keep
the syntax and semantics of DEFUNs equivalent between the "core
code" and the modules.
* The sentences in the documentation should be separated with two
spaces. This convention is adhered to in all of XEmacs, and it
makes it easier to move through the text using M-a and M-e.
* You have some needless GCPRO's, I think. For example, I don't think
GCPRO'ing FILE, NAME and VERSION in Fdll_load() is needed. As a
rule, each function needs to GCPRO the arguments created within it.
* You always need to call Fexpand_file_name() on file arguments called
from Lisp, otherwise (dll-load "~/foo.so") will fail. Unless
another function down the stack expands the file name, such as
locate_file(). You should test it, to be sure.
* I'm not sure it's a good idea to pick the loadable modules from
load-path. Perhaps there should be a `dynamic-load-path'?
Here is my guide for Mule coding. It's in the Texinfo format. Apply
it to XEmacs, remake internals, et voila.
--- man/internals/internals.texi.orig Wed Sep 9 15:45:30 1998
+++ man/internals/internals.texi Wed Sep 9 22:57:01 1998
＠＠ -1654,6 +1654,7 ＠＠
* General Coding Rules::
* Writing Lisp Primitives::
* Adding Global Lisp Variables::
+* Coding for Mule::
* Techniques for XEmacs Developers::
＠end menu
＠＠ -1754,7 +1755,7 ＠＠
＠{
val = Feval (XCAR (args));
if (!NILP (val))
- break;
+ break;
args = XCDR (args);
＠}
＠＠ -2023,6 +2024,352 ＠＠
is in use, and will happily collect it and reuse its storage for another
Lisp object, and you will be the one who's unhappy when you can't figure
out how your variable got overwritten.
+
+＠node Coding for Mule
+＠section Coding for Mule
+＠cindex Coding for Mule
+
+Although Mule support is not compiled by default in XEmacs, many people
+are using it, and we consider it crucial that new code works correctly
+with multibyte characters. This is not hard; it is only a matter of
+following several simple user-interface guidelines. Even if you never
+compile with Mule, with a little practice you will find it quite easy
+to code Mule-correctly.
+
+Note that these guidelines are not necessarily tied to the current Mule
+implementation; they are also a good idea to follow on the grounds of
+code generalization for future I18N work.
+
+＠menu
+* Character-Related Data Types::
+* Working With Character and Byte Positions::
+* Conversion of External Data::
+* General Guidelines for Writing Mule-Aware Code::
+* An Example of Mule-Aware Code::
+＠end menu
+
+＠node Character-Related Data Types
+＠subsection Character-Related Data Types
+
+First, we will list the basic character-related datatypes used by
+XEmacs. Note that the separate ＠code{typedef}s are not required for the
+code to work (all of them boil down to ＠code{unsigned char} or
+＠code{int}), but they improve clarity of code a great deal, because one
+glance at the declaration can tell the intended use of the variable.
+
+＠table ＠code
+＠item Emchar
+＠cindex Emchar
+An ＠code{Emchar} holds a single Emacs character.
+
+Obviously, the equality between characters and bytes is lost in the Mule
+world. Characters can be represented by one or more bytes in the
+buffer, and ＠code{Emchar} is the C type large enough to hold any
+character.
+
+Without Mule support, an ＠code{Emchar} is equivalent to an
+＠code{unsigned char}.
+
+＠item Bufbyte
+＠cindex Bufbyte
+The data representing the text in a buffer or string is logically a set
+of ＠code{Bufbyte}s.
+
+XEmacs does not work with character formats all the time; when reading
+characters from the outside, it decodes them to an internal format, and
+likewise encodes them when writing. ＠code{Bufbyte} (in fact
+＠code{unsigned char}) is the basic unit of XEmacs internal buffers and
+strings format.
+
+One character can correspond to one or more ＠code{Bufbyte}s. In the
+current implementation, an ASCII character is represented by the same
+＠code{Bufbyte}, and extended characters are represented by a sequence of
+＠code{Bufbyte}s.
+
+Without Mule support, a ＠code{Bufbyte} is equivalent to an
+＠code{Emchar}.
+
+＠item Bufpos
+＠itemx Charcount
+A ＠code{Bufpos} represents a character position in a buffer or string.
+A ＠code{Charcount} represents a number (count) of characters.
+Logically, subtracting two ＠code{Bufpos} values yields a
+＠code{Charcount} value. Although all of these are ＠code{typedef}ed to
+＠code{int}, we use them in preference to ＠code{int} to make it clear
+what sort of position is being used.
+
+＠code{Bufpos} and ＠code{Charcount} values are the only ones that are
+ever visible to Lisp.
+
+＠item Bytind
+＠itemx Bytecount
+A ＠code{Bytind} represents a byte position in a buffer or string. A
+＠code{Bytecount} represents the distance between two positions in bytes.
+The relationship between ＠code{Bytind} and ＠code{Bytecount} is the same
+as the relationship between ＠code{Bufpos} and ＠code{Charcount}.
+
+＠item Extbyte
+＠itemx Extcount
+When dealing with the outside world, XEmacs works with ＠code{Extbyte}s,
+which are equivalent to ＠code{unsigned char}. Obviously, an
+＠code{Extcount} is the distance between two ＠code{Extbyte}s. Extbytes
+and Extcounts are not all that frequent in XEmacs code.
+＠end table
+
+＠node Working With Character and Byte Positions
+＠subsection Working With Character and Byte Positions
+
+Now that we have defined the basic character-related types, we can look
+at the macros and functions designed for work with them and for
+conversion between them. Most of these macros are defined in
+(a)file{buffer.h}, and we don't discuss all of them here, but only the
+most important ones. Examining the existing code is the best way to
+learn about them.
+
+＠table ＠code
+＠item MAX_EMCHAR_LEN
+This preprocessor constant is the maximum number of buffer bytes per
+Emacs character, i.e. the byte length of an ＠code{Emchar}. It is useful
+when allocating temporary strings to keep a known number of characters.
+For instance:
+
+＠example
+＠group
+＠{
+ Charcount cclen;
+ ...
+ ＠{
+ /* Allocate place for ＠var{cclen} characters. */
+ Bufbyte *tmp_buf = (Bufbyte *)alloca (cclen * MAX_EMCHAR_LEN);
+...
+＠end group
+＠end example
+
+If you followed the previous section, you can guess that, logically,
+multiplying a ＠code{Charcount} value with ＠code{MAX_EMCHAR_LEN} produces
+a ＠code{Bytecount} value.
+
+In the current Mule implementation, ＠code{MAX_EMCHAR_LEN} equals 4.
+Without Mule, it is 1.
+
+＠item charptr_emchar
+＠item set_charptr_emchar
+＠code{charptr_emchar} macro takes a ＠code{Bufbyte} pointer and returns
+the underlying ＠code{Emchar}. If it were a function, its prototype
+would be:
+
+＠example
+Emchar charptr_emchar (Bufbyte *p);
+＠end example
+
+＠code{set_charptr_emchar} stores an ＠code{Emchar} to the specified byte
+position. It returns the number of bytes stored:
+
+＠example
+Bytecount set_charptr_emchar (Bufbyte *p, Emchar c);
+＠end example
+
+It is important to note that ＠code{set_charptr_emchar} is safe only for
+appending a character at the end of a buffer, not for overwriting a
+character in the middle. This is because the width of characters
+varies, and ＠code{set_charptr_emchar} cannot resize the string if it
+writes, say, a two-byte character where a single-byte character used to
+reside.
+
+A typical use of ＠code{set_charptr_emchar} can be demonstrated by this
+example, which copies characters from buffer ＠var{buf} to a temporary
+string of Bufbytes.
+
+＠example
+＠group
+＠{
+ Bufpos pos;
+ for (pos = beg; pos < end; pos++)
+ ＠{
+ Emchar c = BUF_FETCH_CHAR (buf, pos);
+ p += set_charptr_emchar (buf, c);
+ ＠}
+＠}
+＠end group
+＠end example
+
+Note how ＠code{set_charptr_emchar} is used to store the ＠code{Emchar}
+and increment the counter, at the same time.
+
+＠item INC_CHARPTR
+＠itemx DEC_CHARPTR
+These two macros increment and decrement a ＠code{Bufbyte} pointer,
+respectively. The pointer needs to be correctly positioned at the
+beginning of a valid character position.
+
+Without Mule support, ＠code{INC_CHARPTR (p)} and ＠code{DEC_CHARPTR (p)}
+simply expand to ＠code{p++} and ＠code{p--}, respectively.
+
+＠item bytecount_to_charcount
+Given a pointer to a text string and a length in bytes, return the
+equivalent length in characters.
+
+＠example
+Charcount bytecount_to_charcount (Bufbyte *p, Bytecount bc);
+＠end example
+
+＠item charcount_to_bytecount
+Given a pointer to a text string and a length in characters, return the
+equivalent length in bytes.
+
+＠example
+Bytecount charcount_to_bytecount (Bufbyte *p, Charcount cc);
+＠end example
+
+＠item charptr_n_addr
+Return a pointer to the beginning of the character offset ＠var{cc} (in
+characters) from ＠var{p}.
+
+＠example
+Bufbyte *charptr_n_addr (Bufbyte *p, Charcount cc);
+＠end example
+＠end table
+
+＠node Conversion of External Data
+＠subsection Conversion of External Data
+
+When an external function, such as a C library function, returns a
+＠code{char} pointer, you should never treat it as ＠code{Bufbyte}. This
+is because these returned strings may contain 8bit characters which can
+be misinterpreted by XEmacs, and cause a crash. Instead, you should use
+a conversion macro. Many different conversion macros are defined in
+(a)file{buffer.h}, so I will try to order them logically, by direction and
+by format.
+
+Thus the basic conversion macros are ＠code{GET_CHARPTR_INT_DATA_ALLOCA}
+and ＠code{GET_CHARPTR_EXT_DATA_ALLOCA}. The former is used to convert
+external data to internal format, and the latter is used to convert the
+other way around. The arguments each of these receives are ＠var{ptr}
+(pointer to the text in external format), ＠var{len} (length of texts in
+bytes), ＠var{fmt} (format of the external text), ＠var{ptr_out} (lvalue
+to which new text should be copied), and ＠var{len_out} (lvalue which
+will be assigned the length of the internal text in bytes). The
+resulting text is stored to a stack-allocated buffer. If the text
+doesn't need changing, these macros will do nothing, except for setting
+＠var{len_out}.
+
+Currently meaningful formats are ＠code{FORMAT_BINARY},
+＠code{FORMAT_FILENAME}, ＠code{FORMAT_OS}, and ＠code{FORMAT_CTEXT}.
+
+The two macros above take many arguments which makes them unwieldy. For
+this reason, several convenience macros are defined with obvious
+functionality, but accepting less arguments:
+
+＠table ＠code
+＠item GET_C_CHARPTR_EXT_DATA_ALLOCA
+＠itemx GET_C_CHARPTR_INT_DATA_ALLOCA
+These two macros work on ``C char pointers'', which are zero-terminated,
+and thus do not need ＠var{len} or ＠var{len_out} parameters.
+
+＠item GET_STRING_EXT_DATA_ALLOCA
+＠itemx GET_C_STRING_EXT_DATA_ALLOCA
+These two macros work on Lisp strings, thus also not needing a ＠var{len}
+parameter. However, ＠code{GET_STRING_EXT_DATA_ALLOCA} still provides a
+＠var{len_out} parameter. Note that for Lisp strings only one conversion
+direction makes sense.
+
+＠item GET_C_CHARPTR_EXT_BINARY_DATA_ALLOCA
+＠itemx GET_C_CHARPTR_EXT_FILENAME_DATA_ALLOCA
+＠itemx GET_C_CHARPTR_EXT_CTEXT_DATA_ALLOCA
+＠itemx ...
+These macros are a combination of the above, but with the ＠var{fmt}
+argument encoded into the name of the macro.
+＠end table
+
+＠node General Guidelines for Writing Mule-Aware Code
+＠subsection General Guidelines for Writing Mule-Aware Code
+
+This section contains some general guidance on how to write Mule-aware
+code, as well as some pitfalls you should avoid.
+
+＠table ＠emph
+＠item Never use ＠code{char} and ＠code{char *}.
+In XEmacs, the use of ＠code{char} and ＠code{char *} is almost always a
+mistake. If you want to manipulate an Emacs character from ``C'', use
+＠code{Emchar}. If you want to examine a specific octet in the internal
+format, use ＠code{Bufbyte}. If you want a Lisp-visible character, use a
+＠code{Lisp_Object} and ＠code{make_char}. If you want a pointer to move
+through the internal text, use ＠code{Bufbyte *}. Also note that you
+almost certainly do not need ＠code{Emchar *}.
+
+＠item Be careful not to confuse ＠code{Charcount}, ＠code{Bytecount}, and ＠code{Bufpos}.
+The whole point of using different types is to avoid confusion about the
+use of certain variables. Lest this effect be nullified, you need to be
+careful about using the right types.
+
+＠item Always convert external data
+It is extremely important to always convert external data, because
+XEmacs can crash if unexpected 8bit sequences are copied to its internal
+buffers literally.
+
+This means that when a system function, such as ＠code{readdir}, returns
+a string, you need to convert it using one of the conversion macros
+described in the previous chapter, before passing it further to Lisp.
+In the case of ＠code{readdir}, you would use the
+＠code{GET_C_CHARPTR_INT_FILENAME_DATA_ALLOCA} macro.
+
+Also note that many internal functions, such as ＠code{make_string},
+accept Bufbytes, which removes the need for them to convert the data
+they receive. This increases efficiency because that way external data
+needs to be decoded only once, when it is read. After that, it is
+passed around in internal format.
+＠end table
+
+＠node An Example of Mule-Aware Code
+＠chapter An Example of Mule-Aware Code
+
+As an example of Mule-aware code, we shall will analyze the
+＠code{string} function, which conses up a Lisp string from the character
+arguments it receives. Here is the definition, pasted from
+(a)code{alloc.c}:
+
+＠example
+＠group
+DEFUN ("string", Fstring, 0, MANY, 0, /*
+Concatenate all the argument characters and make the result a string.
+*/
+ (int nargs, Lisp_Object *args))
+＠{
+ Bufbyte *storage = alloca_array (Bufbyte, nargs * MAX_EMCHAR_LEN);
+ Bufbyte *p = storage;
+
+ for (; nargs; nargs--, args++)
+ ＠{
+ Lisp_Object lisp_char = *args;
+ CHECK_CHAR_COERCE_INT (lisp_char);
+ p += set_charptr_emchar (p, XCHAR (lisp_char));
+ ＠}
+ return make_string (storage, p - storage);
+＠}
+＠end group
+＠end example
+
+Now we can analyze the source line by line.
+
+Obviously, string will be as long as there are arguments to the
+function. This is why we allocate ＠code{MAX_EMCHAR_LEN} * ＠var{nargs}
+bytes on the stack, i.e. the worst-case number of bytes for ＠var{nargs}
+＠code{Emchar}s to fit in the string.
+
+Then, the loop checks that each element is a character, converting
+integers in the process. Like many other functions in XEmacs, this
+function silently accepts integers where characters are expected, for
+historical and compatibility reasons. Unless you know what you are
+doing, ＠code{CHECK_CHAR} will also suffice. ＠code{XCHAR (lisp_char)}
+extracts the ＠code{Emchar} from the ＠code{Lisp_Object}, and
+＠code{set_charptr_emchar} stores it to storage, increasing ＠code{p} in
+the process.
+
+Other instructing examples of correct coding under Mule can be found all
+over XEmacs code. For starters, I recommend
+＠code{Fnormalize_menu_item_name} in ＠file{menubar.c}. After you have
+understood this section of the manual and studied the examples, you can
+proceed writing new Mule-aware code.
＠node Techniques for XEmacs Developers
＠section Techniques for XEmacs Developers
--
Hrvoje Niksic <hniksic(a)srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
The end of the world is coming... SAVE YOUR BUFFERS!
- 1 participants
- 0 comments
RE: Release notes -- package update 1998/09/19
25 years, 7 months
Damon Lipparelli
Damon Lipparelli
After installing this version of VM (by hand), I can't use VM at all.
Invoking VM, I get:
Signaling: (file-error "Cannot open load file" "vm")
load-internal("vm" nil t nil nil nil)
load("vm" nil t nil)
require(vm)
vm-session-initialization()
#<compiled-function (&optional folder read-only) "...(7)"
[vm-session-initialization done (byte-code "À !?Â???? À
!«f ªÝ ®?É\n
\"
Í
!«?ÎÏ
\"ªÄÐ
!®¾
«?É
!®'ÒÂÓ ×Ø
\"^Ù
! ®'\n? ＠s¬?B)×Ü
\"^,)?q^Ý B «Åà !àá!=¬»à !àâ!=¬±à !àã!=¬§à !àä!=¬Âå
& 'èéed #^êÓÂ\"^ëed #^+ì ^í ^å ¬fî/0ñ=?2<å ??óô
2\"?®5®Sö÷!®...
''7
«-øp!^ùî!^úî!^û ^å ¬"ü ýÂ?Â#^
«(tm)¬*þ ^ÿ ^＠ ^A ^B ^
«...C ^«-D«"E F «...G ªfH \"^««I®...J®p KL K?DCD®fM
N D$^O«...P ^)«...Q R ^S ^T «sU«-×V !^W ^×X !^Y
^Z«<[ «...\\ ^«Ð] «S
¬?^ ÒÂ\"^I«'_«`«?O«...P ^a«-L Â?DCD®fM N D$^ªSb
I®...J®p!^)c«...d ^e f !^«"×
!^«
«S×g h !!^«f
«?i j Ò\"^k«½l¬¹7¬µ×m 2®"n \"^o Ò!«oeýÒ!«-Q R «?d
^ª...S ^×
!^t"p?q ^r ?f×
!.?" ... 7)] 2 "Read mail under Emacs.\nOptional first arg FOLDER
specifies the folder to visit. It defaults\nto the value of
vm-primary-inbox. The folder buffer is put into VM\nmode, a major mode
for reading mail.\n\nPrefix arg or optional second arg READ-ONLY non-nil
indicates\nthat the folder should be considered read only. No
attribute\nchanges, message additions or deletions will be allowed in
the\nvisited folder.\n\nVisiting the primary inbox causes any contents
of the system mailbox to\nbe moved and appended to the resulting
buffer.\n\nAll the messages can be read by repeatedly pressing SPC. Use
`n'ext and\n`p'revious to move about in the folder. Messages are marked
for\ndeletion with `d', and saved to another folder with `s'. Quitting
VM\nwith `q' expunges deleted messages and saves the buffered folder
to\ndisk.\n\nSee the documentation for vm-mode for more information."
(list nil current-prefix-arg)>(nil nil)
call-interactively(vm)
command-execute(vm t)
execute-extended-command(nil)
call-interactively(execute-extended-command)
-lipp
-----Original Message-----
From: SL Baur [mailto:steve＠xemacs.org]
Sent: Saturday, September 19, 1998 11:14 PM
To: xemacs-beta(a)xemacs.org
Subject: Release notes -- package update 1998/09/19
[Important question for the folks working on package installers at the
bottom.]
I've updated all the packages in
ftp://ftp.xemacs.org/pub/xemacs/packages/
A massive SUMO tarball of the staging area after I was done building
(which should now be equivalent to the results obtained installing
everything by hand) is at:
ftp://ftp.xemacs.org/pub/xemacs/packages/xemacs-SUMO-1998-09-19.tar.gz
It's probably not runnable without deleting some packages by hand first.
The index file is:
ftp://ftp.xemacs.org/pub/xemacs/packages/package-get-base.el-1998-09-19
The only code updates were
vm-1.11:
Synch with VM 6.62
pgnus-1.01:
Synch with Pterodactyl Gnus 0.31
Everything else is repackaging. A handful of packages had some files
rearranged. mule-base no longer creates two subdirectories in etc/.
rmail, xemacs-base, and viper no longer create subdirectories for
their data files. A handful of packages had their READMEs and other
documentation restored.
The user visible changes are:
No more _pkg.el files. I haven't decided whether this is a good idea
or not. *Not* including them means that the auto-autoloads.el can't
be properly updated and this is probably a bad thing.
Every package includes a manifest file of the form
pkginfo/MANIFEST.$(PACKAGE). This should make a safe package delete
function a slam dunk.
TexInfo sources are now included in subdirectories of a new package
top-level directory called man. There probably ought to be an option
at installation time as to whether they should be installed or not,
since they're not actually needed at run-time.
Build level changes:
The way files are copied to the installation or staging area has been
fixed. There is no much more restricted use of wildcards, and it
should now be possible to safely `make install' into a tree you are
running from. In particular, the copy *.el* is now history.
Packages that are custom-ized are now required to have
GENERATED += custom-load.elc
after they include XEmacs.rules.
For packages with data files that go into etc/, there are two symbols
which must be defined. The symbol `DATA_FILES' should be a list of
files to be copied relative to the package build directory
(eg. comm/footnote, etc.) in exactly the same fashion ELCS works now.
examples:
DATA_FILES = relative/path/to/each/data/file
DATA_FILES = $(wildcard images/*.png)
The symbol DATA_DEST indicates where in etc/ the files are to be
copied to. Typically it should be set to $(PACKAGE), but if files
need to be placed directly in etc/, it can be ".". The installation
directory is built up as `etc/$(DATA_DEST)/'.
The semantics of INFO_FILES has been changed so that it works the same
way `ELCS' and `DATA_FILES' does. Every file listed gets installed
into info/.
For packages with texinfo documentation, there are two new symbols.
`TEXI_FILES', which should be set the same way `ELCS', `DATA_FILES',
and `INFO_FILES' are set and `MANUAL'. Every file listed in
`TEXI_FILES' will be installed into the directory man/$(PACKAGE)/.
The variable `MANUAL' is left as a hook if someone wants to hack
together something to build hardcopy.
example assuming two manuals, `foo' and `bar':
TEXI_FILES = texi/foo.texi texi/bar.texi texi/gpl.texinfo
MANUAL = foo bar
It is important for packages that do not have data files, or texinfo
files to not set these variables (I found one package which did, but I
fixed it).
I'm going to try to create a template package Makefile tonight, and
write some formal documentation on this. With only two primary[1]
exceptions (Gnus[2] and psgml[3]), every package now has a generic
build target.
*Question for the people who have been coding installation clients:*
The `standards-version' has been held at 1.0, but there is enough of
an interface change, particularly the new existence of a MANIFEST file ,
to warrant changing the version number. Will this help out coding?
Basically, you would know that any package with standards-version 1.0
doesn't have delete information, and anything higher means it does.
Footnotes:
[1] As opposed to the three packages which contain no installable
lisp and need some handholding because there is no non-source install
target.
[2] Multiple etc/ directories aren't handled automatically.
[3] 2nd level subdirectories in etc/ are now not handled automatically.
- 1 participants
- 0 comments
Re: DLL stuff (working!)
25 years, 7 months
Hrvoje Niksic
Hrvoje Niksic
"J. Kean Johnston" <jkj(a)sco.com> writes:
> Attached is a small tar file with a patch and a new dll.c, a header
> file and a sample DLL module. This is very raw right now, so you
> will need to do a bit of work to get this working.
Very, very interesting. Your work is much more mature than anything
else done so far on this topic, and I am very happy to see it written.
I'd like to offer a few important comments and questions:
* Why is the syntax of declaring dynamic SUBR's different from the
rest of XEmacs? I'm not sure this is acceptable, really.
* Why are you using specialized error functions instead of the Emacs
ones? As a reminder, Emacs has error(), signal_simple_error(), and
a bunch of others. See eval.c for details.
Also, your error messages are at odds with the usual Emacs error
conventions. Please look them up, or mail me privately if you need
more details on what exactly I mean.
* I believe your code is not Mule-clean, and as such not eligible for
application to XEmacs. Hint: casting XSTRING_DATA (foo) to `char *'
is something that should *NOT* be done. Again, ask if you need more
explanations.
* dll-list-modules should really return a list, not a vector. Vectors
should be used only for data structures that require random access,
as opposed to front-to-end searches.
--
Hrvoje Niksic <hniksic(a)srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
"A Real Programmer's code can awe with its fiendish brilliance, even
as its crockishness appalls."
- 2 participants
- 1 comments
build report as requested
25 years, 7 months
tom
tom
No problems yet :-)
uname -a: Linux rasputin 2.1.107 #29 SMP Sat Sep 19 20:28:07 MEST 1998 i586 unknown
./configure '--dynamic' '--with-scrollbars=athena3d' '--with-dialogs=athena3d' '--with-xfs' '--with-xim=xlib' '--debug=no' '--error-checking=no' '--package-path=/usr/local/lib/xemacs/packages' '--with-mule'
XEmacs 21.2-b1 "Aeolus" configured for `i586-pc-linux'.
Where should the build process find the source code? /usr/src/xemacs-21.2-b1
What installation prefix should install use? /usr/local
What operating system and machine description files should XEmacs use?
`s/linux.h' and `m/intel386.h'
What compiler should XEmacs be built with? gcc -g -O3 -Wall -Wno-switch
Should XEmacs use the GNU version of malloc? yes
(Using Doug Lea's new malloc from the Linux C Library.)
Should XEmacs use the relocating allocator for buffers? yes
What window system should XEmacs use? x11
Where do we find X Windows header files? /usr/X11/include
Where do we find X Windows libraries? /usr/X11/lib
Compiling in support for XAUTH.
Compiling in support for XPM images.
Compiling in support for JPEG image conversion.
Compiling in support for PNG image conversion.
Compiling in support for TIFF image conversion.
Compiling in native sound support.
Compiling in support for Berkeley DB.
Compiling in support for GNU DBM.
Compiling in support for LDAP (UMich libs).
Compiling in support for ncurses.
Compiling in support for GPM (General Purpose Mouse).
Compiling in Mule (multi-lingual) support.
Compiling in XIM (X11R5+ I18N input method) support.
Using raw Xlib to provide XIM support.
Using XFontSet to provide bilingual menubar.
Compiling in support for proper session-management.
Using Lucid menubars.
Using Athena-3d scrollbars.
Using Athena-3d dialog boxes.
Compiling in DLL support.
movemail will use "dot-locking" for locking mail spool files.
Using Lisp_Objects with minimal tagbits.
- 1 participants
- 0 comments
Re: Isearch keymap bug
25 years, 7 months
Hrvoje Niksic
Hrvoje Niksic
Jan Vroonhof <vroonhof(a)math.ethz.ch> writes:
> Of course really isearch should work like it has a minibuffer as the
> selected window/buffer but just display the cursor of the window the
> search is being done in.
>
> Then this problem would never have appeared. You would also be able
> to C-x o your way out of an isearch and later return to it by
> jumping into the minibuffer again.
That would IMHO be vastly different (and worse) from what Isearch has
done traditionally. I don't *want* C-x o to return me to isearch; I
want it to terminate the search and change windows. The reason
isearch is such a cool feature is that it allows you to do things with
very little keystrokes. This is why it is not conceptually similar to
minibuffers.
--
Hrvoje Niksic <hniksic(a)srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
Speak softly and carry a +6 two-handed sword.
- 1 participants
- 0 comments
Backspace screwed in M-x set-variable
25 years, 7 months
Jan Vroonhof
Jan Vroonhof
xemacs -vanilla
M-x set-variable
enter any variable RET
Type something at the 'Set foobar to value"' prompt
Try to erase by using backspace.
Here it brings up the help buffer instead.
Jan
- 1 participants
- 0 comments
Re: Isearch keymap bug
25 years, 7 months
Jan Vroonhof
Jan Vroonhof
Hrvoje Niksic <hniksic(a)srce.hr> writes:
> Isearch should probably use overriding-local-map or something like
> that, instead of kludgily hooking into minor mode maps.
Of course really isearch should work like it has a minibuffer as the
selected window/buffer but just display the cursor of the window the
search is being done in.
Then this problem would never have appeared. You would also be able to
C-x o your way out of an isearch and later return to it by jumping
into the minibuffer again.
Jan
- 1 participants
- 0 comments
Re: Yet another SUMO tarball...
25 years, 7 months
Michael Sperber
Michael Sperber
>>>>> "Jonathan" == Jonathan Harris <jhar(a)tardis.ed.ac.uk> writes:
Jonathan> Jan Vroonhof wrote:
>> In particular it contains
>>
>> lib/xemacs/site-packages
>> Put packages that are not official XEmacs packages
>> here. (Empty).
>> lib/xemacs/mule-packages
>> All packages related to the operation of a MULE enabled
>> XEmacs. Non MULE XEmacsen do not use them.
>> lib/xemacs/xemacs-packages
Jonathan> ^^^^^^^^^^^^^^^
Jonathan> According to INSTALL, that should be just 'packages', and that's what
Jonathan> native Windows systems expect.
Ooops. That's wrong. I had totally forgotten that INSTALL mentioned
a location. 'xemacs-packages' is correct, and 'packages' is slated to
go away soon.
--
Cheers =8-} Chipsy
Friede, Völkerverständigung und überhaupt blabla
- 1 participants
- 0 comments
Re: Yet another SUMO tarball...
25 years, 7 months
Didier Verna
Didier Verna
Jonathan Harris <jhar(a)tardis.ed.ac.uk> writes:
> Jan Vroonhof wrote:
>
> > For convenience of use with XEmacs
> > binary distributions the SUMO tarball contains these with a
> > 'lib/xemacs' prefix.
> ^^^^^^^^^^
>
> Please don't do that. The appropriate path on native Windows systems
> doesn't include the lib/xemacs bit. A brief note in the README advising
> the user to unpack into lib/xemacs would probably be as good.
One day, we're gonna have to be very clean on this. I think it's too
late for 21.0, but we should really discuss the install location of packages
and related stuff for 21.2.
IMO, there are two policies: either you install in the standard places
(/usr/local/ etc/ lib/ libexec/ share/ ...), or you install somewhere like
/usr/local/xemacs/ and then you reproduce a standard tree. In any case, the
current installation method is bad, especially installing the xemacs subdir
under lib/.
Let's address problems in order. I'll start this again after 21.0 is released.
--
/ / _ _ Didier Verna http://www.inf.enst.fr/~verna/
- / / - / / /_/ / E.N.S.T. INF C201.1 mailto:verna＠inf.enst.fr
/_/ / /_/ / /__ / 46 rue Barrault Tel. (33) 01 45 81 73 46
75634 Paris cedex 13 Fax. (33) 01 45 81 31 19
- 1 participants
- 0 comments
Isearch keymap bug
25 years, 7 months
Hrvoje Niksic
Hrvoje Niksic
Isearch sets its keymap at the front of the minor mode map alist in
order to take precedence over all other keymaps. Historically, it was
good enough, but it is not good enough with extents' `keymap'
property. Repeat the observed bug with the following steps:
M-x about-xemacs RET
C-s hrvoje RET
So, we search for `hrvoje' in the About page, and press RET to
terminate the search. However, RET gets read by the extent's keymap,
and the link is followed besides the search being terminated. This is
wrong.
The same bug can be triggered in the latest Gnus, when you press `s'
to search the article, and then press the "wrong" key while over a
button.
Isearch should probably use overriding-local-map or something like
that, instead of kludgily hooking into minor mode maps. I'll try to
cons up a patch, but it may be non-trivial to fix without breaking
something else.
--
Hrvoje Niksic <hniksic(a)srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
The end of the world is coming... SAVE YOUR BUFFERS!
- 1 participants
- 0 comments