June 1998 - XEmacs-Beta - XEmacs Mailing List Archives

Re: [PATCH] 21.0-b46: hacking on the hook fixes 21 years, 7 months

Kai Haberzettl

Kyle Jones <kyle_jones(a)wonderworks.com> writes: > The run_hook_with_args_in_buffer patch neglected the nil case. > > Ben pointed out a problem with the remove-hook patch. > > Since Steven applied the other patches, this one is on top of > those. This fixed remove-hook problems I initially had when running Gnus. Everything running perfectly now. Kai

1 participants
0 comments

XEmacs Info node missing ? 21 years, 7 months

Ian MacKinnon

When I click on the Xemacs node after having done "C-H i" I get "No such node Xemacs", and sure enough in the info directory it's not there. Where does this come from ? All I downloaded was xemacs-21.0-b46.tar.gz This is on NT + cygwin --- Ian

3 participants
2 comments

[PATCH] 21.0-b46: hacking on the hook fixes 21 years, 7 months

Kyle Jones

The run_hook_with_args_in_buffer patch neglected the nil case. Ben pointed out a problem with the remove-hook patch. Since Steven applied the other patches, this one is on top of those. 1998-06-29 Kyle Jones <kyle_jones(a)wonderworks.com> * src/eval.c (run_hook_with_args_in_buffer): Check default (non-buffer-local) value of hook for nil before treating it as a function. Don't initialize the `globals' variable twice. * lisp/subr.el (remove-hook): When checking the hook value with functionp, don't apply car to it. --- src/eval.c 1998/06/30 02:49:15 +++ src/eval.c 1998/06/30 15:16:43 ＠＠ -3728,14 +3728,15 ＠＠ it means to run the global binding too. */ Lisp_Object globals = Fdefault_value (sym); - if (! CONSP (globals) || EQ (XCAR (globals), Qlambda)) + if ((! CONSP (globals) || EQ (XCAR (globals), Qlambda)) && + ! NILP (globals)) { args[0] = globals; ret = Ffuncall (nargs, args); } else { - for (globals = Fdefault_value (sym); + for (; CONSP (globals) && ((cond == RUN_HOOKS_TO_COMPLETION) || (cond == RUN_HOOKS_UNTIL_SUCCESS ? NILP (ret) --- lisp/subr.el 1998/06/30 15:19:13 +++ lisp/subr.el 1998/06/30 15:25:44 ＠＠ -194,14 +194,14 ＠＠ (and (local-variable-p hook (current-buffer)) (not (memq t (symbol-value hook))))) (let ((hook-value (symbol-value hook))) - (if (and (consp hook-value) (not (functionp (car hook-value)))) + (if (and (consp hook-value) (not (functionp hook-value))) (if (member function hook-value) (setq hook-value (delete function (copy-sequence hook-value)))) (if (equal hook-value function) (setq hook-value nil))) (set hook hook-value)) (let ((hook-value (default-value hook))) - (if (and (consp hook-value) (not (functionp (car hook-value)))) + (if (and (consp hook-value) (not (functionp hook-value))) (if (member function hook-value) (setq hook-value (delete function (copy-sequence hook-value)))) (if (equal hook-value function)

2 participants
1 comments

rfhookfun 21 years, 7 months

Andy Piper

This is the offending change, if you back this out all is well with the world again. andy RCS file: /usr/CVSroot/XEmacs/xemacs-20/lisp/subr.el,v retrieving revision 1.6 retrieving revision 1.7 diff -u -u -r1.6 -r1.7 --- subr.el 1998/05/16 05:06:54 1.6 +++ subr.el 1998/06/30 06:35:26 1.7 ＠＠ -194,14 +194,14 ＠＠ (and (local-variable-p hook (current-buffer)) (not (memq t (symbol-value hook))))) (let ((hook-value (symbol-value hook))) - (if (consp hook-value) + (if (and (consp hook-value) (not (functionp (car hook-value)))) (if (member function hook-value) (setq hook-value (delete function (copy-sequence hook-value))) ) (if (equal hook-value function) (setq hook-value nil))) (set hook hook-value)) (let ((hook-value (default-value hook))) - (if (consp hook-value) + (if (and (consp hook-value) (not (functionp (car hook-value)))) (if (member function hook-value) (setq hook-value (delete function (copy-sequence hook-value)))) (if (equal hook-value function) --------------------------------------------------------------------------- " .sigs are like your face - rarely seen by you and uglier than you think" Dr Andy Piper, Technical Architect, Parallax Solutions Ltd mail: andyp(a)parallax.co.uk web: www.parallax.co.uk/~andyp

1 participants
0 comments

Sorry... (was: Re: rfhookfun) 21 years, 7 months

Tetsuya HOYANO

I am terribly sorry for Andy as looked I was pretend him... It was NOT my intention to pretend someone when I sent previous mail. It is just my post against the Andy's post which is <3.0.3.32.19980630134108.00f74878(a)exchange.parallax.co.uk> Again, sorry for everyone, --HOYANO

1 participants
0 comments

Re: rfhookfun 21 years, 7 months

Remek Trzaska

>>>>> "Andy" == Andy Piper <andyp(a)parallax.co.uk> writes: Andy> pre4 (?) very quickly becomes unuseable with the error: Andy> Symbol's value as variable is void: rfhookfun. Andy> anyone else see this? Yes. I *also* had problems with: 1. (enable-command 'narrow-to-region) in my init file: Signaling: (void-function nil) nil(5628 5628 38) enable-command(narrow-to-region) load-internal("~/.emacs" t t t undecided) load("~/.emacs" t t t) load-user-init-file("") load-init-file() command-line() normal-top-level() 2. M-x build-report: Signaling: (void-function nil) nil(1 3 0) message-fill-address(To "xemacs-build-reports(a)xemacs.org") mail-header-format(((Newsgroups) (To . message-fill-address) (Cc . message-fill-address) (Subject) (In-Reply-To) (Fcc) (Bcc) (Date) (Organization) (Distribution) (Lines) (Expires) (Message-ID) (References . message-fill-header) (X-Mailer) (X-Newsreader)) ((To . "xemacs-build-reports(a)xemacs.org") (Subject . "[success] 21.0 \"Uzbek Black-pre1\" XEmacs Lucid on mips-sgi-irix6.3"))) message-setup(((To . "xemacs-build-reports(a)xemacs.org") (Subject . "[success] 21.0 \"Uzbek Black-pre1\" XEmacs Lucid on mips-sgi-irix6.3"))) message-mail("xemacs-build-reports(a)xemacs.org" "[success] 21.0 \"Uzbek Black-pre1\" XEmacs Lucid on mips-sgi-irix6.3" nil nil nil nil nil) compose-mail("xemacs-build-reports(a)xemacs.org" "[success] 21.0 \"Uzbek Black-pre1\" XEmacs Lucid on mips-sgi-irix6.3" nil nil nil nil nil) #<compiled-function (&rest args) "...(61)" [compose-mail build-report-destination apply format build-report-subject args nil report-begin build-report-insert-make-output build-report-insert-installation-file build-report-installation-insert-all build-report-insert-header] 8 ("/home/R11A/remek/local/src/xemacs-20/lisp/build-report.elc" . 3555) (byte-code "�� \n��\n＠＠\n＠A\nA� ��#B�h,�" [nil build-report-prompts prompts arg hist prompt read-string ""] 4)>("success") call-interactively(build-report) command-execute(build-report t) execute-extended-command(nil) call-interactively(execute-extended-command)

1 participants
0 comments

Re: Where do you want to go tomorrow? 21 years, 7 months

Michael Sperber

[ Ben: Changing the Lisp engine is not going to affect users much. ] I totally agree with Ben that there are more important immediate issues in XEmacs development than replacement of the Lisp engine, even though swapping the Lisp engine could make a lot of development issues considerably easier. Unexec (first on Ben's list) should be one of first. I disagree, however, that changing the Lisp engine is not going to affect users. The immediate consequence of a new engine is going to be performance; XEmacs runs dog-slow in many areas, and (long-term, not ignoring the recent improvements) it has become slower faster than machines have been getting faster. People have been complaining about other aspects of the system which can only be fixed with a new substrate. Multithreading comes to mind. Also, Emacs Lisp currently is hampering the development work I can do for XEmacs. Programming idioms common among modern programming languages are painful in Emacs Lisp, and as such Emacs Lisp development is, for me, currently at least 3 times as slow as it should be, and considerably less fun. I don't enjoy it much, and thus don't do things which I otherwise would tackle. I'm aware that there are people who say they're currently happy with XEmacs Lisp, but I suspect that there are others who feel as I do, and would produce more and better code if the language substrate were different. I also conjecture that more developers would hack on XEmacs if its extension language weren't so arcane. This kind of thing would indeed affect users. I don't think it'll be necessary to halt all (or even most or a lot of) development in order to prepare and finally do the swap. I, for one, am not very interested in hacking on most of the issues you mention (not because I don't consider them important---for purely personal reasons), but have spent, am spending, and will spend considerable time and effort on the design and implementation issues involved in a swap. None of it has currently been fed into the XEmacs development process; I'll wait until I have something immediately usable. -- Cheers =8-} Chipsy Friede, Völkerverständigung und überhaupt blabla

1 participants
0 comments

rfhookfun 21 years, 7 months

Andy Piper

pre4 (?) very quickly becomes unuseable with the error: Symbol's value as variable is void: rfhookfun. anyone else see this? andy --------------------------------------------------------------------------- " .sigs are like your face - rarely seen by you and uglier than you think" Dr Andy Piper, Technical Architect, Parallax Solutions Ltd mail: andyp(a)parallax.co.uk web: www.parallax.co.uk/~andyp

2 participants
1 comments

Re: This will not do 21 years, 7 months

Oliver Graf

Andy Piper <andyp(a)parallax.co.uk> writes: > t 12:56 PM 6/30/98 +0200, Oliver Graf wrote: > >Andy Piper <andyp(a)parallax.co.uk> writes: > >The first toolbar that is created has a white background. All tollbars after > >this one are correctly displayed using gray80. > > I don't think this is the same problem. You should try applying my x-faces > patch and removing the settings to toolbar and gui-element faces. I've removed the set-face and the custom-face entries for toolbar and gui-default. You're patch is also applied (the one which adds something with gui-default into x-faces.el). This is the result for the first toolbar (same as with the stuff set): And all toolbars thereafter look like this: With the customs set the second toolbar looks like: and with (set-face-background 'toolbar "gray80") the first toolbar looks like: Perhaps my config files are also interesting: And perhaps I should also mention that I use a XEmacs with neXtaw libraries (through the bug also appears if I LD_PRELOAD libXaw or libXaw3d). Regards, Oliver.

2 participants
1 comments

Re: To ChangeLog or not to ChangeLog, that is the question 21 years, 7 months

Hrvoje Niksic

Didier Verna <verna(a)inf.enst.fr> writes: > SL Baur <steve(a)xemacs.org> writes: > > > [1] > > [2] > > [3] > > [4] > > [5] > > [6] > > Steve, you are the author of Footnote aren't you ? ;-) Ah, this > reminds me of something: if you compose an article, save it with > footnotes and then D(raft) e(dit) it, Footnote will not recognize > that there are already footnotes in the article, and will start > again from [1]. This is a general problem with drafts -- they save no information other than buffer text. In normal cases, this is enough, but it is insufficient for the more advanced Emacs features, where some data is stored in extents/text properties. The same problem will likely pop up when Lars introduces MIME composing to message. -- Hrvoje Niksic <hniksic(a)srce.hr> | Student at FER Zagreb, Croatia --------------------------------+-------------------------------- Personifiers Unite! You have nothing to lose but Mr. Dignity!

1 participants
0 comments

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

2000

1999

1998

XEmacs-Beta June 1998