February 1999 - XEmacs-Beta - XEmacs Mailing List Archives

SL Baur

Martin Buchholz <martin(a)xemacs.org> writes in xemacs-beta(a)xemacs.org: ... > They used to live in the same directory, and the old code worked. I > veto changing PATH, since this is a user-controlled variable that we > should avoid changing if at all possible. Please find some other way > to solve this problem, especially given that the directory > reorganization initiative has broken this. O.K. I'm pulling mmencode out and we'll require metamail to be installed separately.

1 participants
0 comments

Re: [21.0.63] Bad interaction b/w customize and .Xdefaults 25 years, 2 months

Paul Stodghill

> Paul Stodghill <stodghil(a)cs.cornell.edu> writes: > > > > > Would something like the following make sense? > > That is more like the old 'save-initial-default-font' solution. Try > this one instead. This makes x-init-face-from-resources actually > work like I described. i.e. if there have been no previous > customizations, then apply the resources. As a bonus this also fixes > the "background color reverts to grey when using font-menu problems" > by slightly changing the way custom interacts with resources (custom > now only overrides those resources you actually set). > > [patch deleted] With your patch, x-init-global faces doesn't correctly detect that 'default has been initialized from the X resources because these values are registered under the 'x tag, not the 'default tag. Here is a patch which checks both 'x and 'default. It also caused the font name specified by the X resources to be registered using the 'x tag. I'm sure that my patch breaks something else, but it appears to work in situation better than yours. Wanna do another iteration of patches? :-) smithers% diff -u xemacs-21.0.63/lisp/x-faces.el.saved xemacs-21.0.63/lisp/x-faces.el --- xemacs-21.0.63/lisp/x-faces.el.saved Wed Feb 17 16:36:58 1999 +++ xemacs-21.0.63/lisp/x-faces.el Wed Feb 17 16:34:58 1999 ＠＠ -506,7 +506,7 ＠＠ ;; globally. This means we should override global ;; defaults for all X device classes. (remove-specifier (face-font face) locale x-tag-set nil)) - (set-face-font face fn locale nil append)) + (set-face-font face fn locale 'x append)) ;; Kludge-o-rooni. Set the foreground and background resources for ;; X devices only -- otherwise things tend to get all messed up ;; if you start up an X frame and then later create a TTY frame. ＠＠ -600,14 +600,17 ＠＠ ;;; specified. ;;; (defun x-init-global-faces () - (or (face-font 'default 'global) + (or (face-font 'default 'global '(default)) + (face-font 'default 'global '(x)) (set-face-font 'default - "-*-courier-medium-r-*-*-*-120-*-*-*-*-iso8859-*") - 'global) - (or (face-foreground 'default 'global) - (set-face-foreground 'default "black" 'global 'x)) - (or (face-background 'default 'global) - (set-face-background 'default "gray80" 'global 'x))) + "-*-courier-medium-r-*-*-*-120-*-*-*-*-iso8859-*" + 'global '(x default))) + (or (face-foreground 'default 'global '(default)) + (face-foreground 'default 'global '(x)) + (set-face-foreground 'default "black" 'global '(x default))) + (or (face-background 'default 'global '(default)) + (face-background 'default 'global '(x)) + (set-face-background 'default "gray80" 'global '(x default)))) ;;; x-init-device-faces is responsible for initializing default ;;; values for faces on a newly created device. smithers%

1 participants
0 comments

Re: [21.0b63] make-face-bold is broken under CYGWIN+X... 25 years, 2 months

Jan Vroonhof

Paul Stodghill <stodghil(a)cs.cornell.edu> writes: > o First, x-make-font-bold is called and correctly derives the bold version of > the default font. The face is then changed ('global) to this font. > o Second, mswindows-make-font-bold is called and derives a Windows font name > of the existing font name. The face is then changed ('global) to the Windows > font! > > The final effect is that the font-name is set to a Windows font name for > display under X. > > If someone could suggest a way to fix this, I'll submit the patches.... Add the specifier for the font name using a tag set. i.e. the x font name gets added with an 'x tag set and the windows font name with an 'mswindows tag set. This should work giving the following excerpt from the info file * The inst-pairs contained in the specification that was found are considered in their order in the inst-list, looking for one whose tag set matches the device that is derived from the window domain. (The tag set is an unordered list of zero or more tag symbols. For all tags that have predicates associated with them, the predicate must match the device.) Jan

1 participants
0 comments

Re: [21.0.63] Bad interaction b/w customize and .Xdefaults 25 years, 2 months

Jan Vroonhof

Paul Stodghill <stodghil(a)cs.cornell.edu> writes: > > Would something like the following make sense? That is more like the old 'save-initial-default-font' solution. Try this one instead. This makes x-init-face-from-resources actually work like I described. i.e. if there have been no previous customizations, then apply the resources. As a bonus this also fixes the "background color reverts to grey when using font-menu problems" by slightly changing the way custom interacts with resources (custom now only overrides those resources you actually set). bolzano:/scratch/vroonhof/cvs/xemacs-20> cvs diff -u lisp/x-faces.el Index: lisp/x-faces.el =================================================================== RCS file: /usr/CVSroot/XEmacs/xemacs-20/lisp/x-faces.el,v retrieving revision 1.12 diff -u -u -r1.12 x-faces.el --- x-faces.el 1998/07/10 02:49:02 1.12 +++ x-faces.el 1999/02/18 02:09:12 ＠＠ -604,10 +604,10 ＠＠ (set-face-font 'default "-*-courier-medium-r-*-*-*-120-*-*-*-*-iso8859-*") 'global) - (or (face-foreground 'default 'global) - (set-face-foreground 'default "black" 'global 'x)) + (or (face-foreground 'default 'global '(default)) + (set-face-foreground 'default "black" 'global '(x default))) (or (face-background 'default 'global) - (set-face-background 'default "gray80" 'global 'x))) + (set-face-background 'default "gray80" 'global '(x default)))) ;;; x-init-device-faces is responsible for initializing default ;;; values for faces on a newly created device. bolzano:/scratch/vroonhof/cvs/xemacs-20>

1 participants
0 comments

[21.0b63] make-face-bold is broken under CYGWIN+X... 25 years, 2 months

Paul Stodghill

... and I don't know how to fix it. In faces.el around 975 or so, there is the following code, ;; handle X specific entries (when (featurep 'x) (frob-face-property face 'font 'x-make-font-bold locale)) (when (featurep 'mswindows) (frob-face-property face 'font 'mswindows-make-font-bold locale)) When evaluating, (copy-face 'default 'bold) (make-face-bold 'bold 'global) under CYGWIN+X, the following appears to happen, o First, x-make-font-bold is called and correctly derives the bold version of the default font. The face is then changed ('global) to this font. o Second, mswindows-make-font-bold is called and derives a Windows font name of the existing font name. The face is then changed ('global) to the Windows font! The final effect is that the font-name is set to a Windows font name for display under X. If someone could suggest a way to fix this, I'll submit the patches....

1 participants
0 comments

Re: [21.0.63] Bad interaction b/w customize and .Xdefaults 25 years, 2 months

Paul Stodghill

> I am confused. My fault. I've moved on to a different bug in mid-conversation. I'll try to stay focused. :-) > I thought the original problem was that face-spec-set > called face-display-set which modified the default face although the > display spec was ((mswindows ...)) and thus init-face-from-resources > dis nothing? face-display-set uses face-spec-match-display which > compares the device type against the display spec and should thus > fail. You wrote that was not what happening... That's not what is happening, the call to x-init-global-faces isn't guarded by face-spec-match-display; it's happening anytime face-spec-set is called on 'default face, whether any changes are made to 'default or not! Would something like the following make sense? It seems to fix the problem for me... diff -u faces.el.orig faces.el --- faces.el.orig Wed Feb 17 10:10:10 1999 +++ faces.el Wed Feb 17 10:30:45 1999 ＠＠ -1207,17 +1207,15 ＠＠ (reset-face face frame) (face-display-set face spec frame) (init-face-from-resources face frame)) - (let ((frames (relevant-custom-frames))) - (reset-face face) - (if (and (eq 'default face) (featurep 'x)) - (x-init-global-faces)) - (face-display-set face spec) + (let ((frames (relevant-custom-frames)) + (reinitialized-p (list nil))) + (face-display-set face spec reinitialized-p) (while frames - (face-display-set face spec (car frames)) + (face-display-set face spec reinitialized-p (car frames)) (pop frames)) (init-face-from-resources face)))) -(defun face-display-set (face spec &optional frame) +(defun face-display-set (face spec reinitialized-p &optional frame) "Set FACE to the attributes to the first matching entry in SPEC. Iff optional FRAME is non-nil, set it for that frame only. See `defface' for information about SPEC." ＠＠ -1226,6 +1224,11 ＠＠ (atts (cadar spec))) (pop spec) (when (face-spec-set-match-display display frame) + (unless (car reinitialized-p) + (reset-face face) + (if (and (eq 'default face) (featurep 'x)) + (x-init-global-faces)) + (setcar reinitialized-p t)) ;; Avoid creating frame local duplicates of the global face. (unless (and frame (eq display (get face 'custom-face-display))) (apply 'face-custom-attributes-set face frame atts)) diff -u cus-face.el.orig cus-face.el --- cus-face.el.orig Wed Feb 17 10:29:27 1999 +++ cus-face.el Wed Feb 17 10:30:22 1999 ＠＠ -36,15 +36,16 ＠＠ ;; If the user has already created the face, respect that. (let ((value (or (get face 'saved-face) spec)) (frames (relevant-custom-frames)) + (reinitialized-p (list nil)) frame) ;; Create global face. (make-empty-face face) - (face-display-set face value) + (face-display-set face value reinitialized-p) ;; Create frame local faces (while frames (setq frame (car frames) frames (cdr frames)) - (face-display-set face value frame)) + (face-display-set face value reinitialized-p frame)) (init-face-from-resources face))) (when (and doc (null (face-doc-string face))) (set-face-doc-string face doc)) > Anyway you seem to have enough info and a test case you can probably > use edebug and find out exactly where this is going wrong. > > Jan

1 participants
0 comments

[new patch] image display problem on 24bpp 25 years, 2 months

Kazuo Oishi

This is new patch to solve image display problem on some X server's 24bpp mode. My old patches (<87r9rt9srg.fsf(a)agrcs.agr.yamaguchi-u.ac.jp>, <87d83cih4j.fsf(a)agrcs.agr.yamaguchi-u.ac.jp>) were "dog-slow", please forget it. 1999-02-17 Kazuo Oishi <oishi(a)ae.agr.yamaguchi-u.ac.jp> * glyphs-x.c (cononvert_EImage_to_XImage): correct byte counting. --- src/glyphs-x.c.orig Sun Feb 14 22:53:17 1999 +++ src/glyphs-x.c Wed Feb 17 20:30:23 1999 ＠＠ -124,7 +124,7 ＠＠ Colormap cmap; Visual *vis; XImage *outimg; - int depth, bitmap_pad, byte_cnt, i, j; + int depth, bitmap_pad, bits_per_pixel, byte_cnt, i, j; int rd,gr,bl,q; unsigned char *data, *ip, *dp; quant_table *qtable = 0; ＠＠ -149,12 +149,14 ＠＠ bitmap_pad = ((depth > 16) ? 32 : (depth > 8) ? 16 : 8); - byte_cnt = bitmap_pad >> 3; outimg = XCreateImage (dpy, vis, depth, ZPixmap, 0, 0, width, height, bitmap_pad, 0); if (!outimg) return NULL; + + bits_per_pixel = outimg->bits_per_pixel; + byte_cnt = bits_per_pixel >> 3; data = (unsigned char *) xmalloc (outimg->bytes_per_line * height); if (!data) -- 大石一雄 (OISHI Kazuo)

1 participants
0 comments

Does gnuclient work under CYGWIN+X? 25 years, 2 months

Paul Stodghill

This bug report will be sent to the XEmacs Development Team, not to your local site managers!! Please write in English, because the XEmacs maintainers do not have translators to read other languages for them. In XEmacs 21.0 "Pyrenean63" [Lucid] (i686-pc-cygwin32) of Mon Feb 15 1999 on smithers configured using `configure --error-checking=none' Please describe exactly what actions triggered the bug and the precise symptoms of the bug: smithers% uname -a CYGWIN_NT-4.0 SMITHERS 20.1 (0.3/1/1) 1998-12-3 20:39:18 i686 unknown smithers% echo $DISPLAY 127.0.0.1:0.0 smithers% xemacs -vanilla -eval '(gnuserv-start)' & [1] 1034 smithers% gnuclient gnuclient: Connection reset by peer gnuclient: unable to read the reply from the server smithers% gnuclient -nw gnuclient: Connection reset by peer gnuclient: unable to read the reply from the server smithers% Recent keystrokes: misc-user Recent messages (most recent first): Parsing /home/stodghil/.mailrc... Loading mail-abbrevs...done Loading mail-abbrevs... Loading emacsbug...done Loading emacsbug... Loading gnuserv...done Loading gnuserv...

3 participants
5 comments

Re: Does gnuclient work under CYGWIN+X? 25 years, 2 months

Jan Vroonhof

"Dr. Volker Zell" <vzell(a)de.oracle.com> writes: > Finally, it works .... :-) > Where did you get this information from about GNU_SECURE ????? >From the gnuserv/gnuclient manpage I guess.. You should however really use magic-cookie based authentication. Jan

1 participants
0 comments

Re: [21.0.63] Bad interaction b/w customize and .Xdefaults 25 years, 2 months

Jan Vroonhof

Paul Stodghill <stodghil(a)cs.cornell.edu> writes: > > So the question is now: Why is device-type returning 'mswindows for X > > frames.. > > It isn't. > > (device-type (frame-device)) ==> x > (featurep 'mswindows) ==> t > > The code is using the later test. If the code was testing that > (eq 'mswindows (device-type locale)) or some such, then it might work... I am confused. I thought the original problem was that face-spec-set called face-display-set which modified the default face although the display spec was ((mswindows ...)) and thus init-face-from-resources dis nothing? face-display-set uses face-spec-match-display which compares the device type against the display spec and should thus fail. You wrote that was not what happening... Anyway you seem to have enough info and a test case you can probably use edebug and find out exactly where this is going wrong. Jan

1 participants
0 comments

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

2000

1999

1998

XEmacs-Beta February 1999