"J. Kean Johnston" <jkj(a)sco.com> writes:
Attached is a small tar file with a patch and a new dll.c, a header
file and a sample DLL module. This is very raw right now, so you
will need to do a bit of work to get this working.
Very, very interesting. Your work is much more mature than anything
else done so far on this topic, and I am very happy to see it written.
I'd like to offer a few important comments and questions:
* Why is the syntax of declaring dynamic SUBR's different from the
rest of XEmacs? I'm not sure this is acceptable, really.
* Why are you using specialized error functions instead of the Emacs
ones? As a reminder, Emacs has error(), signal_simple_error(), and
a bunch of others. See eval.c for details.
Also, your error messages are at odds with the usual Emacs error
conventions. Please look them up, or mail me privately if you need
more details on what exactly I mean.
* I believe your code is not Mule-clean, and as such not eligible for
application to XEmacs. Hint: casting XSTRING_DATA (foo) to `char *'
is something that should *NOT* be done. Again, ask if you need more
explanations.
* dll-list-modules should really return a list, not a vector. Vectors
should be used only for data structures that require random access,
as opposed to front-to-end searches.
--
Hrvoje Niksic <hniksic(a)srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
"A Real Programmer's code can awe with its fiendish brilliance, even
as its crockishness appalls."