Re: patch for shadowfile.el (was: error on exit - unable to exit)

The following message is a courtesy copy of an article that has been posted to comp.emacs.xemacs as well. Please follow up to the mailing list <xemacs-beta(a)xemacs.org&gt;. Reply-To set. Peter, thanks for your contribution. APA> Yes, this, right out of shadowfile.el, is a no-no: APA> (if noninteractive APA> (add-hook 'after-init-hook 'shadow-initialize) APA> (shadow-initialize)) And the author was so proud of it, too. :-) In general patches to remove code that initializes on load will be accepted. Also make sure that there is a Customize mechanism to enable the package, or at least a PACKAGE-initialize function that is autoloaded so that users need only put (PACKAGE-initialize) in their init files. APA> The unconditional global setting of APA> (setq find-file-visit-truename t) APA> is a bad thing too. APA> Don't know whether this could be made buffer-local. It probably could be but that results in contorted code (Christoph Wedler recently posted a patch to make buffer-local values of completion-base-size work correctly), probably no less contorted than simply making sure to bind the variable in the right places. APA> If you're very sure your patch is correct, you may also send APA> it to xemacs-patches, but check out He already did, look at the CC in his post. :-) Note that the proposed policy (ie, the patch I've submitted for etc/BETA) is not that you need to verify that your patch is correct, but that you intend it to be applied to the tree as-is. Of course we encourage people who are good at verification to save us the trouble. And from your point of view, the higher quality the patch, and the more rigorous your explanation of why it is needed and correct, the sooner it will be committed to our repository. If you aren't sure, CC xemacs-patches anyway, but note your concerns in the text of the message. The point is to make sure that potentially valuable patches get into the review queue. "I don't understand this but it works for me" is good enough; just expect a fair amount of delay as we do the verification work. If you really don't think the patch is ready for prime time, but want it to be discussed and probably revised, send to xemacs-beta instead. -- Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Don't ask how you can "do" free software business; ask what your business can "do for" free software.