[21.5] cflags broken, proposed fix

21.5 Ilya> Version: 21.5 after revision 1.237 of `configure.in'. Ilya> Contrary to doc, `--cflags-optimization=' do not work. Its Ilya> value is not added to `＠XE_CFLAGS＠' substitution in Ilya> `config.status'. Thank you for the report. I don't have total confidence in the following patch, so am not committing yet. I would appreciate your test. Note that this patch is to configure.ac, not configure.in, and you will need autoconf 2.59 to create configure. Also, the name of the flag has changed to --with-cflags-optimization, to conform with autoconf. Index: ChangeLog =================================================================== RCS file: /pack/xemacscvs/XEmacs/xemacs/ChangeLog,v retrieving revision 1.444 diff -u -U0 -r1.444 ChangeLog --- ChangeLog 14 Mar 2005 12:22:16 -0000 1.444 +++ ChangeLog 15 Mar 2005 06:45:32 -0000 ＠＠ -0,0 +1,6 ＠＠ +2005-03-15 Stephen J. Turnbull <stephen(a)xemacs.org&gt; + + * configure.ac (--with-cflags-optimization): + (--with-cflags-debugging): + If the user specifies them, use them, and don't make her beg. + Index: configure.ac =================================================================== RCS file: /pack/xemacscvs/XEmacs/xemacs/configure.ac,v retrieving revision 1.3 diff -u -r1.3 configure.ac --- configure.ac 14 Mar 2005 12:22:22 -0000 1.3 +++ configure.ac 15 Mar 2005 06:45:39 -0000 ＠＠ -1706,12 +1706,12 ＠＠ else cflags_warning_specified=no; fi -if test "${cflags_optimization-unset}" != unset +if test "${with_cflags_optimization-unset}" != unset then cflags_optimization_specified=yes; else cflags_optimization_specified=no; fi -if test "${cflags_debugging-unset}" != unset +if test "${with_cflags_debugging-unset}" != unset then cflags_debugging_specified=yes; else cflags_debugging_specified=no; fi ＠＠ -2048,11 +2048,11 ＠＠ dnl Calculate optimization flags. These will be off by default in beta dnl versions and on in release versions. -if test -z "$with_optimization" ; then - if test -n "$emacs_is_beta" ; then - with_optimization=no - else +if test -z "$with_optimization"; then + if test -z "$emacs_is_beta" -o "$cflags_optimization_specified" = "yes"; then with_optimization=yes + else + with_optimization=no fi fi -- Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Ask not how you can "do" free software business; ask what your business can "do for" free software.