[PATCH] mswindows eshell pccomplete and the special backslash

On Tue, Feb 19, 2008 at 05:42:07PM -0800, FKtPp wrote: > Thanks Vin, This works perfect, and I feel much more comfortable than > using the ugly ?\ as the direcotry-sep-char. > > Why don't us make it default? Are there any XEmacs user dislike using > ?/ as the direcotry-sep-char? seems I've figure out the reason by myself... beacuse it do not work well -_- --8<---------------cut here---------------start------------->8--- Date: Fri, 4 Jul 2008 00:14:12 -0700 (PDT) From: FKtPp <m_pupil(a)yahoo.com.cn&gt; Subject: [Bug: 21.5-b28] command-syntax-error (info-mode #'call-process-internal) vs. eshell (windows platform) path completation To: xemacs-beta(a)xemacs.org ================================================================ Dear Bug Team! It is a bit complex to reproduce this: 1) you have to use a native widnows build. 2) (setq directory-sep-char ?/) in your init.el 3) make gzip avaiable avaiable in your path 4) have gziped info manual in your info dir (I have cygwin ones). 5) try view a info node inside the gziped manual. you will got an error of no such info node error, further edebug show that it was because the #'call-process-internal got an "the syntax of the command is not correct" error[1], and result an empty *info* buffer. remove/comment-out the (setq directory-sep-char ?/) in init.el will resolve this error. But it will cause the eshell path completation complete an extra ?\ character[2]. when you type enter after that ?\ character, you'll got an directory not found error. --8<---------------cut here---------------end--------------->8--- I've composed a patch against esh-arg.el to fix the pcomplete issue. --- xemacs-packages/lisp/eshell/esh-arg.el~ Fri May 23 15:46:12 2008 +++ xemacs-packages/lisp/eshell/esh-arg.el Tue Jul 08 13:27:34 2008 ＠＠ -280,7 +280,11 ＠＠ "Intelligently backslash the character occuring in STRING at INDEX. If the character is itself a backslash, it needs no escaping." (let ((char (aref string index))) - (if (eq char ?\\) + (if (and (eq char ?\\) + (not (and (featurep 'mswindows) + (eq directory-sep-char ?\\) + (eq (1- (string-width string)) + index)))) (char-to-string char) (if (memq char eshell-special-chars-outside-quoting) (string ?\\ char))))) _______________________________________________ XEmacs-Beta mailing list XEmacs-Beta(a)xemacs.org http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta