Re: edit->bookmarks menu: bookmarks-file not automagically loaded
Keywords: bookmark,bookmark-maybe-load-default-file,patch,emacs,edit-,bookmarks-
References: <web-2030101(a)tuebingen.mpg.de>
From: Steve Youngs <youngs(a)xemacs.org>
X-Attribution: SY
Organization: The XEmacs Development Team
X-URL: <http://www.xemacs.org/>
X-Face:
%＠A&y\ef)A6pi|q43;M>uyhO)~NP*fpdo0XrUuutf0|nku\O5JV(7EG%odc'n6}G＠tYRl+B
#[n,%B`.sHZ5>3MZvrm%,rWE7)c}ZXjH\>=p(a)AL\y\gyu|.lJ8B`F++86
Date: Mon, 04 Mar 2002 12:11:55 +1000
In-Reply-To: <web-2030101(a)tuebingen.mpg.de> ("Volker Franz"'s message
of
"Sun, 03 Mar 2002 19:49:04 +0100")
Message-ID: <microsoft-free.x4bse5dqtw.fsf(a)eicq.dnsalias.org>
Lines: 56
User-Agent: Gnus/5.090006 (Oort Gnus v0.06) XEmacs/21.5 (bamboo,
i686-pc-linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
|--==> "VF" == Volker Franz <volker.franz(a)tuebingen.mpg.de> writes:
VF> The problem: The menu-entry: Edit->Bookmarks->Jump-to-Bookmark does
VF> not automagically load the default bookmark file (at least in my
VF> 21.1.14). To see this do:
VF> - create a bookmarks-file: ~/.emacs.bmk
VF> - start xemacs: $xemacs -q
VF> => Edit->Bookmarks->Jump-to-Bookmark is not active
VF> (only after doing: Edit->Bookmarks->Load-a-bookmark-file, it will
VF> be activated)
VF> I consider this a bug, since the help text of bookmark-load says:
VF> Your own personal bookmark file, `~/.emacs.bmk', is maintained
VF> automatically by Emacs; you shouldn't need to load it explicitly.
Agreed.
[Patch elided]
VF> However, the patch assumes that bookmarks.el is installed. Therefore,
VF> I think the
VF> (require 'bookmark)
VF> statement should be replaces by something more sophisticated. I see
VF> two possibilities:
VF> (a)
VF> (if (featurep 'bookmark)
VF> (progn
VF> (require 'bookmark)
VF> (bookmark-maybe-load-default-file)))
This won't work because it would only be true _after_ loading or
requiring bookmark.
VF> (b)
VF> (if (fboundp 'bookmark-maybe-load-default-file)
VF> (bookmark-maybe-load-default-file))
VF> And giving the function bookmark-maybe-load-default-file in
VF> bookmark.el an autoload cookie...
This is the way to go. I look forward to seeing your revised patch on
xemacs-patches.:-)
--
|---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---|
| XEmacs - It's not just an editor. |
| It's a way of life. |
|------------------------------------<youngs(a)xemacs.org>---|