[Q] RE: [PATCH 21.4] Make syntax tables a compile time option.

QUERY Andy> Ok, attached is the patch I actually committed. These two hunks at least are regressions. `BUF_PT (buf)' does _not_ correspond to `pos_byte'. I don't yet know which is correct, but Ben specifically made the change from the !SYNTAX_TEXT_PROPERTIES form to the SYNTAX_TEXT_PROPERTIES forms---so I would bet on the form you just compiled _out_ of windows-21-4-9-2 .... Index: src/search.c =================================================================== RCS file: /pack/xemacscvs/XEmacs/xemacs/src/search.c,v retrieving revision 1.17.2.1.4.2 diff -u -r1.17.2.1.4.2 search.c --- src/search.c 2002/08/24 04:47:52 1.17.2.1.4.2 +++ src/search.c 2002/09/02 20:34:47 ＠＠ -896,15 +913,23 ＠＠ if (pos < limit) while (fastmap[(unsigned char) syntax_code_spec +#ifndef SYNTAX_TEXT_PROPERTIES + [(int) SYNTAX (syntax_table, + BUF_FETCH_CHAR + (buf, BUF_PT (buf)))]]) +#else /* SYNTAX_TEXT_PROPERTIES */ [(int) SYNTAX_FROM_CACHE (syntax_table, BI_BUF_FETCH_CHAR (buf, pos_byte))]]) +#endif /* SYNTAX_TEXT_PROPERTIES */ { pos++; INC_BYTIND (buf, pos_byte); if (pos >= limit) break; +#ifdef SYNTAX_TEXT_PROPERTIES UPDATE_SYNTAX_CACHE_FORWARD (pos); +#endif /* SYNTAX_TEXT_PROPERTIES */ } } else ＠＠ -914,12 +939,20 ＠＠ Bufpos savepos = pos_byte; pos--; DEC_BYTIND (buf, pos_byte); +#ifdef SYNTAX_TEXT_PROPERTIES UPDATE_SYNTAX_CACHE_BACKWARD (pos); +#endif /* SYNTAX_TEXT_PROPERTIES */ if (!fastmap[(unsigned char) syntax_code_spec +#ifndef SYNTAX_TEXT_PROPERTIES + [(int) SYNTAX (syntax_table, + BUF_FETCH_CHAR + (buf, BUF_PT (buf)))]]) +#else /* SYNTAX_TEXT_PROPERTIES */ [(int) SYNTAX_FROM_CACHE (syntax_table, BI_BUF_FETCH_CHAR (buf, pos_byte))]]) +#endif /* SYNTAX_TEXT_PROPERTIES */ { pos++; pos_byte = savepos; -- Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN My nostalgia for Icon makes me forget about any of the bad things. I don't have much nostalgia for Perl, so its faults I remember. Scott Gilbert c.l.py