Re: [PATCH] Some toolbar fixes.
At 12:43 AM 4/23/98 +0400, Kirill M. Katsnelson wrote:
Andy: the four hashtables design has a serious flaw. When
you allocate an id, it is guaranteed to be unique in one
hastable. Although, it must to be unique accross all four
hashatbles, becuase command ids must be different in all
four toolbars.
I suggest using single hashtable. The only change will
be that you would use Fremhash instead of Fclrhash when
deleting the toolbar, and use TB_GETBUTTON to get an id
to pass Fremhash. Other code is simplified though.
After our discussions yesterday I realise this, and you are right.
Also, when computing toolbar checksum, it is necessary to
hash also toolbar glyphs. Otherwise, when toolbar images
change, checksum does not. This is why toolbar ignores
changing "captioned" toggle from the menu.
Ok
andy