Re: lisp/simple.el `rfc822-goto-eoh'
On Tue, 21 Aug 2001, Stephen J. Turnbull wrote:
Diverted to xemacs-beta.
I'm considering the following patch for 21.4.5. Why is this the right
thing to do, rather than redefining the EOH or header-separator
regexp in sendmail.el?
I realize I don't have strong arguments for this. Anyway, pro:
1) It replaces 4 lines of code with 1 in a couple of places in a couple
of files. (None which are part of the core though.)
2) It makes it easier to keep sendmail.el (and other files that use
rfc822-goto-eoh) in sync with Emacs. (sendmail.el isn't part of the core
either..)
and arguments against your counter-proposals:
3) header-separator isn't a regexp, e.g. it's used in some places as
`(insert mail-header-separator)'. Ok, one could define a
`mail-header-separator-regexp', but rather than doing that maybe it's
better to simply do what the other emacs does.
4) eoh isn't used only in sendmail.el. Almost only there, but there are
some other places as well.
OTOH having it defined only in rfc822.el (which it is right now) is OK
with my needs in mail-lib.
>>>>> "Simon" == Simon Josefsson <jas(a)extundo.com>
writes:
Simon> During sendmail.el syncing I found that `rfc822-goto-eoh'
Simon> was missing from XEmacs simple.el.
Simon> So I did:
Simon> 1) committed a compatibility definition to
Simon> mail-lib/rfc822.el for XEmacsen without `rfc822-goto-eoh'.
Simon> 2) wrote the following patch.
Simon> 2001-08-01 Simon Josefsson <jas(a)extundo.com>
Simon> * simple.el (rfc822-goto-eoh): New function (from Emacs).
Simon> (sendmail-user-agent-compose): Use it.