Re: [21.0.63] Bad interaction b/w customize and .Xdefaults
Paul Stodghill <stodghil(a)cs.cornell.edu> writes:
Here is a patch which checks both 'x and 'default.
It should not be necessary. Tag-set nil should match all types by
default. Note however that I was a bit overzealous and added one
'default to much in the check for face foreground. Could you try the
new version at the end.
It also caused the font
name specified by the X resources to be registered using the 'x
tag.
That is probably a good idea.
;; globally. This means we should override global
;; defaults for all X device classes.
(remove-specifier (face-font face) locale x-tag-set nil))
- (set-face-font face fn locale nil append))
+ (set-face-font face fn locale 'x append))
I think you should send this in as a separate patch later. It should
be considered seperately. See the next comment.
;; Kludge-o-rooni. Set the foreground and background resources
;; for X devices only -- otherwise things tend to get all
;; messed up if you start up an X frame and then later create a
;; TTY frame.
(defun x-init-global-faces ()
- (or (face-font 'default 'global)
+ (or (face-font 'default 'global '(default))
+ (face-font 'default 'global '(x))
Like I said. If this is necessary then this a bug in face-font.
Could you try this new version? It works here. I tested it for the
foreground
No Settings whatsoever -> black
-vanilla + resource = green -> green
custom that only sets background + resource = green -> green
custom = blue + resource = green -> blue
bolzano:/scratch/vroonhof/cvs/xemacs-20> cvs diff -u lisp/x-faces.el
Index: lisp/x-faces.el
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs-20/lisp/x-faces.el,v
retrieving revision 1.12
diff -u -u -r1.12 x-faces.el
--- x-faces.el 1998/07/10 02:49:02 1.12
+++ x-faces.el 1999/02/18 17:25:02
＠＠ -605,9 +605,9 ＠＠
"-*-courier-medium-r-*-*-*-120-*-*-*-*-iso8859-*")
'global)
(or (face-foreground 'default 'global)
- (set-face-foreground 'default "black" 'global 'x))
+ (set-face-foreground 'default "black" 'global '(x default)))
(or (face-background 'default 'global)
- (set-face-background 'default "gray80" 'global 'x)))
+ (set-face-background 'default "gray80" 'global '(x
default))))
;;; x-init-device-faces is responsible for initializing default
;;; values for faces on a newly created device.
[3] + Done src/xemacs -vanilla
I have to do other stuff now,
CU
Jan