>>>> Adam Sjøgren <asjo(a)koldfront.dk> writes:
Adam> I see that I have been totally unable to convey my message to
Adam> you at all. I am NOT asking you to commit the patch, nor to try
Adam> it on an OpenBSD system. I am just, and only, asking: DOES IT
Adam> LOOK SANE?
As a set of preprocessor directives it looks quite OK but I assumed
that it was not that level of inspection you wanted? I though the
question you wanted answered was does this do the right thing?
As Stephen points out I haven't got the knowledge to answer that.
But you have tested it to some extent at least I think(?), we have
build slaves for it, why not apply and let the tests do their thing?
Adam> That is the way contribution by newcomers works most places, I
Adam> have found.
Yes, and I think it does so here too but not always. The number of
active developers does have an impact on the responsiveness.
The OS environments you have set up build slaves for is quite likely
such an area where there might not be that much response. In those
cases I suggest we try to find some way to handle it. Applying the
patches is my suggestions.
In the future I'll try to be more verbose when it comes to patches
since silence is a bad thing for a contributor. Please be patient and
stubborn and keep those patches coming.
XEmacs-Beta mailing list