Re: [PATCH] Portable dumper fixes for NT
24 years, 8 months
Daniel Pittman
Daniel Pittman
On Sat, 15 Jan 2000, Kirill Katsnelson <kkm(a)dtmx.com> wrote:
> Some time ago, Hrvoje Niksic wrote...
>>"Kirill 'Big K' Katsnelson" <kkm(a)dtmx.com> writes:
[...]
> A question: does mmap gives any performance benefits over read when
> loading the dump file? NT is primarily a single-user system, so the
> case of 2+ xemacsen should be rare, and the shared memory benefit
> would not pay off.
Vaguely. Win2K ships with terminal services as a default or, if not
that, a very easy addition. I also know a number of large companies that
are looking at using that sort of thing internally (including ours).
WinNT has finally completed the transition to implement Unix. Multiple
user WinNT machines and a network-distributed GUI layer are there...
So, on that basis, I think that the mapping advantage should not be
discounted if the cost of it is low.
> I will fake mmap if it gives performance benefits though, even a
> little. Startup seems to be slower a bit.
Win32 provides mmap natively, even if libc does not expose it. The
interface is low level but is detailed by Microsoft:
<URL:http://msdn.microsoft.com/library/psdk/winbase/filemap_0583.htm>
Daniel
--
The youth gets together his materials to build a bridge to the moon, or,
perchance, a palace or temple on the earth, and, at length, the middle-aged
man concludes to build a woodshed with them.
-- Henry David Thoreau
- 2 participants
- 1 comments
ld-linux.so.2 --inhibit-rpath doesn't work
24 years, 8 months
Martin Buchholz
Martin Buchholz
I can't get the --inhibit-rpath option to ld-linux.so.2 to work.
ObDocPatch:
Index: rtld.c
===================================================================
RCS file: /cvs/glibc/libc/elf/rtld.c,v
retrieving revision 1.154
diff -u -r1.154 rtld.c
--- rtld.c 1999/08/19 23:17:32 1.154
+++ rtld.c 2000/01/17 04:05:37
＠＠ -454,7 +454,7 ＠＠
\n\
--list list all dependencies and how they are resolved\n\
--verify verify that given object really is a dynamically linked\n\
- object we get handle\n\
+ object we can handle\n\
--library-path PATH use given PATH instead of content of the environment\n\
variable LD_LIBRARY_PATH\n\
--inhibit-rpath LIST ignore RUNPATH and RPATH information in object names\n\
shell transcript follows:
(martin＠lasker) ~/src/tt $ gcc29 -shared -o libX11.so.6 -Wl,--soname=libX11.so.6 main.c
(martin＠lasker) ~/src/tt $ cat main.c
#include <stdio.h>
int XOpenDisplay (char *s)
{
printf ("my own XOpenDisplay\n");
}
(martin＠lasker) ~/src $ cat lib.c
#include <stdio.h>
int main (int argc, char *argv[])
{
XOpenDisplay ("hello world\n");
return 0;
}
(martin＠lasker) ~/src $ gcc29 -Wl,-rpath=/home/martin/src/tt lib.c -L /home/martin/src/tt -lX11
(martin＠lasker) ~/src $ ./a.out
my own XOpenDisplay
(martin＠lasker) ~/src $ LD_PRELOAD=/usr/X11R6/lib/libX11.so.6 ./a.out
(martin＠lasker) ~/src $ $cdi/glibc-2.1.2/elf/ld-linux.so.2 --inhibit-rpath ./a.out ./a.out
my own XOpenDisplay
(martin＠lasker) ~/src $ LD_DEBUG=libs $cdi/glibc-2.1.2/elf/ld-linux.so.2 --inhibit-rpath ./a.out ./a.out
24393: find library=libX11.so.6; searching
24393: search path=/home/martin/src/tt/i686:/home/martin/src/tt (RPATH from file ./a.out)
24393: trying file=/home/martin/src/tt/i686/libX11.so.6
24393: trying file=/home/martin/src/tt/libX11.so.6
24393:
24393: find library=libc.so.6; searching
24393: search path=/home/martin/src/tt (RPATH from file ./a.out)
24393: trying file=/home/martin/src/tt/libc.so.6
24393: search cache=/etc/ld.so.cache
24393: trying file=/lib/libc.so.6
24393:
24393:
24393: calling init: /lib/libc.so.6
24393:
24393:
24393: calling init: /home/martin/src/tt/libX11.so.6
24393:
24393:
24393: initialize libc
24393:
24393:
24393: initialize program: ./a.out
24393:
24393:
24393: transferring control: ./a.out
24393:
my own XOpenDisplay
24393:
24393: calling fini: /home/martin/src/tt/libX11.so.6
24393:
24393:
24393: calling fini: /lib/libc.so.6
24393:
- 1 participants
- 0 comments
Re: Using -rpath on Linux
24 years, 8 months
Jan Vroonhof
Jan Vroonhof
[I am having an unproductive spell thesis wise. So I am unlurking for
a second.[1] ]
Martin Buchholz <martin(a)xemacs.org> writes:
> Here's the easy and obvious rpath patch as suggested by recent
> discussion on getting Xaw linking more reliable. Perhaps Hrvoje would
> like to test it?
I agree this might be the only way to fix this problem. I just want to
point out something that was unclear from your summary of the
problem. The main reason that we were not using -rpath on linux as
opposed to say Solaris, is that on Linux -rpath takes precedence
always. You cannot override with things like LD_LIBRARY_PATH [2]. On
Solaris -rpath is more of a "place to search in last resort thing."[3]
This is all IRIC but I think do.
The other solution would be to never link against plain libXaw.so but
require the use of one of the variants..:-)
Jan
P.S. If you say "rpath" close to the libtool maintainer, you risk
physical injury (at least that was the case a while ago)/
P.P.S. Did somebody file a RC bug against the debian xaw-wrappers
package?
Footnotes:
[1] To those who offered help in the job search department. I'll
contact you all soon.
[2] Which is exactly why it fixes the athena problem of course.
[3] So this fix doesn't work on Solaris.
- 3 participants
- 2 comments
Re: Using -rpath on Linux
24 years, 8 months
Hrvoje Niksic
Hrvoje Niksic
Jan Vroonhof <vroonhof(a)math.ethz.ch> writes:
> P.S. If you say "rpath" close to the libtool maintainer, you risk
> physical injury (at least that was the case a while ago)/
If you say "libtool" to someone who doesn't run Linux, you risk
physical injury. (I'm sure this is still the case.)
- 2 participants
- 1 comments
Re: [PATCH] Portable dumper fixes for NT
24 years, 8 months
Jan Vroonhof
Jan Vroonhof
Hrvoje Niksic <hniksic(a)iskon.hr> writes:
> I'm not sure how well our dumper fits with the mmap model. If I
> understand it correctly, XEmacs can't use the data directly from the
> file, it needs to relocate pointers and stuff.
Yes, but the idea is that most of the time it can be arranged so that
file gets mapped at exactly the right address and pointer relocations
aren't necessary.
Jan
- 1 participants
- 0 comments
Re: "Symbol X has different size in shared object" bug reappears
24 years, 8 months
Hrvoje Niksic
Hrvoje Niksic
Jan Vroonhof <vroonhof(a)math.ethz.ch> writes:
> Martin Buchholz <martin(a)xemacs.org> writes:
>
> > Well, the way it *should* work is that the RPATH baked into the
> > executable is searched first, and then, if not all libraries are
> > found, /etc/ld.so.conf is searched, and if not all libraries are
> > found, the hardcoded /usr/lib is searched.
>
> However as I said before that way you can no longer override the
> search using LD_LIBRARY_PATH
Is this a problem? If XEmacs worked right in the first place, I don't
see why I'd want to play games with LD_LIBRARY_PATH.
- 1 participants
- 0 comments
[PATCH] Minor msw widget glitches
24 years, 8 months
Kirill 'Big K' Katsnelson
Kirill 'Big K' Katsnelson
This patch fixes a problem: focus disappears after pressing Done
in a customize buffer, and does not reappear until a click on
a buffer (focus lost: it was on a "Done" button, destroyed).
The rest, I made usage of tab stops consistent. XEmacs currently
does not make use of this flag, but I felt I had to make it
consistent.
The flag WS_EX_CONTROLPARENT applied to parents, not children.
It affects the behavior of GetNextDlgTabItem. Suppose A,B,C are
children of W, and B1, B2 and B3 are children of B. If all of
the windows are tab stops (WS_TABSTOP), GetNextDlgTabItem
will traverse A,B,C if B does not have the WS_EX_CONTROLPARENT
flag, and A,B1,B2,B3,C if it does.
In mswindows_subwindow_instantiate, this flag is not necessary
as long as its child is STATIC.
Andy (I suppose you wrote the code, did you?), why there are
sandwiches of two windows to represent each widget? If there
is a rationale behind this which I overlook, then it has to be
documented - the code looks quite cryptic now... :)
It is customary in Windows to make all controls accessible equally
using mouse and keyboard. Now, should I click on a widget, there
is no way to move focus away from it using keyboard (neither to
sibling widget nor back to the buffer). Symmetrically there is
no way to activate a widget from a buffer using only keyboard.
I have no idea how to make it better (it's midnight here, and I
haven't been xemacsing for a long time), but this should be
discussed.
Big K
2000-01-12 Kirill 'Big K' Katsnelson <kkm(a)dtmx.com>
* glyphs-msw.c (mswindows_unmap_subwindow): Set focus back to the
frame upon hiding a subwindow.
(mswindows_button_instantiate): Changed the push button style to
BS_PUSHBUTTON.
(mswindows_button_instantiate): Removed button BS_NOTIFY
style.
(mswindows_button_instantiate): Removed redundant check for
a disabled gui item.
(mswindows_button_instantiate): Made use of WS_TABSTOP
consistent: "operable" controls (edit, button, tree, scroll) have
this style, "display-only" ones (static, progress gauge) do
not. This style is currently ignored by XEmacs though. Also,
removed the WS_EX_CONTROLPARENT style - it is not for children,
it is for their parents!
(mswindows_edit_field_instantiate): Ditto.
(mswindows_progress_gauge_instantiate): Ditto.
(mswindows_tree_view_instantiate): Ditto.
(mswindows_tab_control_instantiate): Ditto.
(mswindows_scrollbar_instantiate): Ditto.
(mswindows_combo_box_instantiate): Ditto.
(mswindows_widget_instantiate): Added the WS_EX_CONTROLPARENT
style to the "clip" window.
(mswindows_button_instantiate): Removed compilation warning by
equally typing terms of the ?: operator.
Index: glyphs-msw.c
===================================================================
RCS file: /var/cvsroot/xemacs/src/glyphs-msw.c,v
retrieving revision 1.1.1.1
diff --unified=2 -r1.1.1.1 glyphs-msw.c
--- src/glyphs-msw.c 2000/01/12 07:54:49 1.1.1.1
+++ src/glyphs-msw.c 2000/01/13 07:29:31
＠＠ -2098,4 +2098,5 ＠＠
SWP_HIDEWINDOW | SWP_NOMOVE | SWP_NOSIZE
| SWP_NOSENDCHANGING);
+ SetFocus (GetParent (IMAGE_INSTANCE_MSWINDOWS_CLIPWINDOW (p)));
}
}
＠＠ -2356,5 +2357,5 ＠＠
if ((IMAGE_INSTANCE_MSWINDOWS_CLIPWINDOW (ii)
= CreateWindowEx(
- 0, /* EX flags */
+ WS_EX_CONTROLPARENT, /* EX flags */
XEMACS_CONTROL_CLASS,
0, /* text */
＠＠ -2418,5 +2419,7 ＠＠
struct Lisp_Image_Instance *ii = XIMAGE_INSTANCE (image_instance);
HWND wnd;
- int flags = BS_NOTIFY;
+ int flags = WS_TABSTOP;/* BS_NOTIFY #### is needed to get exotic feedback
+ only. Since we seem to want nothing beyond BN_CLICK,
+ the style is perhaps not necessary -- kkm */
Lisp_Object style;
Lisp_Object gui = IMAGE_INSTANCE_WIDGET_ITEM (ii);
＠＠ -2424,7 +2427,4 ＠＠
Lisp_Object glyph = find_keyword_in_vector (instantiator, Q_image);
- if (!gui_item_active_p (gui))
- flags |= WS_DISABLED;
-
if (!NILP (glyph))
{
＠＠ -2448,9 +2448,11 ＠＠
}
else
- flags |= BS_DEFPUSHBUTTON;
+ {
+ flags |= BS_PUSHBUTTON;
+ }
mswindows_widget_instantiate (image_instance, instantiator, pointer_fg,
- pointer_bg, dest_mask, domain, "BUTTON", flags,
- WS_EX_CONTROLPARENT);
+ pointer_bg, dest_mask, domain, "BUTTON",
+ flags, 0);
wnd = WIDGET_INSTANCE_MSWINDOWS_HANDLE (ii);
＠＠ -2466,7 +2468,7 ＠＠
(WPARAM) (XIMAGE_INSTANCE_MSWINDOWS_BITMAP (glyph) ?
IMAGE_BITMAP : IMAGE_ICON),
- (LPARAM) (XIMAGE_INSTANCE_MSWINDOWS_BITMAP (glyph) ?
- XIMAGE_INSTANCE_MSWINDOWS_BITMAP (glyph) :
- XIMAGE_INSTANCE_MSWINDOWS_ICON (glyph)));
+ (XIMAGE_INSTANCE_MSWINDOWS_BITMAP (glyph) ?
+ (LPARAM) XIMAGE_INSTANCE_MSWINDOWS_BITMAP (glyph) :
+ (LPARAM) XIMAGE_INSTANCE_MSWINDOWS_ICON (glyph)));
}
}
＠＠ -2481,6 +2483,5 ＠＠
pointer_bg, dest_mask, domain, "EDIT",
ES_LEFT | ES_AUTOHSCROLL | WS_TABSTOP
- | WS_BORDER,
- WS_EX_CLIENTEDGE | WS_EX_CONTROLPARENT);
+ | WS_BORDER, WS_EX_CLIENTEDGE);
}
＠＠ -2495,6 +2496,5 ＠＠
mswindows_widget_instantiate (image_instance, instantiator, pointer_fg,
pointer_bg, dest_mask, domain, PROGRESS_CLASS,
- WS_TABSTOP | WS_BORDER | PBS_SMOOTH,
- WS_EX_CLIENTEDGE | WS_EX_CONTROLPARENT);
+ WS_BORDER | PBS_SMOOTH, WS_EX_CLIENTEDGE);
wnd = WIDGET_INSTANCE_MSWINDOWS_HANDLE (ii);
/* set the colors */
＠＠ -2580,5 +2580,5 ＠＠
WS_TABSTOP | WS_BORDER | PBS_SMOOTH
| TVS_HASLINES | TVS_HASBUTTONS,
- WS_EX_CLIENTEDGE | WS_EX_CONTROLPARENT);
+ WS_EX_CLIENTEDGE);
wnd = WIDGET_INSTANCE_MSWINDOWS_HANDLE (ii);
＠＠ -2643,6 +2643,5 ＠＠
pointer_bg, dest_mask, domain, WC_TABCONTROL,
/* borders don't suit tabs so well */
- WS_TABSTOP,
- WS_EX_CONTROLPARENT);
+ WS_TABSTOP, 0);
wnd = WIDGET_INSTANCE_MSWINDOWS_HANDLE (ii);
＠＠ -2708,6 +2707,5 ＠＠
mswindows_widget_instantiate (image_instance, instantiator, pointer_fg,
pointer_bg, dest_mask, domain, "SCROLLBAR",
- 0,
- WS_EX_CLIENTEDGE );
+ WS_TABSTOP, WS_EX_CLIENTEDGE);
}
＠＠ -2740,5 +2738,5 ＠＠
| CBS_AUTOHSCROLL
| CBS_HASSTRINGS | WS_VSCROLL,
- WS_EX_CLIENTEDGE | WS_EX_CONTROLPARENT);
+ WS_EX_CLIENTEDGE);
/* reset the height */
widget_text_to_pixel_conversion (domain,
- 3 participants
- 7 comments
Re: "Symbol X has different size in shared object" bug reappears
24 years, 8 months
Jan Vroonhof
Jan Vroonhof
Martin Buchholz <martin(a)xemacs.org> writes:
> Well, the way it *should* work is that the RPATH baked into the
> executable is searched first, and then, if not all libraries are
> found, /etc/ld.so.conf is searched, and if not all libraries are
> found, the hardcoded /usr/lib is searched.
However as I said before that way you can no longer override the search using
LD_LIBRARY_PATH
prompt> gcc main.c -o main
prompt> ldd main
libc.so.6 => /lib/libc.so.6 (0x4001a000)
/lib/ld-linux.so.2 => /lib/ld-linux.so.2 (0x40000000)
prompt> gcc main.c -Wl,-rpath=/tmp/vroonhof/librpath -o mainrpath
prompt> ldd mainrpath
libc.so.6 => /tmp/vroonhof/librpath/libc.so.6 (0x40014000)
/lib/ld-linux.so.2 => /lib/ld-linux.so.2 (0x40000000)
prompt> setenv LD_LIBRARY_PATH /tmp/vroonhof/libs
prompt> ldd main
libc.so.6 => /tmp/vroonhof/libs/libc.so.6 (0x40014000)
/lib/ld-linux.so.2 => /lib/ld-linux.so.2 (0x40000000)
prompt> ldd mainrpath
libc.so.6 => /tmp/vroonhof/librpath/libc.so.6 (0x40014000)
/lib/ld-linux.so.2 => /lib/ld-linux.so.2 (0x40000000)
Everything also on Redhat 6.0. However that might simply be the price
to pay to get rid of the libXaw problem (short of more drastic
measures like not subclassing any widgets or linking plain athena statically).
Jan
- 1 participants
- 0 comments
make check fails in latest CVS.
24 years, 8 months
Martin Buchholz
Martin Buchholz
XEmacs builds, but can't pass the test suite.
Try building a debug build on Unix, and running `make check'. You get
a crash as below.
The problem seems to be that real_gutter_size[TOP_GUTTER] is assumed
to be either Qnil or an integer, but in fact it gets the value
Qunbound. (I don't know wherefrom - because it's a specifier?).
I tried the following obvious patch, which made the crash go away.
Index: gutter.h
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs/src/Attic/gutter.h,v
retrieving revision 1.1.2.5
diff -u -r1.1.2.5 gutter.h
--- gutter.h 1999/12/23 02:50:45 1.1.2.5
+++ gutter.h 2000/01/15 10:05:48
＠＠ -63,11 +63,11 ＠＠
void reset_gutter_display_lines (struct frame* f);
#define WINDOW_GUTTER_BORDER_WIDTH(w, pos) \
-(NILP ((w)->gutter_border_width[pos]) ? 0 : XINT ((w)->gutter_border_width[pos]))
+(!INTP ((w)->gutter_border_width[pos]) ? 0 : XINT ((w)->gutter_border_width[pos]))
#define WINDOW_GUTTER_SIZE(w, pos) \
-(NILP ((w)->gutter_size[pos]) ? 0 : XINT ((w)->gutter_size[pos]))
+(!INTP ((w)->gutter_size[pos]) ? 0 : XINT ((w)->gutter_size[pos]))
#define WINDOW_GUTTER_SIZE_INTERNAL(w, pos) \
-(NILP ((w)->real_gutter_size[pos]) ? 0 : XINT ((w)->real_gutter_size[pos]))
+(!INTP ((w)->real_gutter_size[pos]) ? 0 : XINT ((w)->real_gutter_size[pos]))
#define WINDOW_GUTTER_VISIBLE(w, pos) \
((w)->gutter_visible_p[pos])
#define WINDOW_GUTTER(w, pos) \
As usual, I have no idea what's going on here. Andy, please help.
Figure out why the values Qnil and Qunbound are both coming into play
here, and whether my patch is in any way the right thing to do.
Note that all of this is happening with -batch.
Martin
Debugging session follows.
(martin＠lasker) /xemacs/build/ud9/src $ dm.
GNU gdb 4.17.0.11 with Linux support
Copyright 1998 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB. Type "show warranty" for details.
This GDB was configured as "i386-redhat-linux"...check-xemacs
(gdb) Loading big-menubar...
Loading comint... (file comint.el is newer)
Loading blink-paren...
Testing /xemacs/build/ud9/tests/automated/base64-tests.el...
base64-tests.el: 1232 of 1232 (100%) tests successful.Fatal error: assertion failed, file /xemacs/ws/dev/src/lisp.h, line 1292, INTP (obj)
Program received signal SIGABRT, Aborted.
0x402cd111 in __kill ()
(gdb) where 10
#0 0x402cd111 in __kill ()
#1 0x402ccd66 in raise (sig=6) at ../sysdeps/posix/raise.c:27
#2 0x402ce447 in abort () at ../sysdeps/generic/abort.c:88
#3 0x808f948 in assert_failed (file=0x8210482 "/xemacs/ws/dev/src/lisp.h", line=1292, expr=0x8210643 "INTP (obj)") at /xemacs/ws/dev/src/emacs.c:2833
#4 0x80b7198 in XINT (obj={...}) at /xemacs/ws/dev/src/lisp.h:1292
#5 0x81cdf2f in window_top_gutter_height (w=0x82e15f8) at /xemacs/ws/dev/src/window.c:1016
#6 0x81d4199 in window_pixel_height_to_char_height (w=0x82e15f8, pixel_height=9, include_gutters_p=0) at /xemacs/ws/dev/src/window.c:3584
#7 0x81d42ed in window_char_height (w=0x82e15f8, include_gutters_p=0) at /xemacs/ws/dev/src/window.c:3636
#8 0x81ceb8d in Fwindow_height (window={...}) at /xemacs/ws/dev/src/window.c:1300
#9 0x8097387 in Ffuncall (nargs=2, args=0xbfffaf60) at /xemacs/ws/dev/src/eval.c:3175
(More stack frames follow...)
(gdb) lbt
window-height(#<window on "*scratch*" 0x309>)
# bind (window old-frame target-frame explicit-frame)
byte-code("..." [nil explicit-frame target-frame old-frame window last-nonminibuf-frame selected-frame get-buffer buffer bufferp wrong-type-argument pre-display-buffer-function not-this-window-p override-frame display-buffer-function throw done buffer-dedicated-frame dedi frame-live-p window-buffer selected-window display-buffer-1 buffer-name same-window-buffer-names assoc switch-to-buffer same-window-regexps tem car string-match pop-up-frames 0 get-buffer-window special-display-function special-display-buffer-names special-display-regexps frame-selected-window pop-up-frame-function set-window-buffer pop-up-windows frame-property minibuffer only window-dedicated-p frame-root-window split-height-threshold window-min-height split-width-threshold window-min-width ...] 7)
# (catch done ...)
# bind (override-frame not-this-window-p buffer)
display-buffer(#<buffer "*Test-Log*">)
# bind (pre-display-buffer-function buffer)
show-temp-buffer-in-current-frame(#<buffer "*Test-Log*">)
# bind (standard-output)
(with-output-to-temp-buffer "*Test-Log*" (defmacro Assert (assertion) (backquote ...)) (defmacro Check-Error (expected-error &rest body) (let ... ...)) (defmacro Check-Error-Message (expected-error expected-error-regexp &rest body) (let ... ...)) (defmacro Check-Message (expected-message-regexp &rest body) (let ... ...)) (defmacro Ignore-Ebola (&rest body) (backquote ...)) (defun Int-to-Marker (pos) (save-excursion ... ...)) (princ "Testing Interpreted Lisp\n\n") (condition-case error-info (funcall ...) (error ... ... ... ...)) (princ "\nTesting Compiled Lisp\n\n") (let (code) (condition-case error-info ... ...) (condition-case error-info ... ...)) (princ "\nSUMMARY:\n") (princ (format " %5d passes\n" passes)) (princ (format " %5d assertion failures\n" assertion-failures)) (princ (format " %5d errors that should have been generated, but weren't\n" no-error-failures)) (princ (format " %5d wrong-error failures\n" wrong-error-failures)) (princ (format " %5d missing-message failures\n" missing-message-failures)) (princ (format " %5d other failures\n" other-failures)) (let* (... ... ...) (message "%s" summary-msg)) (when unexpected-test-suite-failure (message "Test suite execution failed unexpectedly.")) (fmakunbound (quote Assert)) (fmakunbound (quote Check-Error)) (fmakunbound (quote Ignore-Ebola)) (fmakunbound (quote Int-to-Marker)))
)
# bind (debug-on-error unexpected-test-suite-failure trick-optimizer other-failures missing-message-failures wrong-error-failures no-error-failures assertion-failures passes)
(let ((passes 0) (assertion-failures 0) (no-error-failures 0) (wrong-error-failures 0) (missing-message-failures 0) (other-failures 0) (trick-optimizer nil) (unexpected-test-suite-failure nil) (debug-on-error t)) (with-output-to-temp-buffer "*Test-Log*" (defmacro Assert ... ...) (defmacro Check-Error ... ...) (defmacro Check-Error-Message ... ...) (defmacro Check-Message ... ...) (defmacro Ignore-Ebola ... ...) (defun Int-to-Marker ... ...) (princ "Testing Interpreted Lisp\n\n") (condition-case error-info ... ...) (princ "\nTesting Compiled Lisp\n\n") (let ... ... ...) (princ "\nSUMMARY:\n") (princ ...) (princ ...) (princ ...) (princ ...) (princ ...) (princ ...) (let* ... ...) (when unexpected-test-suite-failure ...) (fmakunbound ...) (fmakunbound ...) (fmakunbound ...) (fmakunbound ...)))
)
# bind (filename inbuffer)
test-harness-from-buffer(#<buffer " *Test Input*"> "/xemacs/build/ud9/tests/automated/base64-tests.el")
# bind (input-buffer test-harness-current-file)
(let ((test-harness-current-file filename) input-buffer) (save-excursion (setq input-buffer ...) (set-buffer input-buffer) (erase-buffer) (insert-file-contents filename) (let ... ... ...)) (test-harness-from-buffer input-buffer filename) (kill-buffer input-buffer))
)
# bind (filename)
test-emacs-test-file("/xemacs/build/ud9/tests/automated/base64-tests.el")
(progn (test-emacs-test-file file) t)
)
# (condition-case ... . ((error (princ ">>Error occurred processing ") (princ file) (princ ": ") (display-error error-info nil) (terpri) nil)))
(condition-case error-info (progn (test-emacs-test-file file) t) (error (princ ">>Error occurred processing ") (princ file) (princ ": ") (display-error error-info nil) (terpri) nil))
)
# bind (file)
batch-test-emacs-1("/xemacs/build/ud9/tests/automated/base64-tests.el")
(or (batch-test-emacs-1 file-in-dir) (setq error t))
)
(if (and (string-match emacs-lisp-file-regexp file-in-dir) (not ...)) (or (batch-test-emacs-1 file-in-dir) (setq error t)))
)
(when (and (string-match emacs-lisp-file-regexp file-in-dir) (not ...)) (or (batch-test-emacs-1 file-in-dir) (setq error t)))
)
(while --dolist-temp--15901 (setq file-in-dir (car --dolist-temp--15901)) (when (and ... ...) (or ... ...)) (setq --dolist-temp--15901 (cdr --dolist-temp--15901)))
)
# bind (file-in-dir --dolist-temp--15901)
(let ((--dolist-temp--15901 ...) file-in-dir) (while --dolist-temp--15901 (setq file-in-dir ...) (when ... ...) (setq --dolist-temp--15901 ...)) nil)
)
# (catch --cl-block-nil-- ...)
(catch (quote --cl-block-nil--) (let (... file-in-dir) (while --dolist-temp--15901 ... ... ...) nil))
)
(cl-block-wrapper (catch (quote --cl-block-nil--) (let ... ... nil)))
)
(block nil (let (... file-in-dir) (while --dolist-temp--15901 ... ... ...) nil))
)
(dolist (file-in-dir (directory-files file t)) (when (and ... ...) (or ... ...)))
)
(if (file-directory-p file) (dolist (file-in-dir ...) (when ... ...)) (or (batch-test-emacs-1 file) (setq error t)))
)
(while --dolist-temp--15900 (setq file (car --dolist-temp--15900)) (if (file-directory-p file) (dolist ... ...) (or ... ...)) (setq --dolist-temp--15900 (cdr --dolist-temp--15900)))
)
# bind (file --dolist-temp--15900)
(let ((--dolist-temp--15900 command-line-args-left) file) (while --dolist-temp--15900 (setq file ...) (if ... ... ...) (setq --dolist-temp--15900 ...)) nil)
)
# (catch --cl-block-nil-- ...)
(catch (quote --cl-block-nil--) (let (... file) (while --dolist-temp--15900 ... ... ...) nil))
)
(cl-block-wrapper (catch (quote --cl-block-nil--) (let ... ... nil)))
)
(block nil (let (... file) (while --dolist-temp--15900 ... ... ...) nil))
)
(dolist (file command-line-args-left) (if (file-directory-p file) (dolist ... ...) (or ... ...)))
)
# bind (error)
(let ((error nil)) (dolist (file command-line-args-left) (if ... ... ...)) (message "Done") (kill-emacs (if error 1 0)))
)
batch-test-emacs()
# bind (arg)
command-line-do-funcall("-f")
# bind (dir file-count line end-of-options first-file-buffer file-p arg tem)
command-line-1()
# bind (command-line-args-left)
command-line()
# (unwind-protect ...)
normal-top-level()
# (condition-case ... . error)
# (catch top-level ...)
(gdb) where 10
#0 0x402cd111 in __kill ()
#1 0x402ccd66 in raise (sig=6) at ../sysdeps/posix/raise.c:27
#2 0x402ce447 in abort () at ../sysdeps/generic/abort.c:88
#3 0x808f948 in assert_failed (file=0x8210482 "/xemacs/ws/dev/src/lisp.h", line=1292, expr=0x8210643 "INTP (obj)") at /xemacs/ws/dev/src/emacs.c:2833
#4 0x80b7198 in XINT (obj={...}) at /xemacs/ws/dev/src/lisp.h:1292
#5 0x81cdf2f in window_top_gutter_height (w=0x82e15f8) at /xemacs/ws/dev/src/window.c:1016
#6 0x81d4199 in window_pixel_height_to_char_height (w=0x82e15f8, pixel_height=9, include_gutters_p=0) at /xemacs/ws/dev/src/window.c:3584
#7 0x81d42ed in window_char_height (w=0x82e15f8, include_gutters_p=0) at /xemacs/ws/dev/src/window.c:3636
#8 0x81ceb8d in Fwindow_height (window={...}) at /xemacs/ws/dev/src/window.c:1300
#9 0x8097387 in Ffuncall (nargs=2, args=0xbfffaf60) at /xemacs/ws/dev/src/eval.c:3175
(More stack frames follow...)
(gdb) f 5
#5 0x81cdf2f in window_top_gutter_height (w=0x82e15f8) at /xemacs/ws/dev/src/window.c:1016
1016 int gutter = WINDOW_REAL_TOP_GUTTER_BOUNDS (w);
(gdb) p *w
$1 = {header = {lheader = {type = 26, mark = 0, c_readonly = 0, lisp_readonly = 0}, next = 0x82e14c8, uid = 777, free = 0}, frame = {...}, mini_p = {...}, next = {...}, prev = {...}, hchild = {...}, vchild = {...}, parent = {...}, pixel_left = 0, pixel_top = 0, pixel_height = 9, pixel_width = 10, buffer = {...}, start = {{...}, {...}, {...}}, pointm = {{...}, {...}, {...}}, sb_point = {...}, hscroll = 0, modeline_hscroll = 0, top_yoffset = 0, left_xoffset = 0, use_time = {...}, last_modified = {{...}, {...}, {...}}, last_point = {{...}, {...}, {...}}, last_start = {{...}, {...}, {...}}, last_facechange = {{...}, {...}, {...}}, face_cachels = 0x0, glyph_cachels = 0x0, subwindow_instance_cache = {...}, line_start_cache = 0x0, line_cache_last_updated = {...}, line_cache_validation_override = 0, max_line_len = 0, last_point_x = {0, 0, 0}, last_point_y = {0, 0, 0}, window_end_pos = {0, 0, 0}, redisplay_end_trigger = {...}, last_redisplay_pos = 0, dedicated = {...}, display_table = {...}, modeline_shadow_thickness = {...}, has_modeline_p = {...}, vertical_divider_shadow_thickness = {...}, vertical_divider_line_width = {...}, vertical_divider_spacing = {...}, vertical_divider_always_visible_p = {...}, scrollbar_width = {...}, scrollbar_height = {...}, horizontal_scrollbar_visible_p = {...}, vertical_scrollbar_visible_p = {...}, scrollbar_on_left_p = {...}, scrollbar_on_top_p = {...}, scrollbar_pointer = {...}, toolbar = {{...}, {...}, {...}, {...}}, toolbar_size = {{...}, {...}, {...}, {...}}, toolbar_border_width = {{...}, {...}, {...}, {...}}, toolbar_visible_p = {{...}, {...}, {...}, {...}}, toolbar_buttons_captioned_p = {...}, default_toolbar = {...}, default_toolbar_width = {...}, default_toolbar_height = {...}, default_toolbar_visible_p = {...}, default_toolbar_border_width = {...}, gutter = {{...}, {...}, {...}, {...}}, gutter_size = {{...}, {...}, {...}, {...}}, real_gutter_size = {{...}, {...}, {...}, {...}}, gutter_border_width = {{...}, {...}, {...}, {...}}, gutter_visible_p = {{...}, {...}, {...}, {...}}, de
fault_gutter = {...}, default_gutter_width = {...}, default_gutter_height = {...}, default_gutter_visible_p = {...}, default_gutter_border_width = {...}, left_margin_width = {...}, right_margin_width = {...}, minimum_line_ascent = {...}, minimum_line_descent = {...}, use_left_overflow = {...}, use_right_overflow = {...}, menubar_visible_p = {...}, text_cursor_visible_p = {...}, config_mark = 0, dead = 0, force_start = 0, redo_modeline = 0, start_at_line_beg = 1, windows_changed = 1, shadow_thickness_changed = 1, need_vertical_divider_p = 0, need_vertical_divider_valid_p = 0}
(gdb) pobj w->real_gutter_size[TOP_GUTTER]
$7 = (struct symbol_value_forward *) 0x825ea0c
$8 = {magic = {lcheader = {lheader = {type = 1, mark = 0, c_readonly = 0, lisp_readonly = 0}, next = 0x0, uid = 69, free = 0}, type = SYMVAL_UNBOUND_MARKER}, magicfun = 0x1}
- 2 participants
- 1 comments
base64 tests cause core dump
24 years, 8 months
Norbert Koch
Norbert Koch
Hi!
I'm not sure exactly what the base64 tests are supposed to do, but
certainly not to break the build ...
XEmacs 21.2 (beta26) "Millenium" [Lucid] (i386-unknown-freebsdelf3.2) of Fri Jan 14 2000 on sokrates
gmake[1]: Entering directory `/usr/users/nk/archive/xemacs/src'
./xemacs -batch -l /usr/users/nk/archive/xemacs/src/../tests/automated/test-harn
ess.el -f batch-test-emacs /usr/users/nk/archive/xemacs/src/../tests/automated
Testing /usr/users/nk/archive/xemacs/tests/automated/base64-tests.el...
base64-tests.el: 1232 of 1232 (100%) tests successful.Fatal error: assertion failed, file lisp.h, line 1292, INTP (obj)
Lisp backtrace follows:
window-height(#<window on "*scratch*" 0x309>)
# bind (window old-frame target-frame explicit-frame)
byte-code("..." [nil explicit-frame target-frame old-frame window last-nonmini
buf-frame selected-frame get-buffer buffer bufferp wrong-type-argument pre-displ
ay-buffer-function not-this-window-p override-frame display-buffer-function thro
w done buffer-dedicated-frame dedi frame-live-p window-buffer selected-window di
splay-buffer-1 buffer-name same-window-buffer-names assoc switch-to-buffer same-
window-regexps tem car string-match pop-up-frames 0 get-buffer-window special-di
splay-function special-display-buffer-names special-display-regexps frame-select
ed-window pop-up-frame-function set-window-buffer pop-up-windows frame-property
minibuffer only window-dedicated-p frame-root-window split-height-threshold wind
ow-min-height split-width-threshold window-min-width unsplittable get-largest-wi
ndow visible t window-frame window-height window-width window-leftmost-p window-
rightmost-p split-window other upper get-lru-window window-parent window-previou
s-child window-next-child window-pixel-edges window-pixel-height enlarge-window
2 save-selected-window-window ((byte-code "À !«
 !À" ... 2)) select-wind
ow record-buffer] 7)
# (catch done ...)
# bind (override-frame not-this-window-p buffer)
display-buffer(#<buffer "*Test-Log*">)
# bind (pre-display-buffer-function buffer)
show-temp-buffer-in-current-frame(#<buffer "*Test-Log*">)
# bind (standard-output)
(with-output-to-temp-buffer "*Test-Log*" (defmacro Assert (assertion) (backquo
te ...)) (defmacro Check-Error (expected-error &rest body) (let ... ...)) (defma
cro Check-Error-Message (expected-error expected-error-regexp &rest body) (let .
.. ...)) (defmacro Check-Message (expected-message-regexp &rest body) (let ... .
..)) (defmacro Ignore-Ebola (&rest body) (backquote ...)) (defun Int-to-Marker (
pos) (save-excursion ... ...)) (princ "Testing Interpreted Lisp\n\n") (condition
-case error-info (funcall ...) (error ... ... ... ...)) (princ "\nTesting Compil
ed Lisp\n\n") (let (code) (condition-case error-info ... ...) (condition-case er
ror-info ... ...)) (princ "\nSUMMARY:\n") (princ (format " %5d passes\n" pa
sses)) (princ (format " %5d assertion failures\n" assertion-failures)) (princ (f
ormat " %5d errors that should have been generated, but weren't\n" no-error-fail
ures)) (princ (format " %5d wrong-error failures\n" wrong-error-failures)) (prin
c (format " %5d missing-message failures\n" missing-message-failures)) (prin
c (format " %5d other failures\n" other-failures)) (let* (... ... ...) (mess
age "%s" summary-msg)) (when unexpected-test-suite-failure (message "Test suite
execution failed unexpectedly.")) (fmakunbound (quote Assert)) (fmakunbound (quo
te Check-Error)) (fmakunbound (quote Ignore-Ebola)) (fmakunbound (quote Int-to-M
arker)))
)
# bind (debug-on-error unexpected-test-suite-failure trick-optimizer other-fai
lures missing-message-failures wrong-error-failures no-error-failures assertion-
failures passes)
(let ((passes 0) (assertion-failures 0) (no-error-failures 0) (wrong-error-fai
lures 0) (missing-message-failures 0) (other-failures 0) (trick-optimizer nil) (
unexpected-test-suite-failure nil) (debug-on-error t)) (with-output-to-temp-buff
er "*Test-Log*" (defmacro Assert ... ...) (defmacro Check-Error ... ...) (defmac
ro Check-Error-Message ... ...) (defmacro Check-Message ... ...) (defmacro Ignor
e-Ebola ... ...) (defun Int-to-Marker ... ...) (princ "Testing Interpreted Lisp\
n\n") (condition-case error-info ... ...) (princ "\nTesting Compiled Lisp\n\n")
(let ... ... ...) (princ "\nSUMMARY:\n") (princ ...) (princ ...) (princ ...) (pr
inc ...) (princ ...) (princ ...) (let* ... ...) (when unexpected-test-suite-fail
ure ...) (fmakunbound ...) (fmakunbound ...) (fmakunbound ...) (fmakunbound ...)
))
)
# bind (filename inbuffer)
test-harness-from-buffer(#<buffer " *Test Input*"> "/usr/users/nk/archive/xema
cs/tests/automated/base64-tests.el")
# bind (input-buffer test-harness-current-file)
(let ((test-harness-current-file filename) input-buffer) (save-excursion (setq
input-buffer ...) (set-buffer input-buffer) (erase-buffer) (insert-file-content
s filename) (let ... ... ...)) (test-harness-from-buffer input-buffer filename)
(kill-buffer input-buffer))
)
# bind (filename)
test-emacs-test-file("/usr/users/nk/archive/xemacs/tests/automated/base64-test
s.el")
(progn (test-emacs-test-file file) t)
)
# (condition-case ... . ((error (princ ">>Error occurred processing ") (princ file) (princ ": ") (display-error error-info nil) (terpri) nil)))
(condition-case error-info (progn (test-emacs-test-file file) t) (error (princ
">>Error occurred processing ") (princ file) (princ ": ") (display-error error-
info nil) (terpri) nil))
)
# bind (file)
batch-test-emacs-1("/usr/users/nk/archive/xemacs/tests/automated/base64-tests.
el")
(or (batch-test-emacs-1 file-in-dir) (setq error t))
)
(if (and (string-match emacs-lisp-file-regexp file-in-dir) (not ...)) (or (bat
ch-test-emacs-1 file-in-dir) (setq error t)))
)
(when (and (string-match emacs-lisp-file-regexp file-in-dir) (not ...)) (or (b
atch-test-emacs-1 file-in-dir) (setq error t)))
)
(while --dolist-temp--86801 (setq file-in-dir (car --dolist-temp--86801)) (whe
n (and ... ...) (or ... ...)) (setq --dolist-temp--86801 (cdr --dolist-temp--868
01)))
)
# bind (file-in-dir --dolist-temp--86801)
(let ((--dolist-temp--86801 ...) file-in-dir) (while --dolist-temp--86801 (set
q file-in-dir ...) (when ... ...) (setq --dolist-temp--86801 ...)) nil)
)
# (catch --cl-block-nil-- ...)
(catch (quote --cl-block-nil--) (let (... file-in-dir) (while --dolist-temp--8
6801 ... ... ...) nil))
)
(cl-block-wrapper (catch (quote --cl-block-nil--) (let ... ... nil)))
)
(block nil (let (... file-in-dir) (while --dolist-temp--86801 ... ... ...) nil
))
)
(dolist (file-in-dir (directory-files file t)) (when (and ... ...) (or ... ...
)))
)
(if (file-directory-p file) (dolist (file-in-dir ...) (when ... ...)) (or (bat
ch-test-emacs-1 file) (setq error t)))
)
(while --dolist-temp--86800 (setq file (car --dolist-temp--86800)) (if (file-d
irectory-p file) (dolist ... ...) (or ... ...)) (setq --dolist-temp--86800 (cdr
--dolist-temp--86800)))
)
# bind (file --dolist-temp--86800)
(let ((--dolist-temp--86800 command-line-args-left) file) (while --dolist-temp
--86800 (setq file ...) (if ... ... ...) (setq --dolist-temp--86800 ...)) nil)
)
# (catch --cl-block-nil-- ...)
(catch (quote --cl-block-nil--) (let (... file) (while --dolist-temp--86800 ..
. ... ...) nil))
)
(cl-block-wrapper (catch (quote --cl-block-nil--) (let ... ... nil)))
)
(block nil (let (... file) (while --dolist-temp--86800 ... ... ...) nil))
)
(dolist (file command-line-args-left) (if (file-directory-p file) (dolist ...
...) (or ... ...)))
)
# bind (error)
(let ((error nil)) (dolist (file command-line-args-left) (if ... ... ...)) (me
ssage "Done") (kill-emacs (if error 1 0)))
)
batch-test-emacs()
# bind (arg)
command-line-do-funcall("-f")
# bind (dir file-count line end-of-options first-file-buffer file-p arg tem)
command-line-1()
# bind (command-line-args-left)
command-line()
# (unwind-protect ...)
normal-top-level()
# (condition-case ... . error)
# (catch top-level ...)
(gdb) bt
#0 0x28467c78 in kill () from /usr/lib/libc.so.3
#1 0x808453d in fatal_error_signal (sig=6) at emacs.c:278
#2 0xbfbfdfdc in ?? ()
#3 0x808449f in assert_failed (file=0x81fce22 "lisp.h", line=1292,
expr=0x81fcfe3 "INTP (obj)") at emacs.c:2833
#4 0x818b203 in window_top_gutter_height (w=0x828f000) at lisp.h:1292
#5 0x8196306 in window_char_height (w=0x828f000, include_gutters_p=0)
at window.c:3584
#6 0x8196d22 in Fwindow_height (window=136900608) at window.c:1300
#7 0x8089604 in Ffuncall (nargs=2, args=0xbfbfa6ac) at eval.c:3175
#8 0x806053c in execute_optimized_program (
program=0xbfbfa710 "À\211\211\211\031\032\e\034Å ®\003Æ \023Ç\016\b!\026\bÉ\016\b!¬\bÊÉ\016\b\"\026\b\016\013\n\016\013\016\b\016\f\016\r#\021\016\016«\016ÏÐ\016\016\016\b\016\f\016\r#\"\210Ñ\016\b!\036\022Ó\016\022!«\004\016\022\021)\016\r«\021Ó\016\r!¬\bÊÓ\016\r\"\026\r\016\r\021\t®\aÅ ®\003Æ \022\013\na¬\004À\026\f\016\f¬\022\016\bÔÕ !a«\tÏÐÖÕ !\"\210\016\f¬h×\016\b!\016\030¶¬\013Ù×\016\b!\016\030\"«\016Ú\016\b!\210ÏÐÖÕ !\"\210\016\e\211\036\034«＠\016\034＠\211\036\035;«\013Þ\016\035×\016\b!\""..., stack_depth=7, constants_data=0x834ee10)
at bytecode.c:747
#9 0x80630e2 in Fbyte_code (instructions=138261140, constants=137686528,
stack_depth=15) at bytecode.c:2404
#10 0x8088bb2 in Feval (form=138231672) at eval.c:2975
#11 0x808d965 in internal_catch (tag=137234748, func=0x8088324 <Feval>,
arg=138231672, threw=0x0) at eval.c:1304
#12 0x8060ffc in execute_rare_opcode (stack_ptr=0xbfbfaf0c,
program_ptr=0x85749d5 "\e\211\034À k¬\005Å\f!\210\013*\207 tests successful.en't\nw)) \a\035HW\b＠JW\b\e\037", opcode=Bcatch) at bytecode.c:1253
#13 0x80602ff in execute_optimized_program (
program=0x85749d0 "À ÁÂ\215\e\211\034À k¬\005Å\f!\210\013*\207 tests successful.en't\nw)) \a\035HW\b＠JW\b\e\037", stack_depth=4, constants_data=0x83daf10)
at bytecode.c:657
#14 0x8060105 in funcall_compiled_function (fun=138253244, nargs=1,
args=0xbfbfb00c) at bytecode.c:519
#15 0x808977b in Ffuncall (nargs=2, args=0xbfbfb008) at eval.c:3210
#16 0x806053c in execute_optimized_program (
program=0x858e110 "À\031Â\013!\034Å Æ\f!a¬\005ÇÈ!\210\f\026\tÊ\fË\"\210Ì\fË\"\210\016\r«'Î\016\017ÐÆ\f!!_!\036\021Ò\f!\211\036\023\016\021W«\013Ô\016\021\016\023ZÀ\f#\210*Õ\f!\210*À\207-decode-string (aw)))) raw)) raw)ÂÁÀ\026àX\b",
stack_depth=6, constants_data=0x8301b90) at bytecode.c:747
#17 0x8060105 in funcall_compiled_function (fun=137365000, nargs=1,
args=0xbfbfb118) at bytecode.c:519
#18 0x808977b in Ffuncall (nargs=2, args=0xbfbfb114) at eval.c:3210
#19 0x808cfe0 in call1 (fn=137346084, arg0=139586560) at eval.c:3824
#20 0x818f7ed in temp_output_buffer_show (buf=139586560, same_frame=136603652)
at window.c:3296
#21 0x812633d in Fwith_output_to_temp_buffer (args=137136576) at print.c:473
norbert.
--
LBJ, LBJ, how many JOKES did you tell today??!
- 1 participants
- 0 comments