January 2000 - XEmacs-Beta - XEmacs Mailing List Archives

21.2.27 gutter tab display bug 24 years, 11 months

Raymond Toy

The gutter tabs in 21.2.27 don't quite display right. The border between the tabs and the window isn't drawn clear across the window anymore. They used to be in 21.2.26. This is on Solaris 2.7. (Hmm, I wonder if this is caused by the patch that Andy sent out to fix my gutter tabs problem.... Need to check.) Ray

3 participants
3 comments

[PATCH] Recompute glyph metrics when face changes 24 years, 11 months

Kirill 'Big K' Katsnelson

Ever noticed that when there is a glyph with text instance and a face, XEmacs does not recompute the glyph when face changes? When increasing face font size, the text grows and gets clipped by the rectangle which was the glyph instance size at the moment of glyph creation. Reproduction: Copy the following lines after the initial three in *scratch*, and execute the first 3. Then, as you play with font size, glyph size does not change, so there is either a gap or clipping at the right of the glyph. (setq g (make-glyph [string :data "GlYpH!"])) (setq e (make-extent 5 5)) (set-extent-begin-glyph e g) (cons (glyph-width g) (glyph-height g)) (make-face-larger 'default) (make-face-smaller 'default) Unfortunately, it is not quite possible to update more specific glyphs when a face changes. Even if faces tracked glyphs which have this face as their face, it would not be possible to notice glyph change when this face changes through inheritance. So I update a glyph instance in a window when both frame faces marked as changed and glyph instance in the window is text. 2000-01-29 Kirill 'Big K' Katsnelson <kkm(a)dtmx.com> * glyphs.c (image_instance_layout): Mark image instance as clean after layout. (glyph_dirty_p): Removed redundant function. (invalidate_glyph_geometry_maybe): Added. (update_glyph_cachel_data): Call it. * glyphs.h: Prototyped it. * redisplay.c (add_glyph_rune): Call it. (redisplay_window): Reset glyphs cachels when frame faces has changed, thus forcing recomputation of built-in border glyphs. Index: glyphs.c =================================================================== RCS file: /usr/CVSroot/XEmacs/xemacs/src/glyphs.c,v retrieving revision 1.23.2.43 diff -u -r1.23.2.43 glyphs.c --- glyphs.c 2000/01/28 12:41:45 1.23.2.43 +++ glyphs.c 2000/01/30 00:34:27 ＠＠ -1691,8 +1691,42 ＠＠ IIFORMAT_METH (meths, layout, (image_instance, width, height, domain)); } /* else no change to the geometry. */ + + XIMAGE_INSTANCE_DIRTYP (image_instance) = 0; } +/* + * Mark image instance in W as dirty if (a) W's faces have changed and + * (b) GLYPH_OR_II instance in W is a string. + * + * Return non-zero if instance has been marked dirty. + */ +int +invalidate_glyph_geometry_maybe (Lisp_Object glyph_or_ii, struct window* w) +{ + if (XFRAME(WINDOW_FRAME(w))->faces_changed) + { + Lisp_Object image = glyph_or_ii; + + if (GLYPHP (glyph_or_ii)) + { + Lisp_Object window; + XSETWINDOW (window, w); + image = glyph_image_instance (glyph_or_ii, window, ERROR_ME_NOT, 1); + } + + if (TEXT_IMAGE_INSTANCEP (image)) + { + XIMAGE_INSTANCE_DIRTYP (image) = 1; + if (GLYPHP (glyph_or_ii)) + XGLYPH_DIRTYP (glyph_or_ii) = 1; + return 1; + } + } + + return 0; +} + /************************************************************************/ /* error helpers */ ＠＠ -3488,6 +3522,7 ＠＠ Lisp_Object image_instance = specifier_instance (specifier, Qunbound, domain, errb, no_quit, 0, Qzero); + assert (!UNBOUNDP (image_instance)); return image_instance; } ＠＠ -3631,13 +3666,6 ＠＠ return make_int (glyph_height (glyph, window)); } -static unsigned int -glyph_dirty_p (Lisp_Object glyph_or_image, Lisp_Object window) -{ - return XIMAGE_INSTANCE_DIRTYP (glyph_image_instance_maybe - (glyph_or_image, window)); -} - static void set_glyph_dirty_p (Lisp_Object glyph_or_image, Lisp_Object window, int dirty) { ＠＠ -3767,17 +3795,25 ＠＠ struct glyph_cachel *cachel) { if (!cachel->updated || NILP (cachel->glyph) || !EQ (cachel->glyph, glyph) - || XGLYPH_DIRTYP (cachel->glyph)) + || XGLYPH_DIRTYP (cachel->glyph) + || XFRAME(WINDOW_FRAME(w))->faces_changed) { Lisp_Object window, instance; XSETWINDOW (window, w); cachel->glyph = glyph; - /* Speed things up slightly by grabbing the glyph instantiation - and passing it to the size functions. */ + /* Speed things up slightly by grabbing the glyph instantiation + and passing it to the size functions. */ instance = glyph_image_instance (glyph, window, ERROR_ME_NOT, 1); - cachel->dirty = XGLYPH_DIRTYP (glyph) = glyph_dirty_p (glyph, window); + + /* Mark text instance of the glyph dirty if faces have changed, + because its geometry might have changed. */ + invalidate_glyph_geometry_maybe (instance, w); + + /* #### Do the following 2 lines buy us anything? --kkm */ + XGLYPH_DIRTYP (glyph) = XIMAGE_INSTANCE_DIRTYP (instance); + cachel->dirty = XGLYPH_DIRTYP (glyph); cachel->width = glyph_width (instance, window); cachel->ascent = glyph_ascent (instance, window); cachel->descent = glyph_descent (instance, window); Index: glyphs.h =================================================================== RCS file: /usr/CVSroot/XEmacs/xemacs/src/glyphs.h,v retrieving revision 1.18.2.28 diff -u -r1.18.2.28 glyphs.h --- glyphs.h 2000/01/25 09:15:43 1.18.2.28 +++ glyphs.h 2000/01/30 00:34:28 ＠＠ -335,6 +335,7 ＠＠ void image_instance_layout (Lisp_Object image_instance, unsigned int width, unsigned int height, Lisp_Object domain); +int invalidate_glyph_geometry_maybe (Lisp_Object glyph_or_ii, struct window* w); DECLARE_DOESNT_RETURN (incompatible_image_types (Lisp_Object instantiator, int given_dest_mask, Index: redisplay.c =================================================================== RCS file: /usr/CVSroot/XEmacs/xemacs/src/redisplay.c,v retrieving revision 1.55.2.36 diff -u -r1.55.2.36 redisplay.c --- redisplay.c 2000/01/26 12:34:04 1.55.2.36 +++ redisplay.c 2000/01/30 00:34:30 ＠＠ -1524,6 +1524,10 ＠＠ { struct window *w = XWINDOW (data->window); + /* If window faces changed, and glyph instance is text, then + glyph sizes might have changed too */ + invalidate_glyph_geometry_maybe (gb->glyph, w); + /* A nil extent indicates a special glyph (ex. truncator). */ if (NILP (gb->extent) || (pos_type == BEGIN_GLYPHS && ＠＠ -5931,7 +5935,7 ＠＠ the cache purely because glyphs have changed - this is now handled by the dirty flag.*/ if ((!echo_active && b != window_display_buffer (w)) - || !Dynarr_length (w->glyph_cachels)) + || !Dynarr_length (w->glyph_cachels) || f->faces_changed) reset_glyph_cachels (w); else mark_glyph_cachels_as_not_updated (w);

3 participants
4 comments

[PATCH] Use system underline and struke thru fonts 24 years, 11 months

Kirill 'Big K' Katsnelson

I am cleaning up the redisplay code to implement printing in Windows. This patch uses system-provided underline and strike out fonts. Struck out and underlined fonts are now supported on widgets, for no reason, because nobody wants them to look like that anyway! :) The idea is that each font instance has up to four HFONTs associated with it, called variants, for all under/struck combinations. Only one is created initially, with the rest being created and cached in instance data as they are needed, during redisplay. This patch accumulates Windows specific changes, winsys-independent part is under way. An RFC. There are now 2 ways to create an underlined face. One is to specify font modifier 'underline', like "Courier New:Regular:9:underline". The other way is to create a non-underlined font, and set underline-p property of the *face* to t. These faces won't be the same. Even worse, the first face line height will be 1 greater than the second! (Although, with 10pt size, they are same. Thanks Bill!). Should the modifiers 'underline' and 'strikethru' go away from the fonts? Big K 2000-01-17 Kirill 'Big K' Katsnelson <kkm(a)dtmx.com> * faces.h (FACE_STRIKETHRU_P): Added. * glyphs-msw.c (mswindows_widget_hfont): Implemented, to take care of font variants. * redisplay-msw.c (mswindows_apply_face_effects): Deleted. (mswindows_set_dc_font): New function, aware of font variants, separated from mswindows_update_dc. * objects-msw.h (struct mswindows_font_instance_data): Added definition. * objects-msw.c (mswindows_finalize_font_instance): Delete all cached fonts and the data structure. (mswindows_initialize_font_instance): Added creation of font data structure. (mswindows_print_font_instance): Print at least something. (mswindows_create_font_variant): Implemented. (mswindows_get_hfont): Implemented.

6 participants
13 comments

Re: That gutter again 24 years, 11 months

Hrvoje Niksic

Andy Piper <andy(a)xemacs.org> writes: > >Ah, great! Is this documented somewhere? The thing is driving me > > No, because it is not the Right Way. The right way is to customize > gutter-visible-p which should be self documenting. You mean the variable `gutter-visible-p' has no effect if setq'ed? That seems evil. The gutter code could check whether gutter-visible-p is non-nil, and choose to redraw the gutter according to that.

5 participants
6 comments

Re: font-menu-ignore-scaled-fonts in 21.1. and 21.2 24 years, 11 months

Andreas Jaeger

>>>>> Jan Vroonhof writes: Jan> Andreas Jaeger <aj(a)suse.de> writes: >> The user has font-menu-ignore-scaled-fonts set to t. Jan> Did he explicitly set that? Why? Note that the default differs in 21.2 Jan> and 21.1. >> Why is that part of the code in 21.1.8 commented out? Jan> Because of Jan> 1998-08-26 Jan Vroonhof <vroonhof(a)math.ethz.ch> Jan> * menubar-items.el (default-menubar): Remove "Font Weight" Jan> option, there is currently no custom equivalent.. Customize-faces Jan> is "Edit faces". Jan> However I guess I was a bit too overzealous. >> ;; (if (and (member weight (aref entry 1)) >> ;; (or (member size (aref entry 2)) >> ;; (and (not font-menu-ignore-scaled-fonts) >> ;; (member 0 (aref entry 2))))) >> ;; (enable-menu-item item) >> ;; (disable-menu-item item)) >> (if (and font-menu-ignore-scaled-fonts (member 0 (aref entry 2))) >> (disable-menu-item item) >> (enable-menu-item item)) Jan> This problem is actually a FAQ om comp.emacs.xemacs. Because I didn't Jan> see the problem when I last looked, we've just told people to set Jan> font-menu-ignore-scaled-fonts to nil as a work around. However, now Jan> that I look at it again, it is extremely trivial. I forgot the part that Jan> checked whether the size was actually available unscaled. Jan> It should be Jan> (if (and (not (member size (aref entry 2))) Jan> font-menu-ignore-scaled-fonts (member 0 (aref entry 2))) Jan> (disable-menu-item item) Jan> (enable-menu-item item)) Jan> This whole disabling thing needs a rethink anyway, since it can make Jan> it impossible to get from one family-size-weight combination to Jan> another if there is not of fonts with hamming distance 1 between them. Are you propossing the appended patch for 21.1.9? I'd like to see this fixed. Andreas Index: x-font-menu.el =================================================================== RCS file: /usr/CVSroot/XEmacs/xemacs-20/lisp/x-font-menu.el,v retrieving revision 1.5 diff -u -r1.5 x-font-menu.el --- x-font-menu.el 1999/05/13 12:19:37 1.5 +++ x-font-menu.el 2000/01/31 15:59:34 ＠＠ -445,15 +445,10 ＠＠ ;; The user can no longer easily control the weight using the menu ;; Note it is silly anyway as it could very well be that the font ;; has no common size+weight combinations with the default font. -;; (if (and (member weight (aref entry 1)) -;; (or (member size (aref entry 2)) -;; (and (not font-menu-ignore-scaled-fonts) -;; (member 0 (aref entry 2))))) -;; (enable-menu-item item) -;; (disable-menu-item item)) - (if (and font-menu-ignore-scaled-fonts (member 0 (aref entry 2))) + (if (and (not (member size (aref entry 2))) + font-menu-ignore-scaled-fonts (member 0 (aref entry 2))) (disable-menu-item item) - (enable-menu-item item)) + (enable-menu-item item)) (if (string-equal family f) (select-toggle-menu-item item) (deselect-toggle-menu-item item)) -- Andreas Jaeger SuSE Labs aj(a)suse.de private aj(a)arthur.rhein-neckar.de

1 participants
0 comments

Problem gone! (Was: Variable purify-flag gets defined wrongly in emacs.c) 24 years, 11 months

Ulrich Kaage

Hi, after removing every Makefile.in I could find and reconfiguring, xemacs compiled fine again. Greetings, Uli -- Dipl.-Ing. U.Kaage Tel. ++49/(0)721/608-6273 Institut fuer Nachrichtentechnik Fax. ++49/(0)721/608-6071 Universitaet Karlsruhe (TH) kaage(a)int.uni-karlsruhe.de 76128 Karlsruhe Home Page und PGP-Key: http://www-int.etec.uni-karlsruhe.de/~kaage/ --

1 participants
0 comments

Re: Crash when select tab 24 years, 11 months

Matthew Persico

>At 01:15 PM 1/4/00 -0500, Matthew Persico wrote: >> [3] DrawHighlight(), at 0x36e3f4 >> [4] XawTabsSetTop(0x73f000, 0x1, 0x416800, 0x1, 0x8efe00, 0xa60c00), at > 0x36d8d4 >This should be fixed. > andy > -------------------------------------------------------------- > Dr Andy Piper > Senior Consultant Architect, BEA Systems Ltd In 21.2.27 or a CVS extraction?

1 participants
0 comments

Re: That gutter again 24 years, 11 months

Michael Sperber

>>>>> "Hrvoje" == Hrvoje Niksic <hniksic(a)iskon.hr> writes: Hrvoje> Andy Piper <andy(a)xemacs.org> writes: >> >Ah, great! Is this documented somewhere? The thing is driving me >> >> No, because it is not the Right Way. The right way is to customize >> gutter-visible-p which should be self documenting. Hrvoje> You mean the variable `gutter-visible-p' has no effect if setq'ed? Exactly. Hrvoje> That seems evil. Exactly. The variable is just a strawman: (defcustom gutter-visible-p (specifier-instance default-gutter-visible-p) "Whether the default gutter is globally visible. This option can be customized through the options menu." :group 'display :type 'boolean :set #'(lambda (var val) (set-specifier default-gutter-visible-p val) (setq gutter-visible-p val))) -- Cheers =8-} Chipsy Friede, Völkerverständigung und überhaupt blabla

1 participants
0 comments

Variable purify-flag gets defined wrongly in emacs.c 24 years, 11 months

Ulrich Kaage

Hello, don't know if it matters but since a few days I can't build the latest development branch of xemacs (see output of make later) on SPARC. The error is caused by the lisp variable purify-flag in loadup.el which is defined although I neither specified --with-purify nor --with-quantify as configure argument. The following form in loadup.el gets evaluated around line 176: (when purify-flag (message "Finding pointers to doc strings...") (Snarf-documentation "DOC") (message "Finding pointers to doc strings...done") (Verify-documentation)) I figured out that the following statement in emacs.c around line 852 is the cause (PDUMP is undefined): purify_flag = 0; #ifdef PDUMP if (restart) initialized = 1; else { initialized = pdump_load (); purify_flag = !initialized; } #else if (!initialized) purify_flag = 1 /* 0 */; #endif ^^^ If I use zero as initializer to purify_flag, xemacs compiles fine. Here is what "make" says: ----- Loading very-early-lisp... Loading /net/inss1/tools/src/gnu/xemacs/xemacs-CVS/lisp/dumped-lisp.el... Loading /net/inss1/tools/src/gnu/xemacs/xemacs-CVS/lisp/backquote.elc... Loading /net/inss1/tools/src/gnu/xemacs/xemacs-CVS/lisp/bytecomp-runtime.elc... Loading /net/inss1/tools/src/gnu/xemacs/xemacs-CVS/lisp/find-paths.elc... Loading /net/inss1/tools/src/gnu/xemacs/xemacs-CVS/lisp/tty-init.elc... Loading /net/inss1/tools/src/gnu/xemacs/xemacs-CVS/lisp/fontl-hooks.elc... Loading /net/inss1/tools/src/gnu/xemacs/xemacs-CVS/lisp/auto-show.elc... Loading /net/inss1/tools/src/gnu/xemacs/xemacs-CVS/lisp/loadhist.elc... Loading /net/inss1/tools/src/gnu/xemacs/xemacs-CVS/lisp/loaddefs.elc... Loading site-load... Finding pointers to doc strings... xemacs exiting.Opening doc string file: No such file or directory, ../lib-src/DOC make[1]: [xemacs] Error 255 (ignored) Testing for Lisp shadows ... make[1]: ./xemacs: Command not found make[1]: *** [xemacs] Error 127 make[1]: Leaving directory `/net/inss1/tools/src/gnu/xemacs/xemacs-CVS/src' make: *** [src] Error 2 ----- end of output ----- Greetings, Uli -- Dipl.-Ing. U.Kaage Tel. ++49/(0)721/608-6273 Institut fuer Nachrichtentechnik Fax. ++49/(0)721/608-6071 Universitaet Karlsruhe (TH) kaage(a)int.uni-karlsruhe.de 76128 Karlsruhe Home Page und PGP-Key: http://www-int.etec.uni-karlsruhe.de/~kaage/ --

1 participants
0 comments

Re: font-menu-ignore-scaled-fonts in 21.1. and 21.2 24 years, 11 months

Jan Vroonhof

Andreas Jaeger <aj(a)suse.de> writes: > The user has font-menu-ignore-scaled-fonts set to t. Did he explicitly set that? Why? Note that the default differs in 21.2 and 21.1. > Why is that part of the code in 21.1.8 commented out? Because of 1998-08-26 Jan Vroonhof <vroonhof(a)math.ethz.ch> * menubar-items.el (default-menubar): Remove "Font Weight" option, there is currently no custom equivalent.. Customize-faces is "Edit faces". However I guess I was a bit too overzealous. > ;; (if (and (member weight (aref entry 1)) > ;; (or (member size (aref entry 2)) > ;; (and (not font-menu-ignore-scaled-fonts) > ;; (member 0 (aref entry 2))))) > ;; (enable-menu-item item) > ;; (disable-menu-item item)) > (if (and font-menu-ignore-scaled-fonts (member 0 (aref entry 2))) > (disable-menu-item item) > (enable-menu-item item)) This problem is actually a FAQ om comp.emacs.xemacs. Because I didn't see the problem when I last looked, we've just told people to set font-menu-ignore-scaled-fonts to nil as a work around. However, now that I look at it again, it is extremely trivial. I forgot the part that checked whether the size was actually available unscaled. It should be (if (and (not (member size (aref entry 2))) font-menu-ignore-scaled-fonts (member 0 (aref entry 2))) (disable-menu-item item) (enable-menu-item item)) This whole disabling thing needs a rethink anyway, since it can make it impossible to get from one family-size-weight combination to another if there is not of fonts with hamming distance 1 between them. Jan

1 participants
0 comments

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

2000

1999

1998

XEmacs-Beta January 2000