December 1998 - XEmacs-Beta - XEmacs Mailing List Archives

Re: `make-annotation' fix 27 years

Hrvoje Niksic

Adrian Aichner <aichner(a)ecf.teradyne.com> writes: > >>>>> "Hrvoje" == Hrvoje Niksic <hniksic(a)srce.hr> writes: > > Hello Hrvoje, > > your patch fixes the problem from me. > > Here is the *Backtrace* for my testcase of the (make-annotation ...) > crash: > > Signaling: > (wrong-type-argument buffer-glyph-p #<glyph (pointer) [...] Yup. This is IMO correct -- you shouldn't be able to attach a `pointer' glyph to an extent. Steve vetoed the patch for 21.2, but I find his rationale unsatisfactory.

2 participants
1 comments

Re: pcl-cvs package comments, update `request' 27 years

Adrian Aichner

>>>>> "Greg" == Greg Klanderman <greg(a)alphatech.com> writes: Greg> Adrian, Greg> I think 1.37 available from ftp.xemacs.org should be the Greg> same as the head of the repository, though I have not Greg> looked. I at least have not made a change since before the Umpf! This was a mojor cockpit error on my part. I did "List _ Install" on the local package-get-base and was surprised that there are no newer packages. Greg> date on the current package version there. Have you got Greg> 1.37 from the ftp site? I had 1.34 for installed still. The upgrade to 1.37 today gives me all the features I want. And cvs-checkout works for remote repositories now! ONE PROBLEM: pcl-cvs's and text-modes's lisp files got installed in this obscure place: c:\Program Files\XEmacs\xemacs-packages\man\lisp: total 0 drwxrwxrwx 2 AichnerA 5 0 Dec 15 14:33 . drwxrwxrwx 2 AichnerA 5 0 Dec 15 14:33 .. drwxrwxrwx 2 AichnerA 5 0 Dec 15 15:02 pcl-cvs drwxrwxrwx 2 AichnerA 5 0 Dec 15 16:20 text-modes and not in c:\Program Files\XEmacs\xemacs-packages\lisp as all the other packages I updated today. What could be the cause for this? Greg> As for the colors, they definitely need work. See the Greg> comment above the deffaces... I'll look at your suggestions Greg> when I return from vacation. Have a good vacation and thanks for the great improvements to PCL-CVS! Adrian Greg> Greg

1 participants
0 comments

Re: [CRASH] Incorrect (make-annotation ...) vaporizes XEmacsen 21.[02] 27 years

Hrvoje Niksic

Colin Rafferty <craffert(a)ms.com> writes: > Is this a bug in 19.13? I would interpret it as such. > Maybe, but I would say that 19.15+ crashing is a much worse bug. Of course. The correct action is to signal an error.

1 participants
0 comments

Re: Scrollbar issue not covered in the FAQ: left hand. 27 years

Christoph Wedler

>>>>>"Hrvoje" == Hrvoje Niksic <hniksic(a)srce.hr> writes: Hrvoje> cbarry(a)2xtreme.net (Christopher R. Barry) writes: >> Is there a way to put the vertical scrollbar(s) on the left hand >> side? I don't care what I need to do, even if it means mucking with >> the source a little. Hrvoje> You can do that with the X resources: Hrvoje> `scrollBarPlacement' (class `ScrollBarPlacement'): string Can I do something similar with the toolbar? Hrvoje> XEmacs 21 will also allow you to do the same thing with specifiers: Hrvoje> (set-specifier scrollbar-on-left-p t) Unfortunately, the corresponding thing (set-default-toolbar-position 'left) produces some annoyances in XEmacs-21.0. First, my window manager (ctwm-3.5 under X11/solaris-2.6) thinks that the size of XEmacs keeps the same (86x56) whereas the height is actually shorter. (list (window-width) (window-height)) has changed from (86 56) to (81 56). Second, after using M-x ediff-toggle-use-toolbar M-x ediff-buffers Quit Ediff session my XEmacs frame gets wider (list (window-width) (window-height)) => (86 56). - Christoph

1 participants
0 comments

NEWS and stty-erase-char 27 years

Jan Vroonhof

Shouldn't the new if char == stty-erase-char -> Backspace be in the NEWS files? Jan

1 participants
0 comments

Telnet package 27 years

Kristian Ellingsen

In XEmacs 21, 'M-x telnet' no longer works; is there a package containing this functionality, which I must download (I couldn't find anything on 'ftp.xemacs.org/pub/xemacs/packages/')? -- KRISTIAN ELLINGSEN, +47 905 13 552 http://ellingsen.home.ml.org/ http://home.telia.no/~kellings/ mailto:kellings＠online.no --A penny saved is a penny taxed.--

1 participants
0 comments

Re: vc-hooks 27 years

Jan Vroonhof

kifer(a)cs.sunysb.edu (Michael Kifer) writes: > I recall that it was decided at some point that loading vc-hooks was not > good citizenship, because it was breaking something. > What was it? pcl-cvs? No vc-hooks.el, it is/was deemed too obnoxious. > I am asking because ediff uses some functions from vc-hooks.el to determine > the version control system of a file, or if the file is checked in or out > (in case of RCS). Some version-related things in ediff don't work correctly > if vc isn't loaded, and I don't like the idea of copying functions from one > package to another. I think the solution is to not the version control stuff if vc-hooks is not loaded. The other alternative would be to make vc-hooks less obnoxious but it is difficult since it was not written to be enabled in mid flight. (Although that is currently exactly what happens when the VC menu is accessed first). Jan

1 participants
0 comments

Re: `make-annotation' fix 27 years

Colin Rafferty

Hrvoje Niksic writes: > Adrian, Colin, could you please confirm that this patch fixes the > problem? The patch disallows attaching glyphs to extents unless > glyphs are of type `buffer', which prevents the crash for me. Works for me. I get the expected error when I try to make-annotation on the pointer glyph. -- Colin

1 participants
0 comments

Re: alpha-linux build failure 27 years

Neal D. Becker

I recommend someone try building just unexelf.c with egcs-1.0, and the rest with egcs-1.1.1.

1 participants
0 comments

Re: `make-annotation' fix 27 years

Adrian Aichner

>>>>> "Hrvoje" == Hrvoje Niksic <hniksic(a)srce.hr> writes: Hello Hrvoje, your patch fixes the problem from me. Here is the *Backtrace* for my testcase of the (make-annotation ...) crash: Signaling: (wrong-type-argument buffer-glyph-p #<glyph (pointer) #<image-specifier global=(((mswindows) . [xpm :color-symbols (("foregroundToolBarColor" . #<color-specifier global=<unspecified> fallback=#<color-specifier global=<unspecified> fallback=(((mswindows) . "black")) 0x1ac> 0x1da>) ("backgroundToolBarColor" . #<color-specifier global=<unspecified> fallback=#<color-specifier global=<unspecified> fallback=(((mswindows) . "Gray75")) 0x1ae> 0x1dc>) ("background" . #<color-specifier global=<unspecified> fallback=(((mswindows) . "white")) 0x197>) ("foreground" . #<color-specifier global=<unspecified> fallback=(((mswindows) . "black")) 0x195>)) :file "c:\\Program Files\\XEmacs\\XEmacs-21.2-b5\\etc\\recycle.xpm" ...]) ((stream) . [mswindows-resource :resource-type cursor :resource-id "Wait"])) fallback=((nil . [nothing])) 0x27f>0x27e>) set-extent-begin-glyph(#<extent [267, 267) 0x1064bb84 in buffer gc-pointer-glyph-experiment.el> #<glyph (pointer) #<image-specifier global=(... ...) fallback=(...) 0x27f>0x27e> text) make-annotation(#<glyph (pointer) #<image-specifier global=(... ...) fallback=(...) 0x27f>0x27e> nil text) eval((make-annotation gc-pointer-glyph nil (quote text))) eval-interactive((make-annotation gc-pointer-glyph nil (quote text))) eval-last-sexp(nil) call-interactively(eval-last-sexp) The backtrace for Colin's and my testcase are identical for me except for the different glyphs being used. Hrvoje> Adrian, Colin, could you please confirm that this patch fixes the Hrvoje> problem? The patch disallows attaching glyphs to extents unless Hrvoje> glyphs are of type `buffer', which prevents the crash for me. Confirmed! Thanks for the patch. Adrian Hrvoje> It might still be possible to muck things up by attaching an empty Hrvoje> `buffer' glyph to an extent, and then attaching a, say, `pointer' Hrvoje> image instance object to the glyph, but I was unable to prove it. Hrvoje> 1998-12-14 Hrvoje Niksic <hniksic(a)srce.hr> Hrvoje> * extents.c (set_extent_glyph_1): Make sure that the glyph we Hrvoje> attach to the extent is valid. Hrvoje> --- src/extents.c.orig Mon Dec 14 23:08:54 1998 Hrvoje> +++ src/extents.c Mon Dec 14 23:17:45 1998 Hrvoje> ＠＠ -5009,10 +5009,10 ＠＠ Hrvoje> EXTENT extent = decode_extent (extent_obj, DE_MUST_HAVE_BUFFER); Hrvoje> glyph_layout layout = symbol_to_glyph_layout (layout_obj); Hrvoje> - /* Make sure we've actually been given a glyph or it's nil (meaning Hrvoje> - we're deleting a glyph from an extent). */ Hrvoje> + /* Make sure we've actually been given a valid glyph or it's nil Hrvoje> + (meaning we're deleting a glyph from an extent). */ Hrvoje> if (!NILP (glyph)) Hrvoje> - CHECK_GLYPH (glyph); Hrvoje> + CHECK_BUFFER_GLYPH (glyph); Hrvoje> set_extent_glyph (extent, glyph, endp, layout); Hrvoje> return glyph;

1 participants
0 comments

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

2000

1999

1998

XEmacs-Beta December 1998