Re: [Q] Re: bug and region patch for diff-reverse-direction in diff-mode.el
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2005 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2004 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2003 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2002 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2001 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2000 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1999 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1998 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
On Sun, 2002-04-07 at 20:18, James LewisMoss wrote:
>> So I accidentally hit M-R in diff mode and it attempted to
reverse
>> the patch, but it didn't take into account the --- and +++ and
>> just swapped the first chars making +-- and -++. Which afaik
>> isn't a valid patch. While I was messing with
>> diff-reverse-direction I noticed that it only works on the region
>> when you give it a prefix arg which is not what I've come to
>> expect. So here's the patch:
[...]
Ville> I would appreciate it if you could test if the CVS version
(or
Ville> when an experimental prog-modes package is available, that)
Ville> still has this bug, and post an updated patch if it does.
OK. Checked out the "packages" project from xemacs cvs. Here's an
updated patch. I tested the diff-mode.el from cvs for the same bug
and it's still there. Please use the changelog entry from the last
message it's still appropriate.
[...]
Thanks again, the patch applies ok now. However, I could not reproduce
the problem you described with the non-patched diff-mode, though I only
tried with the patch you sent for it. OTOH, the patch didn't seem to
break anything.
If possible, I'd like to see a sample diff/patch where the problem
occurs; could you send me one (and Cc: xemacs-beta(a)xemacs.org)?
I'll put your diff-mode patch on hold for this.
Additionally, since the XEmacs diff-mode.el is now essentially same as
the GNU Emacs 21.2 one, I suspect they might have these problems too,
and think they'd be grateful for a patch as well :)
Cheers,
--
Ville Skyttä
ville.skytta(a)xemacs.org
James LewisMoss
Sunday, 7 April
Sun, 7 Apr
8:43 p.m.
New subject: [Q] Re: bug and region patch for diff-reverse-direction in diff-mode.el
>>>> On 07 Apr 2002 21:09:35 +0300, Ville Skyttä
<ville.skytta(a)xemacs.org> said:
Ville> On Sun, 2002-04-07 at 20:18, James LewisMoss wrote:
> >> So I accidentally hit M-R in diff mode and it attempted
to
> >> reverse the patch, but it didn't take into account the --- and
> >> +++ and just swapped the first chars making +-- and -++. Which
> >> afaik isn't a valid patch. While I was messing with
> >> diff-reverse-direction I noticed that it only works on the
> >> region when you give it a prefix arg which is not what I've
> >> come to expect. So here's the patch:
Ville> [...]
Ville> I would appreciate it if you could test if the CVS version (or
Ville> when an experimental prog-modes package is available, that)
Ville> still has this bug, and post an updated patch if it does.
>
> OK. Checked out the "packages" project from xemacs cvs. Here's
> an updated patch. I tested the diff-mode.el from cvs for the same
> bug and it's still there. Please use the changelog entry from the
> last message it's still appropriate.
Ville> [...]
Ville> Thanks again, the patch applies ok now. However, I could not
Ville> reproduce the problem you described with the non-patched
Ville> diff-mode, though I only tried with the patch you sent for it.
Ville> OTOH, the patch didn't seem to break anything.
I've attached the patch file I tested it with. It's a portion of the
.diff.gz generated for a debian package.
Ville> If possible, I'd like to see a sample diff/patch where the
Ville> problem occurs; could you send me one (and Cc:
Ville> xemacs-beta(a)xemacs.org)? I'll put your diff-mode patch on
Ville> hold for this.
Ville> Additionally, since the XEmacs diff-mode.el is now essentially
Ville> same as the GNU Emacs 21.2 one, I suspect they might have
Ville> these problems too, and think they'd be grateful for a patch
Ville> as well :)
Is the author in diff-mode.el an appropriate place to send it?
Jim
--
＠James LewisMoss <dres(a)debian.org> | Blessed Be!
＠ http://jimdres.home.mindspring.com | Linux is kewl!
＠"Argue for your limitations and sure enough, they're yours." Bach
Ville Skyttä
Monday, 8 April
Mon, 8 Apr
10:30 p.m.
New subject: [Q] Re: bug and region patch for diff-reverse-direction in diff-mode.el
On Sun, 2002-04-07 at 22:43, James LewisMoss wrote:
[...]
Ville> If possible, I'd like to see a sample diff/patch where
the
Ville> problem occurs; could you send me one (and Cc:
Ville> xemacs-beta(a)xemacs.org)? I'll put your diff-mode patch on
Ville> hold for this.
Ok, I'm convinced and confused, seems like I screw up something when
previously testing the patch. Anyway, I got the problem reproduced and
saw your patch fixing it, I'm committing it in a minute. Thanks.
Ville> Additionally, since the XEmacs diff-mode.el is now
essentially
Ville> same as the GNU Emacs 21.2 one, I suspect they might have
Ville> these problems too, and think they'd be grateful for a patch
Ville> as well :)
Is the author in diff-mode.el an appropriate place to send it?
I'm not sure, there's no mention about the maintainer of the mode. But
I guess the author won't mind, and a Cc: to <bug-gnu-emacs(a)gnu.org>
would be a good idea.
Cheers,
--
Ville Skyttä
ville.skytta(a)xemacs.org
8258
days inactive
8259
days old
2 comments
2 participants
tags (0)
participants (2)
-
James LewisMoss -
Ville Skyttä