Re: [C] [S] Re: [PATCH] packages: random indentation and typo fix
22 years
Norbert Koch
Norbert Koch
Adrian Aichner <adrian(a)xemacs.org> writes:
> So I am attaching it here again (unmodified) as text/plain.
Still no cigar. But I looked at the actual diff in CVS which displays
the changes in all their glory :)
Thanks,
norbert.
- 2 participants
- 1 comments
Re: typo fix patches for mode-compile.el 2.28 (soon to go into XEmacs)
22 years
Adrian Aichner
Adrian Aichner
>>>>> "robert" == robert delius royar <xemacs(a)frinabulax.org> writes:
robert> On Sun, 1 Jun 2003 about 12:00 +0200 UTC Adrian Aichner wrote:
>>
>> Hello Heddy,
robert> Just butting in.
Hi Robert!
>> * mode-compile.el (mode-compile-prefered-default-makerule): Removed.
>> * mode-compile.el (mode-compile-preferred-default-makerule): New.
>> Retaining compatibility via `define-obsolete-variable-alias'.
>> * mode-compile.el (mode-compile-choosen-compiler): Ditto.
robert> How about mode-compile-chosen-compiler
robert> with
robert> Retaining compatibility via `define-obsolete-variable-alias'.
I must be missing some subtleties.
Lemme guess:
You are suggesting mode-compile-chosen-compiler would be a better name
for the variable?
My goal for this patch was two-fold:
Sync with latest author-version 2.28.
Fix all typos I could find (that's why the variable was renamed).
My patch was approved and just went in.
Heddy seems to have fallen out of the net.
Google does not find his web page.
My mail to him bounced.
I don't want to get involved in variable renaming discussions for
externally maintained packages.
Seems to be a thankless job.
Fixing errors is what I will never shy away from.
Best regards,
Adrian
robert> Perhaps I missed it in the patch.
robert> --
robert> Dr. Robert Delius Royar Associate Professor of English
robert> Morehead State University Morehead, Kentucky
robert> Kill UGLY Corporate Radio
robert> Mistakes live in the neighbourhood of truth and therefore delude us.
robert> -Rabindranath Tagore
robert> 7:59AM up 5 days, 12:45, 2 users, load averages: 0.12, 0.05, 0.08
Robert, you've been up way too long, get some sleep :-)
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
- 1 participants
- 0 comments
[C] Re: [A] Re: [PATCH] packages: Sync prog-modes/mode-compile.el with author version 2.28
22 years
Adrian Aichner
Adrian Aichner
COMMIT
>>>>> "Norbert" == Norbert Koch <viteno(a)xemacs.org> writes:
Norbert> APPROVE
Norbert> Adrian Aichner <adrian(a)xemacs.org> writes:
Norbert> Hi!
>> Heddy seems to be unplugged from the world, according to Google.
>>
>> Nonetheless, we can get back in sync with his latest version and make
>> some quality improvements.
>> Can commit if asked when I come back from a swim.
Norbert> do so, dry your fingers first ... that'll make your
Norbert> keyboard happy :-)
Oops, read this too late (after touching the keyboard); spent an hour
drying the keyboard.
Norbert> One question though: is it preferred style to use 'block
Norbert> mode' in descriptive comments? IMHO, lines like
Not really, but in case Heddy returns it's better to be in sync IMO.
I am commiting as is for now.
Best regards,
Adrian
Norbert> ;; for the rule to run, see variable
Norbert> ;; `mode-compile-preferred-default-makerule' to see how a default choice
Norbert> ;; could be selected).
Norbert> simply suck.
Yes, more than Microsoft vacuum cleaners ever will.
Norbert> Thanks,
Norbert> norbert.
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
- 1 participants
- 0 comments
Re: [Q] Re: [PATCH] packages: random indentation and typo fix
22 years
Adrian Aichner
Adrian Aichner
>>>>> "Norbert" == Norbert Koch <viteno(a)xemacs.org> writes:
Norbert> QUERY
Norbert> Adrian Aichner <Adrian.Aichner(a)t-online.de> writes:
Norbert> Adrian,
Norbert> are you sure you got the correct patch wrt edebug? It
Norbert> contains no real changes. After applying it, I don't get
These are whitespace fixes.
Are you ignoring WS diffs by any chance?
Please advise,
Adrian
Norbert> any differences running C-v = on the buffer (as I would
Norbert> have expected from the patch's look).
Norbert> [...]
>> + * edebug.el (edebug-mode-menus): Indentation fix.
Norbert> You may commit the fix to Local.rules.template, though,
Norbert> if you want to split them.
Norbert> Thanks,
Norbert> norbert.
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
- 1 participants
- 0 comments