[Moved from xemacs-patches to xemacs-beta; that's the correct
Ville Skyttä wrote:
> When using this image-mode.el, starting up XEmacs spits out messages to
> the console like these:
> Loading image-mode...
> Loading image-mode...done
> I wonder if this could be avoided somehow?
I don't know; I have no idea why it would do this if other modes don't.
> The new mode breaks XEmacs 21.1.14. This is because there are
> references to (at least these) functions you've removed in the new mode
> in lisp/format.el: image-decode-jpeg, image-decode-gif,
> image-decode-png, image-decode-xpm, image-decode-tiff,
> image-decode-tiff. As Stephen already noted, these have been removed in
> newer XEmacsen. Some `define-obsolete-function-alias'es or wrappers to
> `image-decode' would be needed, since packages need to work with XEmacs
> 21.1 and newer at the moment.
I can put those functions back in, although I have no idea whether it
will work correctly (presumably image-decode would end up being called
twice; once via format-alist, and once from image-mode).
A better fix might be for image-mode-install to just remove the
entries from format-alist; IIRC, the consensus was that they shouldn't
have been there in the first place.
> Finally, a small nit:
> > ;;;###autoload
> > (defun image-mode-install ()
> > (dolist (format image-formats-alist)
> > (let* ((re (car format))
> > (type (cdr format))
> > (regexp (concat "\\.\\(" re "\\|" (upcase re) "\\)\\'"))
> > (item (cons regexp 'image-mode)))
> > (and (featurep type)
> > (not (member item auto-mode-alist))
> > (push item auto-mode-alist)))))
> I guess the last chunk could use `add-to-list', something like:
> (and (featurep type) (add-to-list 'auto-mode-alist item))
OK; I'll change that.
Glynn Clements <glynn.clements(a)virgin.net>