October 1999 - XEmacs-Beta - XEmacs Mailing List Archives

Robert Bresner

Hey there... Using the precompiled binary kit for NT (4.0 SP5), I downloaded and installed both: xemacs-21_1_3-i686-pc-cygwin32-b20_1-X_tar.tar.gz and xemacs-21_1_3-i686-pc-cygwin32-b20_1_tar.tar.gz typical un-tarring and running didn't work: Couldn't find an obvious default for the root of the XEmacs hierarchy. WARNING: Couldn't find obvious defaults for: doc-directory data-directory exec-directory Perhaps some directories don't exist, or the XEmacs executable, /XEmacs-21.1.3/bin/xemacs.exe is in a strange place?Cannot open load file: /build/xemacs/xemacs-20/lisp/auto-autoloads So I set the various emacs xxxPATH env vars to what seemed like the right thing to me, and I still got that same message. So I rearranged the hierarchy to match the GNU NTEmacs hierarchy, and changed the xxxPATH vars and tried again, and now I get nothing. No error messages, but xemacs simply doesn't run. Here's how I've got things currently set-up. Directory of D:\XEmacs-21.1.3 bin etc custom eos idd photos sounds sparcworks tests external-widget toolbar info lib xemacs-21.1-p3 i686-pc-cygwin32 lisp man lock --- runxemacs.bat ( mostly from my gnu NT emacs startup .bat file ) set emacs_dir=D:\XEmacs-21.1.3 set SHELL=%emacs_dir%\bin\cmdproxy.exe set EMACSLOADPATH=%emacs_dir%\site-lisp;%emacs_dir%\lisp set EMACSDATA=%emacs_dir%\etc set EMACSPATH=%emacs_dir%\bin set EMACSLOCKDIR=%emacs_dir%\lock REM set INFOPATH=%emacs_dir%\info set EMACSDOC=%emacs_dir%\etc set TERM=CMD set HOME=%emacs_dir% ＠echo Using HOME = %HOME% %emacs_dir%\bin\runemacs.exe %* ===================================================== So, when I run that .bat file, I get a beep from the speakers, but no emacs. runemacs.exe doesn't even live long enough to show up on my task manager. Is there something else I need to setup, or a different hierarchy I should be using? I performed the same steps with both tarballs I downloaded. I assumed the -X version required an NT X Server, which I don't have, so I did that one a tad less enthusiastically, but did eventually get the same results... no emacs running. Anyone out there get XEmacs running on NT, I'd really appreciate the help. ---------------------------------------- Robert Bresner rbresner(a)olf.com Open Link Financial 516-227-6600 x216 http://www.olf.com/ fax: 516-227-1799 ---------------------------------------- Opinions expressed are explicitly my own "The more times you run over a dead cat, the flatter it gets." -- Russian Proverb

3 participants
2 comments

Re: Patches Applied for 21.1.8 26 years

Adrian Aichner

>>>>> "Craig" == Craig Lanning <CraigL(a)DyCon.com> writes: Craig> I'm afraid not :-( Sad hear. I'm still confident I fixed part of the problem. >> Let me guess that you are NOT building with USE_UNION_TYPE. Well, I am. Craig> That is correct. >> >> My fix for this is: cp-> pid = XINT(make_int(cp->pid)); Craig> Your patch below did not include this line. After I tried Craig> the patch and found that it failed, I was composing my Craig> response to your message and realized that this line wasn't Craig> in the patch. So I added it after the line Sorry, above line should not be required in C land. Craig> /* pid must fit in a Lisp_Int */ Craig> in ntproc.c. Unfortunately, that did not help :-( Craig> Below I have included the results of the first two test cases. Craig> Fatal error: assertion failed, file sysdep.c, line 353, pid != NULL Craig> [then XEmacs died] XEmacs dies because of the failing assert(), You can let it live by converting the assert to a stderr_out ("wait_for_termination got NULL pid\n"); Craig, if you have a debugger, could you set a breakpoint on the assert and send me the callstack when it gets there? Regards, Adrian

3 participants
2 comments

Re: Announcements 26 years

Adrian Aichner

>>>>> "Jason" == Jason R Mastaler <jason(a)xemacs.org> writes: Jason> sperber(a)informatik.uni-tuebingen.de (Michael Sperber [Mr. Preprocessor]) writes: >> *WHY* are we not putting minor release announcements (like the >> Windows binary kit) on comp.emacs.xemacs and comp.emacs? (And >> possibly gnu.announce?) Jason> One thing we could do is have all xemacs-announce messages Jason> automatically go to comp.emacs.xemacs like they go to Jason> xemacs-beta. What do people think about this idea? I like it. Adrian

1 participants
0 comments

Re: Patches Applied for 21.1.8 26 years

Adrian Aichner

>>>>> "Craig" == Craig Lanning <CraigL(a)DyCon.com> writes: Craig> create_child: exe=c:\BIN32\ls.exe,cmdline=c:\BIN32\ls.exe Craig> create_child.CreateProcess leads child PID -725391, Craig> changing to PID 725391 Fatal error: assertion failed, file Craig> sysdep.c, line 353, pid != NULL Hi Craig, did you ever see a message like: Fcall_process_internal.child_setup returns PID 725391, using PID -725391 If not, then if (os_subtype == OS_WIN95) would not be true for Windows 98. That would be a problem! Please let me know. Adrian

2 participants
1 comments

Re: Patches Applied for 21.1.8 26 years

Adrian Aichner

>>>>> "Craig" == Craig Lanning <CraigL(a)DyCon.com> writes: Craig, I'm confident I found the problem. If so, then it's not related to 95/98 vs. NT. Let me guess that you are NOT building with USE_UNION_TYPE. Well, I am. The PID you got below was odd, which is even more evidence. create_child does a bad thing: #ifdef USE_UNION_TYPE cp->pid = (cp->pid & ((1U << VALBITS) - 1)); #else cp->pid = (cp->pid & VALMASK); #endif VALMASK, however, is a shifted mask already. It makes all PIDs even! lisp-disunion.h:82:#define VALMASK (((1UL << VALBITS) - 1UL) << GCTYPEBITS) My fix for this is: cp->pid = XINT(make_int(cp->pid)); Please apply following patch and try this extended test case. Thanks for hanging in there with me! Adrian ;;; ;;; Test cases ;;; (call-process "ls" nil '(t t) nil "c:\\") AUTOEXEC.BAT <lines deleted by Adrian> tmp 0 (call-process "ls" nil '(t t) nil "c:\\no-way-you-have-this") /cygnus/cygwin-b20/H-i586-cygwin32/bin/ls.exe: c:\no-way-you-have-this: No such file or directory 1 If you have grep, these would be nice to know: ;;; Looking for drivers in sysem file succeeds, returning 0. (apply 'call-process "grep" nil nil nil (list "drivers" "c:\\winnt\\system.ini")) 0 ;;; Looking for passangers in sysem file fails, returning 1. (apply 'call-process "grep" nil nil nil (list "passangers" "c:\\winnt\\system.ini")) 1 ;;; Looking for drivers in invalid file fails, returning 2. (apply 'call-process "grep" nil nil nil (list "drivers" "c:\winnt\system.ini")) 2 ;;; How about minitar, does IT work? (call-process "d:\\tmp\\21.2\\xemacs\\nt\\minitar.exe" nil '(t t) nil) Usage: d:\tmp\21.2\xemacs\nt\minitar.exe file.tar.gz [base-dir] Extracts the contents compressed tar file to base-dir -1 Craig> (call-process "ls" nil '(t t) nil "c:\\") Craig> create_child: exe=c:\BIN32\ls.exe,cmdline=c:\BIN32\ls.exe Craig> create_child.CreateProcess leads child PID -725391, Craig> changing to PID 725391 Fatal error: assertion failed, file Craig> sysdep.c, line 353, pid != NULL Craig> saw no output and XEmacs locked up. Craig> Craig Patch against 21.2-b19: cd d:\tmp\21.2\xemacs\src\ cvs diff Compilation started at Fri Oct 22 14:57:00 1999 +0200 (W. Europe Daylight Time) ? call-process.patch ? call-process.txt ? cvs-diff ? depend-of-make-src-depend ? Installation ? it ? runxemacs.pdb ? sysdep.c.good ? temacs.bsc ? temacs.ilk ? temacs.map ? temacs.pdb ? waitpid.txt ? xemacs.opt cvs server: Diffing . Index: callproc.c =================================================================== RCS file: /usr/CVSroot/XEmacs/xemacs/src/callproc.c,v retrieving revision 1.29.2.6 diff -u -r1.29.2.6 callproc.c --- callproc.c 1999/05/01 05:13:23 1.29.2.6 +++ callproc.c 1999/10/22 13:05:46 ＠＠ -45,6 +45,7 ＠＠ #define _P_NOWAIT 1 /* from process.h */ #include <windows.h> #include "nt.h" +#include "ntheap.h" #endif #ifdef DOS_NT ＠＠ -107,22 +108,33 ＠＠ if (!call_process_exited && EMACS_KILLPG (pid, SIGINT) == 0) - { - int speccount = specpdl_depth (); + { + int speccount = specpdl_depth (); - record_unwind_protect (call_process_kill, fdpid); - /* #### "c-G" -- need non-consing Single-key-description */ - message ("Waiting for process to die...(type C-g again to kill it instantly)"); + record_unwind_protect (call_process_kill, fdpid); + /* #### "c-G" -- need non-consing Single-key-description */ + message ("Waiting for process to die...(type C-g again to kill it instantly)"); - wait_for_termination (pid); +#ifdef WINDOWSNT + if (os_subtype == OS_WIN95) + { + wait_for_termination (OpenProcess(PROCESS_ALL_ACCESS, 0, -pid)); + } + else + { + wait_for_termination (OpenProcess(PROCESS_ALL_ACCESS, 0, pid)); + } +#else + wait_for_termination (pid); +#endif - /* "Discard" the unwind protect. */ - XCAR (fdpid) = Qnil; - XCDR (fdpid) = Qnil; - unbind_to (speccount, Qnil); + /* "Discard" the unwind protect. */ + XCAR (fdpid) = Qnil; + XCDR (fdpid) = Qnil; + unbind_to (speccount, Qnil); - message ("Waiting for process to die... done"); - } + message ("Waiting for process to die... done"); + } synch_process_alive = 0; close (fd); return Qnil; ＠＠ -170,6 +182,9 ＠＠ Lisp_Object infile, buffer, current_dir, display, path; int fd[2]; int filefd; +#ifdef WINDOWSNT + HANDLE pHandle; +#endif int pid; char buf[16384]; char *bufptr = buf; ＠＠ -358,7 +373,21 ＠＠ fork_error = Qnil; #ifdef WINDOWSNT pid = child_setup (filefd, fd1, fd_error, new_argv, - (char *) XSTRING_DATA (current_dir)); + (char *) XSTRING_DATA (current_dir)); + /* OpenProcess() as soon after child_setup as possible. It's too + late once the process terminated. */ + if (os_subtype == OS_WIN95) + { + stderr_out ("Fcall_process_internal.child_setup returns PID %d, using PID %d\n", pid, -pid); + /* create_child() in ntproc.c hacks PIDs for OS_WIN95 to fit + into Lisp_Int, i.e. negates them. Hence we have to use -pid + to get at the real PID for OS_WIN95. */ + pHandle = OpenProcess(PROCESS_ALL_ACCESS, 0, -pid); + } + else + { + pHandle = OpenProcess(PROCESS_ALL_ACCESS, 0, pid); + } #else /* not WINDOWSNT */ pid = fork (); ＠＠ -435,8 +464,8 ＠＠ #ifdef FILE_CODING instream = make_decoding_input_stream - (XLSTREAM (instream), - Fget_coding_system (Vcoding_system_for_read)); + (XLSTREAM (instream), + Fget_coding_system (Vcoding_system_for_read)); Lstream_set_character_mode (XLSTREAM (instream)); #endif NGCPRO1 (instream); ＠＠ -470,15 +499,16 ＠＠ break; #ifdef DOS_NT - /* Until we pull out of MULE things like - make_decoding_input_stream(), we do the following which is - less elegant. --marcpa */ - { - int lf_count = 0; - if (NILP (Vbinary_process_output)) { - nread = crlf_to_lf(nread, bufptr, &lf_count); - } - } + /* Until we pull out of MULE things like + make_decoding_input_stream(), we do the following which is + less elegant. --marcpa */ + { + int lf_count = 0; + if (NILP (Vbinary_process_output)) + { + nread = crlf_to_lf(nread, bufptr, &lf_count); + } + } #endif total_read += nread; ＠＠ -507,7 +537,11 ＠＠ QUIT; /* Wait for it to terminate, unless it already has. */ +#ifdef WINDOWSNT + wait_for_termination (pHandle); +#else wait_for_termination (pid); +#endif /* Don't kill any children that the subprocess may have left behind when exiting. */ Index: ntproc.c =================================================================== RCS file: /usr/CVSroot/XEmacs/xemacs/src/ntproc.c,v retrieving revision 1.14.2.10 diff -u -r1.14.2.10 ntproc.c --- ntproc.c 1999/10/10 12:40:13 1.14.2.10 +++ ntproc.c 1999/10/22 13:07:17 ＠＠ -304,14 +304,14 ＠＠ read anything for them to consume yet! */ /* - if (cp == NULL || - WaitForSingleObject (cp->char_consumed, INFINITE) != WAIT_OBJECT_0) + if (cp == NULL || + WaitForSingleObject (cp->char_consumed, INFINITE) != WAIT_OBJECT_0) */ if (cp == NULL) - { + { return 1; - } + } for (;;) { ＠＠ -329,28 +329,31 ＠＠ } if (rc == STATUS_READ_ERROR) - { - /* We are finished, so clean up handles and set to NULL so - that CHILD_ACTIVE will see what is going on */ - if (cp->char_avail) { - CloseHandle (cp->char_avail); - cp->char_avail = NULL; - } - if (cp->thrd) { - CloseHandle (cp->thrd); - cp->thrd = NULL; - } - if (cp->char_consumed) { - CloseHandle(cp->char_consumed); - cp->char_consumed = NULL; - } - if (cp->procinfo.hProcess) - { - CloseHandle (cp->procinfo.hProcess); - cp->procinfo.hProcess=NULL; - } - return 1; - } + { + /* We are finished, so clean up handles and set to NULL so + that CHILD_ACTIVE will see what is going on */ + if (cp->char_avail) + { + CloseHandle (cp->char_avail); + cp->char_avail = NULL; + } + if (cp->thrd) + { + CloseHandle (cp->thrd); + cp->thrd = NULL; + } + if (cp->char_consumed) + { + CloseHandle(cp->char_consumed); + cp->char_consumed = NULL; + } + if (cp->procinfo.hProcess) + { + CloseHandle (cp->procinfo.hProcess); + cp->procinfo.hProcess=NULL; + } + return 1; + } /* If the read died, the child has died so let the thread die */ if (rc == STATUS_READ_FAILED) ＠＠ -366,23 +369,26 ＠＠ } /* We are finished, so clean up handles and set to NULL so that CHILD_ACTIVE will see what is going on */ - if (cp->char_avail) { - CloseHandle (cp->char_avail); - cp->char_avail = NULL; - } - if (cp->thrd) { - CloseHandle (cp->thrd); - cp->thrd = NULL; - } - if (cp->char_consumed) { - CloseHandle(cp->char_consumed); - cp->char_consumed = NULL; - } + if (cp->char_avail) + { + CloseHandle (cp->char_avail); + cp->char_avail = NULL; + } + if (cp->thrd) + { + CloseHandle (cp->thrd); + cp->thrd = NULL; + } + if (cp->char_consumed) + { + CloseHandle(cp->char_consumed); + cp->char_consumed = NULL; + } if (cp->procinfo.hProcess) - { - CloseHandle (cp->procinfo.hProcess); - cp->procinfo.hProcess=NULL; - } + { + CloseHandle (cp->procinfo.hProcess); + cp->procinfo.hProcess=NULL; + } return 0; } ＠＠ -448,16 +454,15 ＠＠ /* Hack for Windows 95, which assigns large (ie negative) pids */ if (cp->pid < 0) cp->pid = -cp->pid; - /* pid must fit in a Lisp_Int */ -#ifdef USE_UNION_TYPE - cp->pid = (cp->pid & ((1U << VALBITS) - 1)); -#else - cp->pid = (cp->pid & VALMASK); -#endif + + if (cp->pid > EMACS_INT_MAX) { + stderr_out ("create_child.CreateProcess abs(PID) %d > EMACS_INT_MAX (%d)\n", + cp->pid, EMACS_INT_MAX); + } *pPid = cp->pid; - + return TRUE; EH_Fail: Index: sysdep.c =================================================================== RCS file: /usr/CVSroot/XEmacs/xemacs/src/sysdep.c,v retrieving revision 1.32.2.7 diff -u -r1.32.2.7 sysdep.c --- sysdep.c 1999/07/05 05:56:44 1.32.2.7 +++ sysdep.c 1999/10/22 13:08:31 ＠＠ -234,8 +234,11 ＠＠ #endif /* NO_SUBPROCESSES */ -void -wait_for_termination (int pid) +#ifdef WINDOWSNT +void wait_for_termination (HANDLE pid) +#else +void wait_for_termination (int pid) +#endif { /* #### With the new improved SIGCHLD handling stuff, there is much less danger of race conditions and some of the comments below ＠＠ -345,6 +348,43 ＠＠ Since implementations may add their own error indicators on top, we ignore it by default. */ +#elif defined (WINDOWSNT) + int ret = 0, status = 0; + assert (pid != NULL); + do + { + QUIT; + ret = WaitForSingleObject(pid, 100); + } + while (ret == WAIT_TIMEOUT); + if (ret == WAIT_FAILED) + { + stderr_out ("wait_for_termination.WaitForSingleObject returns %d (WAIT_FAILED) GetLastError () %d for pid %d\n", ret, GetLastError (), (int)pid); + } + if (ret == WAIT_ABANDONED) + { + stderr_out ("wait_for_termination.WaitForSingleObject returns %d (WAIT_ABANDONED) GetLastError () %d for pid %d\n", ret, GetLastError (), (int)pid); + } + if (ret == WAIT_OBJECT_0) + { + ret = GetExitCodeProcess(pid, &status); + if (ret) + { + synch_process_alive = 0; + synch_process_retcode = status; + } + else + { + /* GetExitCodeProcess() didn't return a valid exit status, + nothing to do. APA */ + stderr_out ("wait_for_termination.GetExitCodeProcess status %d GetLastError () %d for pid %d\n", status, GetLastError (), (int)pid); + } + } + if (!CloseHandle(pid)) + { + stderr_out ("wait_for_termination.CloseHandle GetLastError () %d for pid %d\n", + GetLastError (), (int)pid); + } #elif defined (EMACS_BLOCK_SIGNAL) && !defined (BROKEN_WAIT_FOR_SIGNAL) && defined (SIGCHLD) while (1) { ＠＠ -376,7 +416,7 ＠＠ Try defining BROKEN_WAIT_FOR_SIGNAL. */ EMACS_WAIT_FOR_SIGNAL (SIGCHLD); } -#else /* not HAVE_WAITPID and (not EMACS_BLOCK_SIGNAL or BROKEN_WAIT_FOR_SIGNAL) */ +#else /* not HAVE_WAITPID and not WINDOWSNT and (not EMACS_BLOCK_SIGNAL or BROKEN_WAIT_FOR_SIGNAL) */ /* This approach is kind of cheesy but is guaranteed(?!) to work for all systems. */ while (1) ＠＠ -578,7 +618,11 ＠＠ static void sys_subshell (void) { +#ifdef WINDOWSNT + HANDLE pid; +#else int pid; +#endif struct save_signal saved_handlers[5]; Lisp_Object dir; unsigned char *str = 0; ＠＠ -617,7 +661,7 ＠＠ xyzzy: #ifdef WINDOWSNT - pid = -1; + pid = NULL; #else /* not WINDOWSNT */ pid = fork (); ＠＠ -651,7 +695,7 ＠＠ #ifdef WINDOWSNT /* Waits for process completion */ pid = _spawnlp (_P_WAIT, sh, sh, NULL); - if (pid == -1) + if (pid == NULL) write (1, "Can't execute subshell", 22); #else /* not WINDOWSNT */ Index: sysdep.h =================================================================== RCS file: /usr/CVSroot/XEmacs/xemacs/src/sysdep.h,v retrieving revision 1.11.2.1 diff -u -r1.11.2.1 sysdep.h --- sysdep.h 1998/12/05 16:56:31 1.11.2.1 +++ sysdep.h 1999/10/22 13:08:38 ＠＠ -48,7 +48,12 ＠＠ /* Wait for subprocess with process id `pid' to terminate and make sure it will get eliminated (not remain forever as a zombie) */ +#ifdef WINDOWSNT +#include <windows.h> +void wait_for_termination (HANDLE pid); +#else void wait_for_termination (int pid); +#endif /* flush any pending output * (may flush input as well; it does not matter the way we use it) cvs server: Diffing m cvs server: Diffing s Compilation exited abnormally with code 1 at Fri Oct 22 15:00:31

2 participants
1 comments

Attention: Vin Shelton <acs@xemacs.org> 26 years

Justin Vallon

[Sorry about the bandwidth] Your mail bounced: The original message was received at Fri, 22 Oct 1999 10:05:39 -0400 (EDT) from user-2ive0ns.dialup.mindspring.com [165.247.2.252] ----- The following addresses had permanent fatal errors ----- <acs(a)xemacs.org> ----- Transcript of session follows ----- ... while talking to mail.xemacs.org.: >>> RCPT To:<acs＠xemacs.org> <<< 550 ... User unknown 550 ... User unknown -- -Justin vallon(a)mindspring.com

1 participants
0 comments

Re: Patches Applied for 21.1.8 [includes essential pathc] 26 years

Jan Vroonhof

Gunnar Evermann <ge204(a)eng.cam.ac.uk> writes: > For example I consider it extremely rude of our users to send us those > stupid bug reports concerning Fskip_syntax_backward crashes despite > the unambiguous note in PROBLEMS You could of course consider it rude of us that we don't set flag in configure (I would prefer a "Sorry compiler too broken! Abort"). Note also that a lot of users do not have access to the PROBLEMS file. > and the fact that it has been discussed to death in c.e.x. Treating usenet as read-only medium is rude. Amen Jan

1 participants
0 comments

Re: Patches Applied for 21.1.8 26 years

Adrian Aichner

>>>>> "Craig" == Craig Lanning <CraigL(a)DyCon.com> writes: Craig> At 01:44 PM 10/21/99 +0200, Adrian Aichner wrote: >>>>>>> "APA" == Adrian Aichner <aichner(a)ecf.teradyne.com> writes: >> >> Hello All, >> APA> It works nicely on NT, but 95/98 needs investigation. APA> I'll try to work this out with Craig Lanning. >> >> could any of you with access to Windows95 or Windows98 please try >> following patch against 21.2-b19, please? Craig> It still doesn't work. >> I'll try to make a patch in time for 21.1.8 then. >> >> Please send me back any output XEmacs produced on STDERR (it will go >> to the DOS box, if you start XEmacs from there). Craig> That output is shown right after the (call-process ...) call. >> Please report output and errors for these test-cases: >> >> Here is what I get on Windows NT: >> >> (call-process "cmd" nil '(t t) nil) >> Microsoft(R) Windows NT(TM) >> (C) Copyright 1985-1996 Microsoft Corp. Craig> Win98 doesn't have "cmd". Sorry, I wasn't thinking. >> d:\Users\AichnerAd\tmp\J750> >> (call-process "command" nil '(t t) nil) >> Spawning child process: Exec format error Craig> I get the same error. This is documented in nt\PROBLEMS BTW: Is "minitar.exe" a 16bit application? >> (call-process "dir" nil '(t t) nil "c:\\") >> AUTOEXEC.BAT READER5 cygnus notes >> Acrobat3 RECYCLER enscript ntldr >> CONFIG.SYS Real ffastun.ffa pagefile.sys >> I386 TEMP ffastun.ffl pali.pl >> IO.SYS WINNT ffastun.ffo perl >> MSDOS.SYS XEmacs ffastun0.ffx perl.old >> Multimedia\ Files Xemacs.zip gcisdn telnet.log >> NTDETECT.COM autosave gnuserv-2_1p1 tmp >> NTRESKIT boot.ini gstools >> Program\ Files cvs mks Craig> "dir" is a built-in command of the "command" shell. Craig> Therefore, this gives the same error as "command" above. Craig> I then tried an "ls" command that I have: Craig> (call-process "ls" nil '(t t) nil "c:\\") Craig> create_child: exe=c:\BIN32\ls.exe,cmdline=c:\BIN32\ls.exe Craig> create_child.CreateProcess leads child PID -725391, changing to PID 725391 Craig> Fatal error: assertion failed, file sysdep.c, line 353, pid != NULL Craig> saw no output and XEmacs locked up. Ah, this is what I was looking for. The problem must occur in the maipulation of cp->pid afterwards. I'll work on another patch. Regards, Adrian Craig> Craig

2 participants
1 comments

Re: Patches Applied for 21.1.8 [includes essential pathc] 26 years

Vin Shelton

Here is the patch I applied to INSTALL. 1999-10-22 Vin Shelton <acs(a)xemacs.org> * INSTALL: Added more information about README.packages, and re-numbered some bullets. --- INSTALL.~2~ Thu Oct 21 17:39:26 1999 +++ INSTALL Fri Oct 22 08:14:47 1999 ＠＠ -89,6 +89,11 ＠＠ More information and suggestions for which packages to install see the file README.packages. +IMPORTANT! The file README.packages contain information vital to have +a fully working XEmacs. This information was not included in this file +only because it is too large for this terse INSTALL. Please read +README.packages now! + By default, packages will be searched for in the path ~/.xemacs::$prefix/lib/xemacs-${version}/mule-packages:$prefix/lib/xemacs/mule-packages:$prefix/lib/xemacs-${version}/xemacs-packages:$prefix/lib/xemacs/xemacs-packages ＠＠ -401,7 +406,7 ＠＠ same configuration. If `configure' exits with an error after disturbing the status quo, it removes `config.status'. -4) Look at `./lisp/paths.el'; if some of those values are not right +5) Look at `./lisp/paths.el'; if some of those values are not right for your system, set up the file `./lisp/site-init.el' with XEmacs Lisp code to override them; it is not a good idea to edit paths.el itself. YOU MUST USE THE LISP FUNCTION `setq' TO ASSIGN VALUES, ＠＠ -424,7 +429,7 ＠＠ XEmacs cannot detect, you may need to change the value of `directory-abbrev-alist'. -5) Put into `./lisp/site-init.el' or `./lisp/site-load.el' any Emacs +6) Put into `./lisp/site-init.el' or `./lisp/site-load.el' any Emacs Lisp code you want XEmacs to load before it is dumped out. Use site-load.el for additional libraries if you arrange for their documentation strings to be in the lib-src/DOC file (see ＠＠ -443,12 +448,12 ＠＠ The `site-*.el' files are nonexistent in the distribution. You do not need to create them if you have nothing to put in them. -6) Refer to the file `./etc/TERMS' for information on fields you may +7) Refer to the file `./etc/TERMS' for information on fields you may wish to add to various termcap entries. The files `./etc/termcap.ucb' and `./etc/termcap.dat' may already contain appropriately-modified entries. -7) Run `make' in the top directory of the XEmacs distribution to finish +8) Run `make' in the top directory of the XEmacs distribution to finish building XEmacs in the standard way. The final executable file is named `src/emacs'. You can execute this file "in place" without copying it, if you wish; then it automatically uses the sibling ＠＠ -512,18 +517,18 ＠＠ the command. See the section below called `MAKE VARIABLES' for more information on this. -8) If your system uses lock files to interlock access to mailer inbox files, -then you might need to make the movemail program setuid or setgid -to enable it to write the lock files. We believe this is safe. +9) If your system uses lock files to interlock access to mailer inbox +files, then you might need to make the movemail program setuid or +setgid to enable it to write the lock files. We believe this is safe. The setuid/setgid bits need not be set on any other XEmacs-related executables. -9) You are done with the hard part! You can remove executables and +10) You are done with the hard part! You can remove executables and object files from the build directory by typing `make clean'. To also remove the files that `configure' created (so you can compile XEmacs for a different configuration), type `make distclean'. -10) You should now go to the XEmacs web page at http://www.xemacs.org/ +11) You should now go to the XEmacs web page at http://www.xemacs.org/ and decide what additional Lisp support you wish to have. MAKE VARIABLES ＠＠ -664,13 +669,13 ＠＠ `src/config.h', and change the two `#include' directives to include the appropriate system and architecture description files. -2) Edit `./src/config.h' to set the right options for your system. If +3) Edit `./src/config.h' to set the right options for your system. If you need to override any of the definitions in the s/*.h and m/*.h files for your system and machine, do so by editing config.h, not by changing the s/*.h and m/*.h files. Occasionally you may need to redefine parameters used in `./lib-src/movemail.c'. -3) If you're going to use the make utility to build XEmacs, you will +4) If you're going to use the make utility to build XEmacs, you will still need to run `configure' first, giving the appropriate values for the variables in the sections entitled "Things `configure' Might Edit" and "Where To Install Things." Note that you may only need to change ＠＠ -769,6 +774,10 ＠＠ PROBLEMS + +The most likely problem is that you forgot to read and follow the +directions in README.packages. You can not have a working XEmacs +without downloading some additional packages. See the file PROBLEMS in this directory for a list of various problems sometimes encountered, and what to do about them.

1 participants
0 comments

Re: Patches Applied for 21.1.8 26 years

Vin Shelton

>>>>> On 22 Oct 1999, Gunnar Evermann <ge204(a)eng.cam.ac.uk> said: Gunnar> I have got another one: Gunnar> http://www.xemacs.org/list-archives/xemacs-patches/9901/msg00039.html Gunnar> this is REALLY old but was never applied to 21.0 or 21.1 for Gunnar> some reason. The patch is against something like 21.2.8 but it Gunnar> should be easy enough to adapt. Gunnar> I only realised we missed this when working on a new 21.1.7 Gunnar> bug report on c.e.x. Here's the patchlet I generated and applied. I did not investigate why the original patch did not apply cleanly. 1999-10-22 Gunnar Evermann <ge204(a)eng.cam.ac.uk> * glyphs-eimage.c (gif_instantiate): Correct handling of interlaced gifs to avoid writing past the end of the eimage buffer. --- src/glyphs-eimage.c~ Wed Sep 9 20:07:03 1998 +++ src/glyphs-eimage.c Fri Oct 22 07:59:08 1999 ＠＠ -701,7 +701,7 ＠＠ if (interlace) if (row >= height) { row = InterlacedOffset[++pass]; - while (row > height) + while (row >= height) row = InterlacedOffset[++pass]; } eip = unwind.eimage + (row * width * 3);

1 participants
0 comments

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

2000

1999

1998

XEmacs-Beta October 1999