October 1999 - XEmacs-Beta - XEmacs Mailing List Archives

Re: Patches Applied for 21.1.8 24 years, 7 months

Adrian Aichner

>>>>> "APA" == Adrian Aichner <aichner(a)ecf.teradyne.com> writes: Hello All, APA> It works nicely on NT, but 95/98 needs investigation. APA> I'll try to work this out with Craig Lanning. could any of you with access to Windows95 or Windows98 please try following patch against 21.2-b19, please? I'll try to make a patch in time for 21.1.8 then. Please send me back any output XEmacs produced on STDERR (it will go to the DOS box, if you start XEmacs from there). Please report output and errors for these test-cases: Here is what I get on Windows NT: (call-process "cmd" nil '(t t) nil) Microsoft(R) Windows NT(TM) (C) Copyright 1985-1996 Microsoft Corp. d:\Users\AichnerAd\tmp\J750> (call-process "command" nil '(t t) nil) Spawning child process: Exec format error (call-process "dir" nil '(t t) nil "c:\\") AUTOEXEC.BAT READER5 cygnus notes Acrobat3 RECYCLER enscript ntldr CONFIG.SYS Real ffastun.ffa pagefile.sys I386 TEMP ffastun.ffl pali.pl IO.SYS WINNT ffastun.ffo perl MSDOS.SYS XEmacs ffastun0.ffx perl.old Multimedia\ Files Xemacs.zip gcisdn telnet.log NTDETECT.COM autosave gnuserv-2_1p1 tmp NTRESKIT boot.ini gstools Program\ Files cvs mks Thanks in advance, Adrian cd d:\tmp\21.2\xemacs\src\ cvs diff Compilation started at Thu Oct 21 13:30:55 1999 +0200 (W. Europe Daylight Time) ? call-process.patch ? call-process.txt ? cvs-diff ? depend-of-make-src-depend ? Installation ? it ? runxemacs.pdb ? sysdep.c.good ? temacs.bsc ? temacs.ilk ? temacs.map ? temacs.pdb ? waitpid.txt ? xemacs.opt cvs server: Diffing . Index: callproc.c =================================================================== RCS file: /usr/CVSroot/XEmacs/xemacs/src/callproc.c,v retrieving revision 1.29.2.6 diff -u -r1.29.2.6 callproc.c --- callproc.c 1999/05/01 05:13:23 1.29.2.6 +++ callproc.c 1999/10/21 11:38:47 ＠＠ -45,6 +45,7 ＠＠ #define _P_NOWAIT 1 /* from process.h */ #include <windows.h> #include "nt.h" +#include "ntheap.h" #endif #ifdef DOS_NT ＠＠ -107,22 +108,33 ＠＠ if (!call_process_exited && EMACS_KILLPG (pid, SIGINT) == 0) - { - int speccount = specpdl_depth (); + { + int speccount = specpdl_depth (); - record_unwind_protect (call_process_kill, fdpid); - /* #### "c-G" -- need non-consing Single-key-description */ - message ("Waiting for process to die...(type C-g again to kill it instantly)"); + record_unwind_protect (call_process_kill, fdpid); + /* #### "c-G" -- need non-consing Single-key-description */ + message ("Waiting for process to die...(type C-g again to kill it instantly)"); - wait_for_termination (pid); +#ifdef WINDOWSNT + if (os_subtype == OS_WIN95) + { + wait_for_termination (OpenProcess(PROCESS_ALL_ACCESS, 0, -pid)); + } + else + { + wait_for_termination (OpenProcess(PROCESS_ALL_ACCESS, 0, pid)); + } +#else + wait_for_termination (pid); +#endif - /* "Discard" the unwind protect. */ - XCAR (fdpid) = Qnil; - XCDR (fdpid) = Qnil; - unbind_to (speccount, Qnil); + /* "Discard" the unwind protect. */ + XCAR (fdpid) = Qnil; + XCDR (fdpid) = Qnil; + unbind_to (speccount, Qnil); - message ("Waiting for process to die... done"); - } + message ("Waiting for process to die... done"); + } synch_process_alive = 0; close (fd); return Qnil; ＠＠ -170,6 +182,9 ＠＠ Lisp_Object infile, buffer, current_dir, display, path; int fd[2]; int filefd; +#ifdef WINDOWSNT + HANDLE pHandle; +#endif int pid; char buf[16384]; char *bufptr = buf; ＠＠ -358,7 +373,21 ＠＠ fork_error = Qnil; #ifdef WINDOWSNT pid = child_setup (filefd, fd1, fd_error, new_argv, - (char *) XSTRING_DATA (current_dir)); + (char *) XSTRING_DATA (current_dir)); + /* OpenProcess() as soon after child_setup as possible. It's too + late once the process terminated. */ + if (os_subtype == OS_WIN95) + { + stderr_out ("Fcall_process_internal.child_setup returns PID %d, using PID %d\n", pid, -pid); + /* create_child() in ntproc.c hacks PIDs for OS_WIN95 to fit + into Lisp_Int, i.e. negates them. Hence we have to use -pid + to get at the real PID for OS_WIN95. */ + pHandle = OpenProcess(PROCESS_ALL_ACCESS, 0, -pid); + } + else + { + pHandle = OpenProcess(PROCESS_ALL_ACCESS, 0, pid); + } #else /* not WINDOWSNT */ pid = fork (); ＠＠ -435,8 +464,8 ＠＠ #ifdef FILE_CODING instream = make_decoding_input_stream - (XLSTREAM (instream), - Fget_coding_system (Vcoding_system_for_read)); + (XLSTREAM (instream), + Fget_coding_system (Vcoding_system_for_read)); Lstream_set_character_mode (XLSTREAM (instream)); #endif NGCPRO1 (instream); ＠＠ -470,15 +499,16 ＠＠ break; #ifdef DOS_NT - /* Until we pull out of MULE things like - make_decoding_input_stream(), we do the following which is - less elegant. --marcpa */ - { - int lf_count = 0; - if (NILP (Vbinary_process_output)) { - nread = crlf_to_lf(nread, bufptr, &lf_count); - } - } + /* Until we pull out of MULE things like + make_decoding_input_stream(), we do the following which is + less elegant. --marcpa */ + { + int lf_count = 0; + if (NILP (Vbinary_process_output)) + { + nread = crlf_to_lf(nread, bufptr, &lf_count); + } + } #endif total_read += nread; ＠＠ -507,7 +537,11 ＠＠ QUIT; /* Wait for it to terminate, unless it already has. */ +#ifdef WINDOWSNT + wait_for_termination (pHandle); +#else wait_for_termination (pid); +#endif /* Don't kill any children that the subprocess may have left behind when exiting. */ Index: ntproc.c =================================================================== RCS file: /usr/CVSroot/XEmacs/xemacs/src/ntproc.c,v retrieving revision 1.14.2.10 diff -u -r1.14.2.10 ntproc.c --- ntproc.c 1999/10/10 12:40:13 1.14.2.10 +++ ntproc.c 1999/10/21 11:38:49 ＠＠ -304,14 +304,14 ＠＠ read anything for them to consume yet! */ /* - if (cp == NULL || - WaitForSingleObject (cp->char_consumed, INFINITE) != WAIT_OBJECT_0) + if (cp == NULL || + WaitForSingleObject (cp->char_consumed, INFINITE) != WAIT_OBJECT_0) */ if (cp == NULL) - { + { return 1; - } + } for (;;) { ＠＠ -329,28 +329,31 ＠＠ } if (rc == STATUS_READ_ERROR) - { - /* We are finished, so clean up handles and set to NULL so - that CHILD_ACTIVE will see what is going on */ - if (cp->char_avail) { - CloseHandle (cp->char_avail); - cp->char_avail = NULL; - } - if (cp->thrd) { - CloseHandle (cp->thrd); - cp->thrd = NULL; - } - if (cp->char_consumed) { - CloseHandle(cp->char_consumed); - cp->char_consumed = NULL; - } - if (cp->procinfo.hProcess) - { - CloseHandle (cp->procinfo.hProcess); - cp->procinfo.hProcess=NULL; - } - return 1; - } + { + /* We are finished, so clean up handles and set to NULL so + that CHILD_ACTIVE will see what is going on */ + if (cp->char_avail) + { + CloseHandle (cp->char_avail); + cp->char_avail = NULL; + } + if (cp->thrd) + { + CloseHandle (cp->thrd); + cp->thrd = NULL; + } + if (cp->char_consumed) + { + CloseHandle(cp->char_consumed); + cp->char_consumed = NULL; + } + if (cp->procinfo.hProcess) + { + CloseHandle (cp->procinfo.hProcess); + cp->procinfo.hProcess=NULL; + } + return 1; + } /* If the read died, the child has died so let the thread die */ if (rc == STATUS_READ_FAILED) ＠＠ -366,23 +369,26 ＠＠ } /* We are finished, so clean up handles and set to NULL so that CHILD_ACTIVE will see what is going on */ - if (cp->char_avail) { - CloseHandle (cp->char_avail); - cp->char_avail = NULL; - } - if (cp->thrd) { - CloseHandle (cp->thrd); - cp->thrd = NULL; - } - if (cp->char_consumed) { - CloseHandle(cp->char_consumed); - cp->char_consumed = NULL; - } + if (cp->char_avail) + { + CloseHandle (cp->char_avail); + cp->char_avail = NULL; + } + if (cp->thrd) + { + CloseHandle (cp->thrd); + cp->thrd = NULL; + } + if (cp->char_consumed) + { + CloseHandle(cp->char_consumed); + cp->char_consumed = NULL; + } if (cp->procinfo.hProcess) - { - CloseHandle (cp->procinfo.hProcess); - cp->procinfo.hProcess=NULL; - } + { + CloseHandle (cp->procinfo.hProcess); + cp->procinfo.hProcess=NULL; + } return 0; } ＠＠ -430,6 +436,7 ＠＠ strcpy (dir, process_dir); unixtodos_filename (dir); + stderr_out ("create_child: exe=%s,cmdline=%s\n", exe, cmdline); if (!CreateProcess (exe, cmdline, &sec_attrs, NULL, TRUE, (!NILP (Vwin32_start_process_share_console) ? CREATE_NEW_PROCESS_GROUP ＠＠ -447,8 +454,10 ＠＠ /* Hack for Windows 95, which assigns large (ie negative) pids */ if (cp->pid < 0) - cp->pid = -cp->pid; - + { + stderr_out ("create_child.CreateProcess leads child PID %d, changing to PID %d\n", cp->pid, -cp->pid); + cp->pid = -cp->pid; + } /* pid must fit in a Lisp_Int */ #ifdef USE_UNION_TYPE cp->pid = (cp->pid & ((1U << VALBITS) - 1)); ＠＠ -457,7 +466,7 ＠＠ #endif *pPid = cp->pid; - + return TRUE; EH_Fail: Index: sysdep.c =================================================================== RCS file: /usr/CVSroot/XEmacs/xemacs/src/sysdep.c,v retrieving revision 1.32.2.7 diff -u -r1.32.2.7 sysdep.c --- sysdep.c 1999/07/05 05:56:44 1.32.2.7 +++ sysdep.c 1999/10/21 11:38:54 ＠＠ -234,8 +234,11 ＠＠ #endif /* NO_SUBPROCESSES */ -void -wait_for_termination (int pid) +#ifdef WINDOWSNT +void wait_for_termination (HANDLE pid) +#else +void wait_for_termination (int pid) +#endif { /* #### With the new improved SIGCHLD handling stuff, there is much less danger of race conditions and some of the comments below ＠＠ -345,6 +348,43 ＠＠ Since implementations may add their own error indicators on top, we ignore it by default. */ +#elif defined (WINDOWSNT) + int ret = 0, status = 0; + assert (pid != NULL); + do + { + QUIT; + ret = WaitForSingleObject(pid, 100); + } + while (ret == WAIT_TIMEOUT); + if (ret == WAIT_FAILED) + { + stderr_out ("wait_for_termination.WaitForSingleObject returns %d (WAIT_FAILED) GetLastError () %d for pid %d\n", ret, GetLastError (), (int)pid); + } + if (ret == WAIT_ABANDONED) + { + stderr_out ("wait_for_termination.WaitForSingleObject returns %d (WAIT_ABANDONED) GetLastError () %d for pid %d\n", ret, GetLastError (), (int)pid); + } + if (ret == WAIT_OBJECT_0) + { + ret = GetExitCodeProcess(pid, &status); + if (ret) + { + synch_process_alive = 0; + synch_process_retcode = status; + } + else + { + /* GetExitCodeProcess() didn't return a valid exit status, + nothing to do. APA */ + stderr_out ("wait_for_termination.GetExitCodeProcess status %d GetLastError () %d for pid %d\n", status, GetLastError (), (int)pid); + } + } + if (!CloseHandle(pid)) + { + stderr_out ("wait_for_termination.CloseHandle GetLastError () %d for pid %d\n", + GetLastError (), (int)pid); + } #elif defined (EMACS_BLOCK_SIGNAL) && !defined (BROKEN_WAIT_FOR_SIGNAL) && defined (SIGCHLD) while (1) { ＠＠ -376,7 +416,7 ＠＠ Try defining BROKEN_WAIT_FOR_SIGNAL. */ EMACS_WAIT_FOR_SIGNAL (SIGCHLD); } -#else /* not HAVE_WAITPID and (not EMACS_BLOCK_SIGNAL or BROKEN_WAIT_FOR_SIGNAL) */ +#else /* not HAVE_WAITPID and not WINDOWSNT and (not EMACS_BLOCK_SIGNAL or BROKEN_WAIT_FOR_SIGNAL) */ /* This approach is kind of cheesy but is guaranteed(?!) to work for all systems. */ while (1) ＠＠ -578,7 +618,11 ＠＠ static void sys_subshell (void) { +#ifdef WINDOWSNT + HANDLE pid; +#else int pid; +#endif struct save_signal saved_handlers[5]; Lisp_Object dir; unsigned char *str = 0; ＠＠ -617,7 +661,7 ＠＠ xyzzy: #ifdef WINDOWSNT - pid = -1; + pid = NULL; #else /* not WINDOWSNT */ pid = fork (); ＠＠ -651,7 +695,7 ＠＠ #ifdef WINDOWSNT /* Waits for process completion */ pid = _spawnlp (_P_WAIT, sh, sh, NULL); - if (pid == -1) + if (pid == NULL) write (1, "Can't execute subshell", 22); #else /* not WINDOWSNT */ Index: sysdep.h =================================================================== RCS file: /usr/CVSroot/XEmacs/xemacs/src/sysdep.h,v retrieving revision 1.11.2.1 diff -u -r1.11.2.1 sysdep.h --- sysdep.h 1998/12/05 16:56:31 1.11.2.1 +++ sysdep.h 1999/10/21 11:38:54 ＠＠ -48,7 +48,12 ＠＠ /* Wait for subprocess with process id `pid' to terminate and make sure it will get eliminated (not remain forever as a zombie) */ +#ifdef WINDOWSNT +#include <windows.h> +void wait_for_termination (HANDLE pid); +#else void wait_for_termination (int pid); +#endif /* flush any pending output * (may flush input as well; it does not matter the way we use it) cvs server: Diffing m cvs server: Diffing s Compilation exited abnormally with code 1 at Thu Oct 21 13:31:15

2 participants
1 comments

*** PANIC *** The C compiler can no longer build working executables. 24 years, 7 months

SL Baur

>From a cvs update; make clean; ./config.status --recheck; make a few minutes ago: *** PANIC *** The C compiler can no longer build working executables. *** PANIC *** Please examine the tail of config.log for runtime errors. *** PANIC *** The most likely reason for this problem is that configure *** PANIC *** links with shared libraries, but those libraries cannot be *** PANIC *** found at run time. *** PANIC *** *** PANIC *** On a Linux system, edit /etc/ld.so.conf and re-run ldconfig. *** PANIC *** On other systems, try telling configure where to find the *** PANIC *** shared libraries using the --site-runtime-libraries option *** PANIC *** *** PANIC *** Another way to shoot yourself in the foot is to specify *** PANIC *** --with-FEATURE when FEATURE is not actually installed *** PANIC *** on your system. Don't do that. $ tail config.log dld_init() ; return 0; } configure:12665: gcc -o conftest -g -O3 -I/usr/lib/locale/ja/wnn/demo/include -I/usr/local/include -I/usr/local/canna/include -I/usr/dt/include -I/usr/local/X11R6/include -L/usr/lib/locale/ja/wnn/lib -L/usr/local/lib -L/usr/ccs/lib -L/usr/dt/lib -L/usr/local/X11R6/lib -Xlinker -R/usr/lib/locale/ja/wnn/lib:/usr/local/lib:/usr/dt/lib:/usr/local/X11R6/lib:/usr/local/qt/lib conftest.c -lXaw3d -ltiff -lpng -ljpeg -lz -lcompface -lXpm -lXmu -lXt -lXext -lX11 -lSM -lICE -lm -lsocket -lnsl -lelf -lgen -ldl 1>&5 ld: fatal: library -lXaw3d: not found ld: fatal: File processing errors. No output written to conftest collect2: ld returned 1 exit status configure: failed program was: #line 12661 "configure" #include "confdefs.h" int main(int c,char *v[]){return 0;} I have XawXPM installed as libXaw.so. Um, shouldn't configure check for whether -lXaw3d exists before using it?

3 participants
2 comments

Re: Footnotes + undo 24 years, 7 months

Robin S. Socha

* Gleb Arshinov <gleb(a)barsook.com> writes: > C-c ! a -- footnote #1 is inserted C-x u -- any mention of footnotes > in the text disappears C-c ! a -- footnote #2 is inserted (while > footnote #1 is expected). > Undo should probably probably decrement footnote counter in this case. I think you should be using C-c ! d: C-c ! d runs `Footnote-delete-footnote' -- Robin S. Socha Big. Black. Beautified. <http://socha.net/XEmacs/>

2 participants
1 comments

Re: Patches Applied for 21.1.8 [includes essential pathc] 24 years, 7 months

Robin S. Socha

* Jan Vroonhof <vroonhof(a)math.ethz.ch> writes: > Feel free to suggest alternative wording. I am not fond of what I > wrote, it is just better than nothing (or a shell script[1]) The following is shamelessly stolen from the WindowMaker Install file. IMO, it would be pretty neat to have such a file for XEmacs. Since that basic user will probably not need too many options, adapting and re-using this script would be rather simple (as in: so simple even I could do it if anyone thinks it might be useful. If someone needs to set CFLAGS and the like, they'll probably really want to use ./configure in the first place, anyway. trap "echo Window Maker installation aborted. ; exit 1" 2 3 echo echo "===================" echo "XEmacs Installation" echo "===================" echo echo "NOTE: If this script fails, read the INSTALL file and" echo "install by hand." echo echo "Please read the README, README.packages INSTALL and FAQ" echo "files before e-mailing questions. We will IGNORE any echo "questions that are already answered in the documentation." echo perai echo echo "Did you install the packages as suggested in README.packages?" echo "If not, please install them now." echo perai echo "Did you read the README.packages file?" echo -n "<y/n> " read rtfm if [ "$rtfm" != y ]; then echo "Please read the README.packages file before installing" exit fi echo "Are you sure?" echo -n "<y/n> " read rtfm if [ "$rtfm" != n ]; then echo "What a shame!" echo "Please read the README.packages file before installing" exit fi echo echo "Ok, you have been warned." echo perai echo echo "Option Selection" echo "================" ######################## KDE echo echo "Do you want sound support?" echo -n "<y/n> [n] " read kde if [ "$kde" = y -o "sound" = Y ]; then OPTIONS="$OPTIONS --enable-sound" fi [...] -- Robin S. Socha Closer to God - Nine Inch XEmacs <http://socha.net/XEmacs/NIN/>

1 participants
0 comments

Re: replace-match: GNU vs XEmacs 24 years, 7 months

John H Palmieri

Kyle Jones <kyle_jones(a)wonderworks.com> writes: > Clearly we shouldn't punish our users for the sake of Emacs > compatibility. The incompatibility problem is never going to go > away, so we should lay out a general policy as to how we deal > with API imcompatibilities, assuming that we do anything at all. > > For example, we could set aside part of the namespace, e.g. > fsf-compat-*, and put all the FSF compatibility functions > there. fsf-compat-replace-match would be the Emacs compatible > replace-match function. I would prefer this approach, instead > of doing tricks with replace-match's argument types. This seems like a fine idea. I would be tempted to do more: when there are functions like replace-match which are incompatibly defined, I would want three functions: fsf-compat-replace-match xemacs-compat-replace-match replace-match (an alias for xemacs-compat-replace-match) This way people who switch between GNU Emacs and XEmacs can explicitly choose which version of the function they want to use, at least in code for XEmacs. It also suggests names for GNU Emacs developers to use, if they decide to add XEmacs-compatible versions of things. -- John H. Palmieri Dept of Mathematics, Box 354350 palmieri(a)math.washington.edu University of Washington http://www.math.washington.edu/~palmieri Seattle, WA 98195-4350

1 participants
0 comments

Re: Patches Applied for 21.1.8 [includes essential pathc] 24 years, 7 months

Jan Vroonhof

Terje Bless <link(a)tss.no> writes: > >Is it my (attempt at) English that is confusing you or is this a > >question about why they are not in the core? > > The latter. The answer is: To allow them be released in a different cycle than the main XEmacs releases. The jury is still out on whether that is actually beneficial. Jan

1 participants
0 comments

Re: Patches Applied for 21.1.8 [includes essential pathc] 24 years, 7 months

Jan Vroonhof

Robert Pluim <rpluim(a)bigfoot.com> writes: > Actually, I've just noticed that my changes to README.packages and > package-get.el haven't been applied to 21.2, only to 21.1. Do I need > to resend the patches? No, It just means that Vinnie is the only one actually doing his job :-). I'll try and go apply some stuff this weekend provided I don't get lured to England by a tall blond beauty, Give a yell when they are not in in a week or so. Jan

1 participants
0 comments

Re: Patches Applied for 21.1.8 [includes essential pathc] 24 years, 7 months

Jan Vroonhof

Terje Bless <link(a)tss.no> writes: > >+The file 'README.packages' will guide you in the installation of > >+(essential) add on packages. > > If they are "essential", why are they "add on packages"? Is it my (attempt at) English that is confusing you or is this a question about why they are not in the core? Jan

2 participants
1 comments

Re: Patches Applied for 21.1.8 [includes essential pathc] 24 years, 7 months

Jan Vroonhof

Robert Pluim <rpluim(a)bigfoot.com> writes: > The English looks ok. Would it be possible to add something like the > following to the packages section of INSTALL: > > "It is recommended that you install at least the xemacs-base > package. If you wish to be able to update packages over a network > connection, then you need to install the efs package as well." I explicitly took out all references to specific packages to force people to read README.packages. I don't think an XEmacs with just xemacs-base is all that more useful than a bare XEmacs. I tried to put it more politely then AT THIS POINT YOU MUST READ README.packages, %!#＠!!!!!!. which is what I really meant. If you can find a sensible subset of README.packages that is small enough to fit in INSTALL I'm all for it. I cannot, otherwise README.packages would not exist. Feel free to suggest alternative wording. I am not fond of what I wrote, it is just better than nothing (or a shell script[1]) Jan Footnotes: [1] Still wondering how that happened.

2 participants
1 comments

Re: widget-push-button-value-create broken in latest 21.2 CVS? 24 years, 7 months

Per Abrahamsen

Katsumi Yamaoka <yamaoka(a)jpl.org> writes: > > (widget-create 'push-button > > :tag "Hello" > > :action (lambda (&rest args) (message "Hello"))) > > > > No button appears in *scratch* buffer with this code. :-< > > I forgot all that the configure option --with-widgets= is set none. A [Hello] text button should appear even if there are GUI buttons. Did it?

2 participants
1 comments

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

2000

1999

1998

XEmacs-Beta October 1999