May 2011 - XEmacs-Beta - XEmacs Mailing List Archives

A comment on style in commit/change log messages 13 years, 6 months

Stephen J. Turnbull

A recent committer writes: > lisp/ChangeLog addition: > > * modeline.el (make-modeline-command-wrapper): > Be more reasonable about the implementation of this wrapper, don't > require that the value of COMMAND be available at macro-expansion > time. (Basically, implement a closure.) > * modeline.el (add-minor-mode): > Remove a workaround and misguided comment that are no longer > necessary or exact. Mercurial, like other DVCSes, provides several ways to get one-line summaries of changes. It's very helpful in that context if the first line is active and descriptive. In this case, I suggest Make #'make-modeline-command-wrapper evaluate COMMAND lazily. for the first line, followed by This allows the wrapper to called when the value of COMMAND becomes available only after macro-expansion time. Implemented by what is basically a closure. N.B. Some style guides suggest avoiding description of the implementation in such messages, but I find this kind of comment useful, as it helps me identify changes that are worth studying for their own sake (vs reviewing for correctness). If it's not easy to come up with such a terse statement (and I admit I had to think for a couple minutes, and that wasn't my first try), I would prefer reading simply Improve make-modeline-command-wrapper. over the vague "be more reasonable about the implementation". YMMV, but I find that I personally waste time trying to figure out what's "reasonable", or reading further in the log to find out when I really don't have any business doing so. The more terse form I find easier to accept with "that's nice" and move on. It emphasizes the important information about what was improved, too. The log for "add-minor-mode" is precise. It would be nice if it were shortened to fit on one line, such as Remove an unnecessary workaround, and a misguided comment. (This isn't very helpful in this case because it's a minor change piggybacked on a more important one in the same commit, and so won't be shown in a line-per-commit format. However, if it were a standalone commit the shorter message looks much nicer IMO.) I recognize that not all good coders or even people who otherwise write well will find it easy to come up with such terse first lines. If it's not a profitable use of your time, I recommend developing a small repertoire of phrases which may be imprecise but don't add random vagueness such as "improve ...", "fix bug in ...", "document ..." etc followed by the name of the function or whatever. Note that I specifically mentioned what *I* would like to read. I'm only one contributor in this context, and may or may not be representative of others. Comments about what would make log message more useful to *you* are welcome! _______________________________________________ XEmacs-Beta mailing list XEmacs-Beta(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-beta

1 participants
0 comments

umlauts/special char through gnuclient -w/ssh 13 years, 6 months

Richard

Hi, often using 'gnuclient -nw' thorugh a ssh connection and never had problems until I tried UTF8 chars eg äöü. Hitting such char invokes some ESC sequences instead of inserting the char as expected. The settings are LANG=en_US.UTF-8 on both ends. The UTF chars work perfectly in an xterm. What am I missing? xemacs-21.5.29 Richard --- Name and OpenPGP keys available from pgp key servers _______________________________________________ XEmacs-Beta mailing list XEmacs-Beta(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-beta

2 participants
1 comments

More problems at Alioth!? 13 years, 6 months

The XEmacs Package Smoketest

Hi, These evening I can't pull from the xemacs repo. I'm getting $ LANG=C hg pull remote: Permission denied (publickey). abort: no suitable response from remote hg! I don't think I have changed anything on my side. Even a fresh clone does not work and gives the same result. Yours -- %% Mats _______________________________________________ XEmacs-Beta mailing list XEmacs-Beta(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-beta

4 participants
5 comments

Problem at alioth? 13 years, 6 months

The XEmacs Package Smoketest

Hi, The buildbot clients have problems pulling updates from alioth. The have all gone red or getting there. I get "The RSA host key for hg.debian.org has changed..." when trying to pull. There was I scheduled maintenance!? Is it still going on? News? Yours -- %% Mats _______________________________________________ XEmacs-Beta mailing list XEmacs-Beta(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-beta

8 participants
23 comments

32-bit builds? 13 years, 6 months

Raymond Toy

While trying to do a build on Solaris (sparc), I ran into this problem: Building finder database ... rm -f /net/gondor/Volumes/share2/src/xemacs/hg/xemacs-21.5/src/../lisp/finder-inf.el ./xemacs -no-packages -batch -eval "(setq finder-compile-keywords-quiet t)" \ -eval "(setq lisp-directory \"/net/gondor/Volumes/share2/src/xemacs/hg/xemacs-21.5/src/../lisp\")" \ -l finder -f finder-compile-keywords Loading auto-autoloads.el... (file auto-autoloads.elc is out-of-date) Loading auto-autoloads.el... (file auto-autoloads.elc is out-of-date) xemacs exiting. Invalid argument: No buffer named, "*finder-scratch*" To see what was going on, I tried a 64-bit build using Sun C instead of gcc 4.5.2. This works fine and the result works ok too. In case this was a gcc issue, I tried again using Sun C to do a 32-bit build. This fails in the same way. As a final test, I tried a 32-bit build on Linux using gcc 4.4.1. The 64-bit build works fine. However, the 32-bit build fails miserably with error messages like: gcc -c -Wall -Wno-switch -Wundef -Wsign-compare -Wno-char-subscripts -Wpacked -Wshadow -Wmissing-declarations -Wmissing-prototypes -Wstrict-prototypes -Wdeclaration-after-statement -Wunused-parameter -g -m32 -Demacs -I. -I/net/gondor/src/xemacs/hg/xemacs-21.5/src -DHAVE_CONFIG_H /net/gondor/src/xemacs/hg/xemacs-21.5/src/termcap.c /net/gondor/src/xemacs/hg/xemacs-21.5/src/termcap.c:107: warning: function declaration isn't a prototype /net/gondor/src/xemacs/hg/xemacs-21.5/src/termcap.c:120: warning: function declaration isn't a prototype /net/gondor/src/xemacs/hg/xemacs-21.5/src/termcap.c:130: warning: function declaration isn't a prototype /net/gondor/src/xemacs/hg/xemacs-21.5/src/termcap.c:143: warning: function declaration isn't a prototype /net/gondor/src/xemacs/hg/xemacs-21.5/src/termcap.c:236: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'ospeed' Anyone doing 32-bit builds these days? A 64-bit build is fine with me, but I don't really need an editor that can edit multi-GB files.:-) I also get a few warnings on 32-bit Solaris about integer overflows. I'll check those out and see if they're important or not. Ray _______________________________________________ XEmacs-Beta mailing list XEmacs-Beta(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-beta

5 participants
7 comments

something wrong with the HG repo 13 years, 6 months

Didier Verna

After pushing a changeset I got this: didier(pts/6)% hg push -b default pushing to ssh://sperber-guest＠hg.debian.org//hg/xemacs/xemacs searching for changes remote: adding changesets remote: adding manifests remote: adding file changes remote: added 1 changesets with 2 changes to 2 files remote: test: 11: 1: unexpected operator remote: Reply-To: xemacs-patches(a)xemacs.org: No such file or directory remote: warning: incoming hook exited with status 1 It seems that there's a hooked script that's gone south... -- Resistance is futile. You will be jazzimilated. Scientific site: http://www.lrde.epita.fr/~didier Music (Jazz) site: http://www.didierverna.com _______________________________________________ XEmacs-Beta mailing list XEmacs-Beta(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-beta

2 participants
1 comments

problem with calc-store 13 years, 6 months

Kevin Haddock

while trying to compile orgmode, I get a calc-store not provided error. Added (provide 'calc-store) at the end of calc-store.el and that fixed it. Perhaps the xemacs package repo needs updating? Thanks, -Kevin ----------- Someone once quoted Shakespeare to the philosopher W. V. O. Quine: "There are more things in heaven and earth than are dreamt of in your philosophy." The remark was meant as a put-down, a sort of "Yeah, what do you know?" To which Quine is said to have responded: "Possibly, but my concern is that there not be more things in my philosophy than are in heaven and earth." Quine was an Occamist. "Skeptics and True Believers" by Chet Raymo ----------- There be three kinds of unhappie men. 1. Qui scit & non docet, Hee that hath knowledge and teacheth not. 2. Qui docet & non vivit, He that teacheth, and liveth not thereafter. 3. Qui nescit, & non interrogat, He that knoweth not, and doth not enquire to understand. Coke's maxims Section 232b. _______________________________________________ XEmacs-Beta mailing list XEmacs-Beta(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-beta

2 participants
1 comments

Re: symbol-macrolet's Ansi Common Lisp compliance 13 years, 6 months

Aidan Kehoe

Ar an cúigiú lá is fiche de mí Bealtaine, scríobh Didier Verna: > Aidan Kehoe wrote: > > > Yeah, you’re right. Damnit, so it doesn’t look like we can make > > symbol-macrolet (and macrolet, as it happens) self-documenting in this > > way. > > OK, I've fixed this myself. Thanks! -- “Apart from the nine-banded armadillo, man is the only natural host of Mycobacterium leprae, although it can be grown in the footpads of mice.” -- Kumar & Clark, Clinical Medicine, summarising improbable leprosy research _______________________________________________ XEmacs-Beta mailing list XEmacs-Beta(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-beta

1 participants
0 comments

Re: symbol-macrolet's Ansi Common Lisp compliance 13 years, 6 months

Aidan Kehoe

Ar an ceathrú lá is fiche de mí Bealtaine, scríobh Didier Verna: > I think the following change broke SYMBOL-MACROLET's compliance with the > Common Lisp Standard: > > changeset: 5357:60ba780f9078 > user: Aidan Kehoe <kehoea(a)parhasard.net> > date: Sun Jan 02 00:06:14 2011 +0000 > summary: Use defmacro* when defining dolist, dotimes, do-symbols, macrolet, cl-macs.el > > > The way the macro is now defined makes it mandatory to have at least one > symbol-macro binding, which is in fact not necessary: Yeah, you’re right. Damnit, so it doesn’t look like we can make symbol-macrolet (and macrolet, as it happens) self-documenting in this way. -- “Apart from the nine-banded armadillo, man is the only natural host of Mycobacterium leprae, although it can be grown in the footpads of mice.” -- Kumar & Clark, Clinical Medicine, summarising improbable leprosy research _______________________________________________ XEmacs-Beta mailing list XEmacs-Beta(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-beta

1 participants
0 comments

Summary of XEmacs Issue Tracking System Issues 13 years, 6 months

XEmacs Issue Tracking System

ACTIVITY SUMMARY (2011-05-17 - 2011-05-24) XEmacs Issue Tracking System at http://tracker.xemacs.org/XEmacs/its/ To view or respond to any of the issues listed below, click on the issue number. Do NOT respond to this message. 514 open ( +0) / 249 closed ( +0) / 763 total ( +0) Open issues with patches: 11 Average duration of open issues: 871 days. Median duration of open issues: 906 days. Open Issues Breakdown new 182 ( +0) deferred 6 ( +0) napping 4 ( +0) verified 53 ( +0) assigned 151 ( +0) committed 28 ( +0) documented 3 ( +0) done/needs work 24 ( +0) _______________________________________________ XEmacs-Beta mailing list XEmacs-Beta(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-beta

1 participants
0 comments

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

2000

1999

1998

XEmacs-Beta May 2011