Re: Make the Mule-UCS CCL code a little saner.
17 years, 3 months
Aidan Kehoe
Ar an chéad lá is fiche de mí Lúnasa, scríobh Mike FABIAN:
> [...] I have attached a tentative patch which *might* fix the problem, I
> have not yet tested whether this really fixes the build of the packages.
>
> You have changed XINT to XCHAR_OR_INT in several places.
> But
>
> XCHAR_OR_INT (ccl_prog[ic++])
>
> apparently increments the instruction counter ‘ic’ twice whereas XINT
> did it only once. When ic is wrong, it is probably not surprising that
> something goes wrong with the CCL-program.
Right. And I don’t normally see it because I build with ERROR_CHECK_TYPE,
where the argument to XCHAR_OR_INT is only evaluated once. (It seems neither
of us looked at the CCL code in sufficient detail.)
Okay, since the argument to XCHAR_OR_INT is not an lvalue--which conflicts
with the macro writing guidelines--I’ve changed its non-ERROR_CHECK_TYPE
implementation to not evaluate it twice. I’ve also checked the package build
with this (both with your patch on its own, and with the lisp.h change too)
and it works fine. (Yes, anyone paying close attention will notice that the
change is redundant, but it doesn’t cost anything in execution speed, and
should eliminate the same error with this macro in the future.) Thank you
for tracking this down!
APPROVE COMMIT
NOTE: This patch has been committed.
src/ChangeLog addition:
2007-08-21 Aidan Kehoe <kehoea(a)parhasard.net>
* mule-ccl.c (ccl_driver): Don't pass XCHAR_OR_INT an argument of
* which the evaluation has side effects; thank you Mike
* Fabian. lisp.h: Redundantly, don't multiply evaluate the argument
* to XCHAR_OR_INT; this should prevent the same error in the future.
See http://mid.gmane.org/18123.19416.411471.958967＠parhasard.net for the
actual patch, which I sent a little earlier than intended.
--
On the quay of the little Black Sea port, where the rescued pair came once
more into contact with civilization, Dobrinton was bitten by a dog which was
assumed to be mad, though it may only have been indiscriminating. (Saki)
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
Re: What is the status of 21.5?
17 years, 3 months
Aidan Kehoe
Ar an chéad lá is fiche de mí Lúnasa, scríobh Vin Shelton:
> On 8/21/07, Aidan Kehoe <kehoea(a)parhasard.net> wrote:
>
> > > 11. We still don't have an all in one tarball.
> >
> > Optimistically, we have it on Windows, and the platform package systems
> > make its lack not a big issue on Unix.
>
> Someone else (Stephen?) also wrote that we have all the packages in
> one kit for Windows. That statement is not true. The Windows setup
> kit includes a large subset of packages, but not all of them.
Thank you for the correction--good to know.
--
On the quay of the little Black Sea port, where the rescued pair came once
more into contact with civilization, Dobrinton was bitten by a dog which was
assumed to be mad, though it may only have been indiscriminating. (Saki)
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
What is the status of 21.5?
17 years, 3 months
SL Baur
The current Linux kernel development model appears to be a
lot more appropriate to base (stable) XEmacs releases on than the
former version.
So, what's left to sign off on a 21.5? (The 21.5 I built on Solaris
crashes immediately, but that may be an older long-standing bug).
Just as soon as I'm done building a full-featured XEmacs I'll take
another look at that.
FSF macs has gone on to v22. I suppose we ought to be aiming
for that too.
21.1.x is all the programming power in an editor I ever dreamed
of and by "modern" standards, we are no longer a heavy weight
application.
I want to see relational database support embedded (and I'm going
to work on PostgreSQL support, I think I'm going to have to have a
Linux box to sort all that out though, Mac OS X is great for playing
games but it leaves something to be desired in the development arena)
Inspire me. XEmacs is good! It must not die.
-sb
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
Re: Bug in ediff-vc-latest-version w/ new vc
17 years, 3 months
Michael Kifer
> On Monday 20 August 2007, Michael Kifer wrote:
> > > Michael> But why does it bother you? XEmacs has vc-latest-version,
> > > and Michael> this is what is used then. Gnu emacs does not have it, and
> > > so Michael> the other if-branch is used. In that branch a macro vc-call
> > > is Michael> used (correctly).
> > >
> > > Ville's new vc doesn't have vc-latest-version.
> > >
> > > Skip
> >
> > Why? Perhaps he can suggest a workaround?
>
> The "new vc" is a straight port of vc*.el in GNU Emacs to XEmacs plus a few
> additional modes. If it doesn't have something, it's because the GNU Emacs
> version doesn't have it either.
>
If it is a port of GNU vc, then it must have vc-call, and so there should
be no problem.
I do not quite understand. Is it the case that you get an error when you
run ediff with vc or you do not like that XEmacs compiler says that the
variable state is unbound? In the latter case, it is a problem of the
compiler, I think. vc-call is a macro, which requires its first argument to
be unquoted, because it quotes it by itself. So, the compiler should
understand that.
--michael
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
Re: Make the Mule-UCS CCL code a little saner.
17 years, 3 months
Aidan Kehoe
Ar an seachtú lá déag de mí Lúnasa, scríobh Mike FABIAN:
> Mike FABIAN <mfabian(a)suse.de> さんは書きました:
>
> > Aidan Kehoe <kehoea(a)parhasard.net> さんは書きました:
>
> >> If you start the XEmacs binary in question with -vanilla, and evaluate
> >> the following code in *scratch* -- paste it into the buffer, move to
> >> the last parenthesis, and hit C-j -- does it provoke an error message?
> >>
> >> (progn
> >> (register-code-conversion-map
> >> 'mucs-ccl-test-map-1
> >> [10 10])
> >> (register-code-conversion-map
> >> 'mucs-ccl-test-map-2
> >> [0 1])
> >> (ccl-execute [0 8 278815 4 -2 -1
> >> (mucs-ccl-test-map-1 . code-conversion-map-id)
> >> (mucs-ccl-test-map-2 . code-conversion-map-id) 22]
> >> [0 0 0 0 0 0 0 0]))
> >
> > Yes, the same error message as in the build log:
> >
> > “Ccl error: Error in CCL program at code numbered ..., 5”
>
> Aidan,
>
> Are you sure that the above code should execute without
> an error message?
Now, I’m not. Your explanation does make sense, and using your build
information I’ve reproduced the error message on my home machine, but among
my emacs builds the behaviour is still exceptional. I need to investigate
this some more--thanks for the effort you’ve put into this.
--
On the quay of the little Black Sea port, where the rescued pair came once
more into contact with civilization, Dobrinton was bitten by a dog which was
assumed to be mad, though it may only have been indiscriminating. (Saki)
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
Dired 7.13 bug: don't quote + in filenames
17 years, 3 months
Adrian Aichner
Hi!
I don't think + should be quoted in file names.
With this patch I can run
! runs the command dired-do-shell-command
on filenames like
20070819T101640+0200.wav
I am trying to use timestamps including timezone offset as names for
files that are best qualified by time of creation (e.g. pictures,
audio recordings, etc.).
With the quoting I get:
---------------------------
Sound Recorder
---------------------------
Cannot open 'c:\Documents and Settings\aichnerad\My Documents\Xda_orbit My Documents\20070819T101640\+0200.wav'.
---------------------------
OK
---------------------------
Adrian
How about this:
diff -u c:\Program Files\XEmacs\xemacs-packages\lisp\dired\dired-shell.el.~1~ c:\Program Files\XEmacs\xemacs-packages\lisp\dired\dired-shell.el
--- c:\Program Files\XEmacs\xemacs-packages\lisp\dired\dired-shell.el.~1~ 2007-08-21 01:11:14.703000000 +0200
+++ c:\Program Files\XEmacs\xemacs-packages\lisp\dired\dired-shell.el 2007-08-21 01:11:14.718625000 +0200
＠＠ -197,7 +197,7 ＠＠
;; Quote everything except POSIX filename characters.
;; This should be safe enough even for really weird shells.
(let ((result "") (start 0) end)
- (while (string-match "[^---0-9a-zA-Z_./]" filename start)
+ (while (string-match "[^---0-9a-zA-Z_.+/]" filename start)
(setq end (match-beginning 0)
result (concat result (substring filename start end)
"\\" (substring filename end (1+ end)))
Emacs: XEmacs 21.5 (beta28) "fuki" (+CVS-20070818) [Lucid] (i586-pc-win32, Mule) of Sun Aug 19 2007 on TANG
Package: Dired
current state:
==============
(setq
dired-version "7.13"
dired-auto-shell-command-alist '(("\\.\\(dll\\|ocx\\)$" "regsvr32 \"*\"")
("\\.xl[st]$" "excel")
("\\.do[ct]$" "winword")
("\\.ppt$" "powerpnt \"*\"")
("."
(if
(file-directory-p
(file-name-as-directory (car files)))
"explorer" "notepad")
)
("."
(apa-dired-auto-shell-command-clearcase))
)
dired-backup-if-overwrite nil
dired-chown-program "/etc/chown"
dired-cleanup-alist '(("tex" ".toc" ".log" ".aux" ".dvi")
("latex" ".toc" ".log" ".aux" ".idx" ".lof" ".lot"
".glo" ".dvi")
("bibtex" ".blg" ".bbl")
("texinfo" ".cp" ".cps" ".fn" ".fns" ".ky" ".kys" ".pg"
".pgs" ".tp" ".tps" ".vr" ".vrs")
("patch" ".rej" ".orig") ("backups" "~")
("completion-ignored-extensions" ".svn/" "CM/" "CVS/"
".o" ".obj" ".elc" "~" ".bin" ".lbin" ".dvi" ".class")
)
dired-compression-method 'gzip
dired-compression-method-alist '((gzip ".gz" ("gzip" "-9") ("gzip" "-d") "-f")
(compress ".Z" ("compress" "-f")
("compress" "-d") "-f")
(pack ".z" ("pack" "-f") ("unpack")))
dired-copy-preserve-time t
dired-dwim-target nil
dired-failed-marker-shell ?!
dired-filename-re-ext "\\..+\\'"
dired-find-subdir nil
dired-gnutar-program "tar"
dired-keep-marker-compress t
dired-keep-marker-copy ?C
dired-keep-marker-hardlink ?H
dired-keep-marker-kill ?K
dired-keep-marker-rename t
dired-keep-marker-symlink ?S
dired-keep-marker-uucode ?U
dired-kept-versions 2
dired-listing-switches "-al"
dired-local-variables-file ".dired"
dired-ls-F-marks-symlinks nil
dired-ls-program "ls"
dired-mail-reader 'vm
dired-mode-line-modified "-%s%s%s-"
dired-no-confirm nil
dired-omit-extensions '(".class" ".lbin" ".bin" ".elc" ".obj" ".o" "CVS/"
"CM/" ".svn/" "~" ".orig" ".rej" ".vrs" ".vr" ".tps"
".tp" ".pgs" ".pg" ".kys" ".ky" ".fns" ".fn" ".cps"
".cp" ".bbl" ".blg" ".glo" ".lot" ".lof" ".idx"
".dvi" ".aux" ".log" ".toc")
dired-omit-files nil
dired-omit-regexps '("\\`#" "\\`\\.")
dired-refresh-automatically t
dired-shell-failure-marker ?!
dired-show-ls-switches nil
dired-trivial-filenames "\\`\\.\\.?\\'\\|\\`#"
dired-unshar-program nil
dired-use-file-transformers t
dired-verify-modtimes t
reporter-version "Your version of reporter is obsolete. Please upgrade."
)
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
[Bug: 21.5-b28] Problem with glyphs instanciators
17 years, 3 months
Didier Verna
Hi.
In all 21.5 versions in at least 2 years, I've been getting
warnings about invalid glyphs instanciators every millisecond. The
glyphs are handled properly though (the warnings buffer keeps poping
up). I've tested many platforms (including Mac OS + XDarwin + a manually
compiled XEmacs there) and different configurations (GC or whatever) and
the bug keeps occurring.
I don't think it depends on images, but rather in the glyph
instanciation or specifiers machinery. To reproduce, try a background
pixmap on the default face in your custom file, or try display-time, or
anything with images in Gnus...
Attached is my configuration file, and my current warnings buffer in
this just-started 21.5 session.
--
Didier Verna, didier(a)lrde.epita.fr, http://www.lrde.epita.fr/~didier
EPITA / LRDE, 14-16 rue Voltaire Tel.+33 (1) 44 08 01 85
94276 Le Kremlin-Bicêtre, France Fax.+33 (1) 53 14 59 22 didier(a)xemacs.org
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
Make `current-window-configuration' work as documented
17 years, 3 months
Michael Sperber
And, hardly three years later after you precisely reported the problem,
here's a fix. Sorry for the huge delay! (And thanks for the original
report!)
I'll apply Wednesday-ish if nobody objects.
Yoshiaki Kasahara <kasahara(a)nc.kyushu-u.ac.jp> writes:
> On Sun, 04 Apr 2004 11:25:29 +0200,
> Michael Sperber <sperber(a)informatik.uni-tuebingen.de> said:
>
>> Can you provide a recipe for reproducing the problem?
>
> Well, how about this simple example?
>
> in *scratch* buffer:
>
> (setq wc (current-window-configuration)) <hit "C-j">
> <hit "C-x 2" to split the frame>
> (set-window-configuration wc) <hit "C-j">
>
> You will see the cursor returns to the next line of "(setq ...". When
> I did the same things in other kinds of Emacs, the cursor didn't jump
> and stay after the line of "(set-window..".
2007-08-20 Mike Sperber <mike(a)xemacs.org>
* window-xemacs.el (root-window->saved-window):
(restore-saved-window-parameters): Don't save the point of the
current buffer, as per the docstring.
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
Index: lisp/window-xemacs.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/window-xemacs.el,v
retrieving revision 1.25
diff -u -r1.25 window-xemacs.el
--- lisp/window-xemacs.el 31 Oct 2006 09:16:29 -0000 1.25
+++ lisp/window-xemacs.el 20 Aug 2007 14:19:51 -0000
＠＠ -278,11 +278,10 ＠＠
(let ((marker (make-marker)))
(set-marker marker (window-start window) buffer)
(setf (saved-window-start-marker saved-window) marker))
- (let ((marker (make-marker)))
- (if (eq window (selected-window))
- (set-marker marker (point buffer) buffer)
- (set-marker marker (window-point window) buffer))
- (setf (saved-window-point-marker saved-window) marker))
+ (if (not (eq buffer (current-buffer)))
+ (let ((marker (make-marker)))
+ (set-marker marker (window-point window) buffer)
+ (setf (saved-window-point-marker saved-window) marker)))
(setf (saved-window-mark-marker saved-window)
(copy-marker (mark-marker t buffer)))))
saved-window))))
＠＠ -417,8 +416,9 ＠＠
(set-window-start window
(marker-position (saved-window-start-marker saved-window))
t)
- (set-window-point window
- (marker-position (saved-window-point-marker saved-window)))
+ (if (markerp (saved-window-point-marker saved-window))
+ (set-window-point window
+ (marker-position (saved-window-point-marker saved-window))))
(set-marker (mark-marker t buffer)
(marker-position (saved-window-mark-marker saved-window))
buffer)
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
Can't update package index
17 years, 3 months
Skip Montanaro
I'm running 21.5.28 on Mac OS X. I can't update the package index. After
selecting a download site and clicking Tools>Packages>Update Package Index
it whirs and clicks for a bit then complains (this is from the lossage
buffer):
Process error: GnuPG error. Package database not updated
BAD SIGNATURE claiming to be from 'nil'
Verifying...
Loading mc-gpg...done
Loading mc-gpg...
Loading mc-toplev...done
Loading mc-toplev...
PGP version set to GPG.
> :/pub/mirrors/xemacs/beta/experimental/packages/package-index.LATEST.gpg...done
> /xemacs/beta/experimental/packages/package-index.LATEST.gpg...100% (325.4 KB/s)
> s/xemacs/beta/experimental/packages/package-index.LATEST.gpg...97% (316.9 KB/s)
> s/xemacs/beta/experimental/packages/package-index.LATEST.gpg...96% (331.8 KB/s)
> s/xemacs/beta/experimental/packages/package-index.LATEST.gpg...92% (322.6 KB/s)
> s/xemacs/beta/experimental/packages/package-index.LATEST.gpg...90% (310.7 KB/s)
> s/xemacs/beta/experimental/packages/package-index.LATEST.gpg...88% (227.4 KB/s)
...
I have the following versions of GPG available:
% gpg --version
gpg (GnuPG) 1.4.7
Copyright (C) 2006 Free Software Foundation, Inc.
This program comes with ABSOLUTELY NO WARRANTY.
This is free software, and you are welcome to redistribute it
under certain conditions. See the file COPYING for details.
Home: ~/.gnupg
Supported algorithms:
Pubkey: RSA, RSA-E, RSA-S, ELG-E, DSA
Cipher: 3DES, CAST5, BLOWFISH, AES, AES192, AES256, TWOFISH
Hash: MD5, SHA1, RIPEMD160, SHA256, SHA384, SHA512, SHA224
Compression: Uncompressed, ZIP, ZLIB, BZIP2
% gpg2 --version
gpg (GnuPG) 2.0.3
Copyright (C) 2007 Free Software Foundation, Inc.
This program comes with ABSOLUTELY NO WARRANTY.
This is free software, and you are welcome to redistribute it
under certain conditions. See the file COPYING for details.
Home: ~/.gnupg
Supported algorithms:
Pubkey: RSA, ELG, DSA, ELG
Cipher: 3DES, CAST5, BLOWFISH, AES, AES192, AES256, TWOFISH
Hash: MD5, SHA1, RIPEMD160, TIGER192, SHA256, SHA384, SHA512
Compression: Uncompressed, ZIP, ZLIB, BZIP2
Googling for the BAD SIGNATURE error didn't yield anything useful. I didn't
see anything in the FAQ about it either. Any ideas about what went wrong?
--
Skip Montanaro - skip(a)pobox.com - http://www.webfast.com/~skip/
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
