* "Vin Shelton" <acs(a)alumni.princeton.edu>:
Vin,
Sorry, but I have to interject, although I think the fix is correct, too.
Robert,
APPROVE
On Mon, Apr 21, 2008 at 2:55 PM, Mats Lidell <matsl(a)xemacs.org> wrote:
> >>>>> TheSmokeTest wrote:
>
> TheSmokeTest> These are the results from the XEmacs Package Smoketest:
> TheSmokeTest> 21.5-nomule -- errors
> TheSmokeTest> 21.5-mule -- errors
> TheSmokeTest> 21.4-mule -- errors
> TheSmokeTest> 21.4-nomule -- errors
>
> We have had this situation now for a while. The showstopper is that tm
> requires vm-easymenu which is gone from vm. Removing the require fixes
> the build (See patch below). A guick look reveals no other
> dependencies to vm-easymenu so my guess is that it was only needed for
> making vm happy and with vm no longer having this file it is safe to
> drop the require.
Mats - do you have commit authority? Since tm is maintained by the
XEmacs Development Team, I believe any of us can legally check in this
change.
You are the listed maintainer of VM. Your commit brought this build
failure into the system (are you aware of the XEmacs Smoketest?). Do
you have any objections to this solution? Do you have a different patch
to address the problem?
Thanks,
norbert.
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches