On Tuesday, April 22, 2008 at 09:53:46, Norbert Koch wrote:
* "Vin Shelton" <acs(a)alumni.princeton.edu>:
Vin,
Sorry, but I have to interject, although I think the fix is correct,
too.
Robert,
> APPROVE
>
> On Mon, Apr 21, 2008 at 2:55 PM, Mats Lidell <matsl(a)xemacs.org>
> wrote:
> > >>>>> TheSmokeTest wrote:
> >
> > TheSmokeTest> These are the results from the XEmacs Package
> > TheSmokeTest> Smoketest:
> > TheSmokeTest> 21.5-nomule -- errors
> > TheSmokeTest> 21.5-mule -- errors
> > TheSmokeTest> 21.4-mule -- errors
> > TheSmokeTest> 21.4-nomule -- errors
> >
> > We have had this situation now for a while. The showstopper is
> > that tm requires vm-easymenu which is gone from vm. Removing
> > the require fixes the build (See patch below). A guick look
> > reveals no other dependencies to vm-easymenu so my guess is
> > that it was only needed for making vm happy and with vm no
> > longer having this file it is safe to drop the require.
>
> Mats - do you have commit authority? Since tm is maintained by
> the XEmacs Development Team, I believe any of us can legally check
> in this change.
You are the listed maintainer of VM. Your commit brought this build
failure into the system (are you aware of the XEmacs Smoketest?).
Well I heard of them, but I had no idea where exactly to
get reports from, but Google revealed the following to me
http://labb.contactor.se/~matsl/smoketest/logs/
Is there an email gateway resp. mailing list for the reports?
Do you have any objections to this solution? Do you have a
different patch to address the problem?
Was there a patch in the original email?
Removing the dependency should not do any harm and VM IMHO
does not require TM anymore. I have not been aware of the
dependency and actually more might be broken by now.
Cheers Robert
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches