4:40 p.m.
Sounds like a good plan to me... that's sorta the direction
I was trying to go with my code-change proposal, but I think
your solution is cleaner.
I am obviously not the best choice to make the code modifications...
I already revealed my glaring ignorance in that area.
Troy
-----Original Message-----
From: Hrvoje Niksic [mailto:hniksic＠arsdigita.com]
Sent: Thursday, October 26, 2000 9:27 AM
To: XEmacs Beta List; Troy Noble
Subject: Re: auto-save-list-file-name
Troy Noble <troy.noble(a)channelpoint.com> writes:
Yoshiki> Of course you can avoid this by calling
save-some-buffers
Yoshiki> but IMHO it should no be toggled in one session. It should
Yoshiki> persist one session or you'll end up with a lot of .save-*
Yoshiki> files left around after several sessions.
In light of this fact, I would agree you might not want to add
my changes... however should probably add a comment to the
definition for auto-save-list-file-prefix to the effect:
"This option should only be set once per session, preferably
in the user's initialization file. If it is set any time
later in the session, it may produce unpredictable behavior
with auto-save and session-recover."
This would hopefully help (most) others avoid falling into the trap
that Steve discovered.
Or...
we could argue that unsetting auto-save-list-file-prefix is a bad way
to disable the list autosaves in the first place. For one, it's
completely non-obvious from the name.
We could introduce a new variable named `inhibit-auto-save-session'
that would do exactly what its named implied. In addition to better
clarity, the advantage would be that the auto-save code could always
recover from a change of that variable in the middle of operation,
because changing it does not destroy any actual information.
For compatibility with the FSF and for sanity, we could also make
setting auto-save-list-file-prefix to nil have the same effect. The
warning would then not be necessary because you're not supposed to do
that anyway.
Yoshiki, Troy, what do you think?
2:56 a.m.
New subject: auto-save-list-file-name
Troy Noble <troy.noble(a)channelpoint.com> writes:
> We could introduce a new variable named
`inhibit-auto-save-session'
> that would do exactly what its named implied. In addition to better
> clarity, the advantage would be that the auto-save code could always
> recover from a change of that variable in the middle of operation,
> because changing it does not destroy any actual information.
>
> For compatibility with the FSF and for sanity, we could also make
> setting auto-save-list-file-prefix to nil have the same effect. The
> warning would then not be necessary because you're not supposed to do
> that anyway.
Sounds like a good plan to me... that's sorta the direction
I was trying to go with my code-change proposal, but I think
your solution is cleaner.
I also think it is a good plan. I'll implement it after I
get bored with Mule maze. I'm currently trying to make
encoded-kb.el work with XEmacs. Functions used there are
full of incompatibilities...
I am obviously not the best choice to make the code modifications...
I already revealed my glaring ignorance in that area.
No one is an expoert from the beginning. I myself have many
patches rejected with similar reasons. I hope you'll keep
hacking XEmacs.
--
Yoshiki Hayashi
11:33 a.m.
New subject: auto-save-list-file-name
Yoshiki Hayashi <yoshiki(a)xemacs.org> writes:
I also think it is a good plan. I'll implement it after I
get bored with Mule maze. I'm currently trying to make
encoded-kb.el work with XEmacs. Functions used there are
full of incompatibilities...
Here's the patch.
2000-10-27 Yoshiki Hayashi <yoshiki(a)xemacs.org>
* fileio.c (Vauto_save_list_file_prefix): Moved from startup.el.
(Vinhibit_auto_save_session): New variable.
(vars_of_fileio): Declare and initialize them.
* fileio.c (Fdo_auto_save): Don't create session file if
Vinhibit_auto_save_session or Vauto_save_list_file_prefix is non-nil.
2000-10-27 Yoshiki Hayashi <yoshiki(a)xemacs.org>
* startup.el (auto-save-list-file-prefix): Moved to fileio.c.
* startup.el (normal-top-level): Setup auto-save-list-file-name
if auto-save-list-file-prefix is non-nil.
Index: src/fileio.c
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs/src/fileio.c,v
retrieving revision 1.51.2.28
diff -u -r1.51.2.28 fileio.c
--- fileio.c 2000/10/12 04:59:07 1.51.2.28
+++ fileio.c 2000/10/27 10:26:40
＠＠ -94,6 +94,12 ＠＠
/* File name in which we write a list of all our auto save files. */
Lisp_Object Vauto_save_list_file_name;
+/* Prefix used to construct Vauto_save_list_file_name. */
+Lisp_Object Vauto_save_list_file_prefix;
+
+/* When non-nil, it prevents auto-save list file creation. */
+Lisp_Object Vinhibit_auto_save_session;
+
int disable_auto_save_when_buffer_shrinks;
Lisp_Object Vdirectory_sep_char;
＠＠ -3982,7 +3988,9 ＠＠
/* Open the auto-save list file, if necessary.
We only do this now so that the file only exists
if we actually auto-saved any files. */
- if (!auto_saved && STRINGP (listfile) && listdesc < 0)
+ if (!auto_saved && !Vinhibit_auto_save_session
+ && !NILP (Vauto_save_list_file_prefix)
+ && STRINGP (listfile) && listdesc < 0)
{
listdesc = open ((char *) XSTRING_DATA (listfile),
O_WRONLY | O_TRUNC | O_CREAT | OPEN_BINARY,
＠＠ -4297,6 +4305,18 ＠＠
File name in which we write a list of all auto save file names.
*/ );
Vauto_save_list_file_name = Qnil;
+
+ DEFVAR_LISP ("auto-save-list-file-prefix", &Vauto_save_list_file_prefix
/*
+Prefix for generating auto-save-list-file-name.
+Emacs's pid and the system name will be appended to
+this prefix to create a unique file name.
+*/ );
+ Vauto_save_list_file_prefix = build_string ("~/.saves-");
+
+ DEFVAR_BOOL ("inhibit-auto-save-session", &Vinhibit_auto_save_session /*
+When non-nil, inhibit auto save list file creation.
+*/ );
+ Vinhibit_auto_save_session = 0;
DEFVAR_BOOL ("disable-auto-save-when-buffer-shrinks",
&disable_auto_save_when_buffer_shrinks /*
Index: lisp/startup.el
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs/lisp/startup.el,v
retrieving revision 1.24.2.22
diff -u -r1.24.2.22 startup.el
--- startup.el 2000/10/12 07:22:43 1.24.2.22
+++ startup.el 2000/10/27 10:26:41
＠＠ -171,11 +171,6 ＠＠
:type 'string
:group 'mail)
-(defvar auto-save-list-file-prefix "~/.saves-"
- "Prefix for generating auto-save-list-file-name.
-Emacs's pid and the system name will be appended to
-this prefix to create a unique file name.")
-
(defvar init-file-debug nil)
(defvar init-file-had-error nil)
＠＠ -443,12 +438,13 ＠＠
(setq default-directory (abbreviate-file-name default-directory))
;; Specify the file for recording all the auto save files of
;; this session. This is used by recover-session.
- (setq auto-save-list-file-name
- (expand-file-name
- (format "%s%d-%s"
- auto-save-list-file-prefix
- (emacs-pid)
- (system-name))))
+ (if auto-save-list-file-prefix
+ (setq auto-save-list-file-name
+ (expand-file-name
+ (format "%s%d-%s"
+ auto-save-list-file-prefix
+ (emacs-pid)
+ (system-name)))))
(run-hooks 'emacs-startup-hook)
(and term-setup-hook
(run-hooks 'term-setup-hook))
--
Yoshiki Hayashi
5:54 a.m.
New subject: auto-save-list-file-name
Yoshiki Hayashi <yoshiki(a)xemacs.org> writes:
Yoshiki Hayashi <yoshiki(a)xemacs.org> writes:
> I also think it is a good plan. I'll implement it after I
> get bored with Mule maze. I'm currently trying to make
> encoded-kb.el work with XEmacs. Functions used there are
> full of incompatibilities...
Here's the patch.
Oops. The patch contains some errors again.
2000-10-30 Yoshiki Hayashi <yoshiki(a)xemacs.org>
* fileio.c (Vauto_save_list_file_prefix): Moved from startup.el.
(inhibit_auto_save_session): New variable.
(vars_of_fileio): Declare and initialize them.
* fileio.c (Fdo_auto_save): Don't create session file if
Vinhibit_auto_save_session or Vauto_save_list_file_prefix is non-nil.
Index: fileio.c
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs/src/fileio.c,v
retrieving revision 1.51.2.28
diff -u -u -r1.51.2.28 fileio.c
--- fileio.c 2000/10/12 04:59:07 1.51.2.28
+++ fileio.c 2000/10/30 05:52:50
＠＠ -94,6 +94,12 ＠＠
/* File name in which we write a list of all our auto save files. */
Lisp_Object Vauto_save_list_file_name;
+/* Prefix used to construct Vauto_save_list_file_name. */
+Lisp_Object Vauto_save_list_file_prefix;
+
+/* When non-nil, it prevents auto-save list file creation. */
+int inhibit_auto_save_session;
+
int disable_auto_save_when_buffer_shrinks;
Lisp_Object Vdirectory_sep_char;
＠＠ -3982,7 +3988,9 ＠＠
/* Open the auto-save list file, if necessary.
We only do this now so that the file only exists
if we actually auto-saved any files. */
- if (!auto_saved && STRINGP (listfile) && listdesc < 0)
+ if (!auto_saved && !inhibit_auto_save_session
+ && !NILP (Vauto_save_list_file_prefix)
+ && STRINGP (listfile) && listdesc < 0)
{
listdesc = open ((char *) XSTRING_DATA (listfile),
O_WRONLY | O_TRUNC | O_CREAT | OPEN_BINARY,
＠＠ -4297,6 +4305,18 ＠＠
File name in which we write a list of all auto save file names.
*/ );
Vauto_save_list_file_name = Qnil;
+
+ DEFVAR_LISP ("auto-save-list-file-prefix", &Vauto_save_list_file_prefix
/*
+Prefix for generating auto-save-list-file-name.
+Emacs's pid and the system name will be appended to
+this prefix to create a unique file name.
+*/ );
+ Vauto_save_list_file_prefix = build_string ("~/.saves-");
+
+ DEFVAR_BOOL ("inhibit-auto-save-session", &inhibit_auto_save_session /*
+When non-nil, inhibit auto save list file creation.
+*/ );
+ inhibit_auto_save_session = 0;
DEFVAR_BOOL ("disable-auto-save-when-buffer-shrinks",
&disable_auto_save_when_buffer_shrinks /*
--
Yoshiki Hayashi
8587
days inactive
8591
days old
3 comments
2 participants
participants (2)
-
Troy Noble -
Yoshiki Hayashi