|--==> "sc" == s champ <junctionxyz(a)mediaone.net&gt; writes: sc> On Wed, Dec 12, 2001 at 01:24:30PM +1000, Steve Youngs wrote: GA> It would be better to sync with upstream source. This particular GA> problem has been fixed a while back. GA> ftp://ftp.csd.uu.se/pub/users/andersl/beta/folding.el >>Agreed. Could one of you guys please do this. sc> well, what exactly would it involve? just grab the code, make sure it sc> works with xemacs, then move it into the text-modes cvs and submit a sc> diff? if so, i'm working on it. Basically, yeah. Don't forget a plain text ChangeLog entry, saying something like "Sync with upstream version x.xx". Oh, and as a personal favour to me, could you please make a unified diff (diff -u), I find those _much_ easier to review. Thanks heaps for doing this, s. -- |---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---| | XEmacs - It's not just an editor. | | It's a way of life. | |------------------------------------&lt;youngs(a)xemacs.org&gt;---|

s> On Wed, Dec 12, 2001 at 04:27:40PM +1000, Steve Youngs wrote: s> ok s> What have people been using, to make the changelog entries? run `add-change-log-entry-other-window' and populate some of the information for you. It will look for file named ChangeLog in the current directory, then in its parents. If it can't find any, it will create a new file. Gleb

On Tue, Dec 11, 2001 at 11:08:20PM -0800, Gleb Arshinov wrote: Some people's init files might need updating. It looks like all the fold-\(.*\) symbols are now named folding-\1. should there be a bunch of defalias calls, with the `byte-obsoleted-variable' property adding ? looking forward to it! -- sean

|--==> "sc" == s champ <junctionxyz(a)mediaone.net&gt; writes: sc> it'll probably be at least a few more days before a diff is submitted, sc> to merge the new beta version of folding.el (2.93) into the sc> text-utils package. That's cool, take your time. One question though, why are you sync'ing to a beta version? Isn't there a stable version? If there's not and our folding.el is a beta version anyway, that's fine. But I'd rather have a stable version of the file in packages if available. sc> a question: sc> It'll take quite a few calls to sc> #'define-obsolete-{function,variable}-alias, to make sure that the code sc> which uses the current xemacs folding.el will work with the newer sc> version. Should there be a seperate file, e.g.: folding-dep.el, for sc> that? If they were, folding.el could have one simple line added to it: sc> (load-library "folding-dep") sc> to ensure that old init files will be compatible with the current folding sc> mode. That sounds like a good idea to me, but I'd like to hear from others here about it. What do you think, People? sc> But, i don't have write access on the xemacs cvs server, nor am i sure sc> if i'm ready for it, so the diff submitted, for the merge, would sc> include a modified folding.el -- not the original code. Would that sc> still be acceptable, under licensing terms? No. But licensing has nothing to do with my concerns. The diff _*MUST*_ be against current CVS version of folding.el. [1] I don't understand why you think you need write access to CVS, the sources are available via anonymous pserver access. And I'd be the one committing your diff so you won't need write access. To check out the latest version of text-modes from CVS: cvs -d :pserver:anonymous＠cvs.xemacs.org:/pack/xemacscvs login password "cvs" (sans quotes) This step is only needed once, the password is then stored in your ~/.cvspass file. cvs -d :pserver:anonymous＠cvs.xemacs.org:/pack/xemacscvs co text-modes I apologise if those steps are incorrect, I'm writing this while offline so I can't check them. Footnotes: [1] Or if for any reason you can't get the sources from CVS, then the diff should be against the most recent version of the file that you can get from /ftp.xemacs.org:/pub/xemacs/packages/ -- |---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---| | XEmacs - It's not just an editor. | | It's a way of life. | |------------------------------------&lt;youngs(a)xemacs.org&gt;---|

|--==> "APA" == Adrian Aichner <Adrian.Aichner(a)t-online.de&gt; writes: SY> To check out the latest version of text-modes from CVS: APA> s/anonymous/cvs/g APA> It's documented at APA> http://www.xemacs.org/Develop/cvsaccess.html#quickstart Thanks, Adrian. I wrote that while offline and just couldn't remember it. -- |---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---| | XEmacs - It's not just an editor. | | It's a way of life. | |------------------------------------&lt;youngs(a)xemacs.org&gt;---|

|--==> "SC" == Sean Champ <junctionxyz(a)mediaone.net&gt; writes: SC> On Fri, Dec 14, 2001 at 07:18:01AM +1000, Steve Youngs wrote: SC> There is a stable version; a diff between the "stable" and "lastest SC> beta" version shows no difference OK, fair enough. SC> The way i saw it, if i needed to submit a diff that was between the SC> current XEmacs folding.el and an /untouched/ version of the upstream SC> folding.el, then, for the full synch, i'll have to submit two diffs: SC> one between the current XEmacs version and the untouched upstream SC> source, and another with (load-library "folding-dep") added to the SC> diffed folding.el. Just submit a single diff (our-folding -> upstream-folding+dep). And attach/include a copy of your new folding-dep.el. The polite thing to do is to comment your change in folding.el (;; XEmacs change: blah blah), and if possible, wrap it in something so the '(require 'folding-dep)' is only done when run on XEmacs. You're very welcome to send a diff & folding-dep.el to the upstream maintainers yourself, or I can take care of it for you. Either way, could you please let me know what you've done. Thanks heaps for this, Sean. -- |---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---| | XEmacs - It's not just an editor. | | It's a way of life. | |------------------------------------&lt;youngs(a)xemacs.org&gt;---|

Jari> The Isearch is something I'm unable to fix, because I do not Jari> know how XEmacs keymaps work together with ISearch - Jari> vs. Emacs. Jari> Gleb, if you have a solution, please play with the latest Jari> code. OK, I looked at the code again, and I have a proper solution. This is against 2.93. This is tested only on XEmacs 21.4. 2001-12-30 Gleb Arshinov <gleb(a)barsook.com&gt; * folding.el: remove comment about (now fixed) XEmacs isearch support bug (folding-isearch-hook-function): for XEmacs use overriding-local-map or to fiddle with minor-mode-map-alist as appropriate. This supports both 21.2+ and older XEmacs isearch code. (folding-isearch-general): execute isearch-abort and isearch-quit like any other function for clarity and to make sure any side-effects of underlying implementation take effect. cond clause is no longer necessary, but is left in place to make patch more clear. (folding-isearch-general): always goto position returned by underlying isearch function. This makes C-g work as expected (go back to original position where isearch was started) (folding-isearch-general): fully mimic exit signal of isearch Gleb

sc> it'll probably be at least a few more days before a diff is sc> submitted, to merge the new beta version of folding.el (2.93) sc> into the text-utils package. What's the state of this? Sorry if I missed a patch & commit. sc> It'll take quite a few calls to sc> #'define-obsolete-{function,variable}-alias, to make sure that sc> the code which uses the current xemacs folding.el will work sc> with the newer version. Should there be a seperate file, sc> e.g.: folding-dep.el, for that? I don't think so. It might be an idea to have a new "package constant" file "compatibility.el" for all the obsolete symbols in the package. But otherwise I think having a ;;; Compatibility section in the Lisp library itself is a better idea. sc> so the diff submitted, for the merge, would include a modified sc> folding.el -- not the original code. Would that still be sc> acceptable, under licensing terms? I seem to recall maybe Steve Y answered this. But just in case: for XEmacs it's not a licensing issue; anything that's GPL or can be "upgraded" to GPL is fine. The important thing is for the diff to be against the current file in CVS to make application and commiting process smooth. -- Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Don't ask how you can "do" free software business; ask what your business can "do for" free software.