6:04 a.m.
I'm packing the car for my summer of fun in California. I will not be
doing any more on the comint/shell update for a few days, at least.
It's up to you to decide now: keep it, or revert?
I admit that I'm not getting the feeling of solid stability I had hoped
for, but on the other hand, I know of only one unresolved bug: the
insert-before-markers bug. It is clear from the comment just before the
use of insert-before-markers in comint.el that the upstream author
doesn't like using it. It seems to me that a combination of plain
insert and set-window-point ought to do the job with less fuss, but I
haven't thought it through all the way, either.
In any case, the insert-before-markers bug leaves shell mode crippled on
XEmacs 21.5. Somebody needs to revert my changes, fix the
insert-before-markers bug, or rewrite that part of comint.el to not use
insert-before-markers. I'll leave it up to you to decide which action
to take. I'll check back in as soon as I can.
--
Jerry James, Assistant Professor james(a)xemacs.org
Computer Science Department http://www.cs.usu.edu/~jerry/
Utah State University
12:06 a.m.
I wrote:
I'm packing the car for my summer of fun in California. I will
not be
doing any more on the comint/shell update for a few days, at least.
It's up to you to decide now: keep it, or revert?
I have arrived at my destination. It looks like I will be able to spare
a little time for XEmacs work this summer. Still, what do you want?
Should I press ahead with fixing the comint sync, or would you rather
revert?
In any case, the insert-before-markers bug leaves shell mode crippled
on
XEmacs 21.5. Somebody needs to revert my changes, fix the
insert-before-markers bug, or rewrite that part of comint.el to not use
insert-before-markers. I'll leave it up to you to decide which action
to take. I'll check back in as soon as I can.
I would like to pursue rewriting comint.el to not use
insert-before-markers. Are there any objections?
We should still fix insert-before-markers, of course.
--
Jerry James, Assistant Professor james(a)xemacs.org
Computer Science Department http://www.cs.usu.edu/~jerry/
Utah State University
5:57 a.m.
>>>> "Jerry" == Jerry James
<james(a)xemacs.org> writes:
Jerry> I have arrived at my destination. It looks like I will be
Jerry> able to spare a little time for XEmacs work this summer.
Jerry> Still, what do you want? Should I press ahead with fixing
Jerry> the comint sync, or would you rather revert?
I think you should try to fix the comint sync. It's twisted fate that
you didn't catch these bugs before the package got into CVS, but these
things happen. Unless we're going to abandon GNU compatibility
entirely for 22.0, now is a good time to get started on synching. We
know there's gonna be breakage, I'm sorry that this particular burden
fell on you at this point in time.
Jerry> I would like to pursue rewriting comint.el to not use
Jerry> insert-before-markers. Are there any objections?
No; +1 from me.
Jerry> We should still fix insert-before-markers, of course.
Of course! But I did a little digging (unraveling back to the
do_marker_adjustment function in insdel.c, which IIRC is the same in
21.4 and 21.5.27), and it's not obvious how to do that.
--
School of Systems and Information Engineering http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Ask not how you can "do" free software business;
ask what your business can "do for" free software.
9:34 p.m.
"Stephen J. Turnbull" <stephen(a)xemacs.org> wrote:
>>>>> "Jerry" == Jerry James
<james(a)xemacs.org> writes:
Jerry> I have arrived at my destination. It looks like I will be
Jerry> able to spare a little time for XEmacs work this summer.
Jerry> Still, what do you want? Should I press ahead with fixing
Jerry> the comint sync, or would you rather revert?
I think you should try to fix the comint sync. It's twisted fate that
you didn't catch these bugs before the package got into CVS, but these
things happen. Unless we're going to abandon GNU compatibility
entirely for 22.0, now is a good time to get started on synching. We
know there's gonna be breakage, I'm sorry that this particular burden
fell on you at this point in time.
It isn't twisted fate so much as me rushing to try to get stuff done
before leaving for the summer. If I had taken my time and been more
careful ... well, it still wouldn't be in CVS then. As for the burden
falling on me, well, it's self-inflicted. :-)
Jerry> I would like to pursue rewriting comint.el to not use
Jerry> insert-before-markers. Are there any objections?
No; +1 from me.
Great. I think that's the best choice.
Jerry> We should still fix insert-before-markers, of course.
Of course! But I did a little digging (unraveling back to the
do_marker_adjustment function in insdel.c, which IIRC is the same in
21.4 and 21.5.27), and it's not obvious how to do that.
Bummer.
--
Jerry James, Assistant Professor james(a)xemacs.org
Computer Science Department http://www.cs.usu.edu/~jerry/
Utah State University
6536
days inactive
6540
days old
3 comments
2 participants
participants (2)
-
Jerry James -
Stephen J. Turnbull