APPROVE COMMIT 21.4
Adrian Aichner <Adrian.Aichner(a)t-online.de> writes:
RECOMMEND 21.4
Hi Vin,
this is a minimal sync of my 21.5 patch.
I have noted Stephen's sceptisism, but what's the value of running the
tests without reporting their result?
I highly recommend this patch for 21.4.15.
Best regards,
Adrian
xemacs-21.4 ChangeLog patch:
Diff command: cvs -q diff -U 0
Files affected: tests/ChangeLog
Index: tests/ChangeLog
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/tests/ChangeLog,v
retrieving revision 1.2.2.25
diff -u -U0 -r1.2.2.25 ChangeLog
--- tests/ChangeLog 4 Sep 2003 02:44:51 -0000 1.2.2.25
+++ tests/ChangeLog 8 Sep 2003 22:52:37 -0000
@@ -0,0 +1,7 @@
+2003-09-09 Adrian Aichner <adrian(a)xemacs.org>
+
+ * automated/test-harness.el (test-harness-from-buffer): Log
+ results when running noninteractive.
+ * automated/test-harness.el (batch-test-emacs): Remove misplaced
+ debugging code.
+
xemacs-21.4 source patch:
Diff command: cvs -f -z3 -q diff -u -N
Files affected: tests/automated/test-harness.el
Index: tests/automated/test-harness.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/tests/automated/test-harness.el,v
retrieving revision 1.2.2.3
diff -u -r1.2.2.3 test-harness.el
--- tests/automated/test-harness.el 31 Oct 2002 15:09:16 -0000 1.2.2.3
+++ tests/automated/test-harness.el 8 Sep 2003 22:49:15 -0000
@@ -269,7 +269,7 @@
(message "Unexpected error %S while executing byte-compiled code."
error-info)
(message "Test suite execution aborted." error-info)
)))
- (princ "\nSUMMARY:\n")
+ (princ (format "\nSUMMARY for %s:\n" filename))
(princ (format "\t%5d passes\n" passes))
(princ (format "\t%5d assertion failures\n" assertion-failures))
(princ (format "\t%5d errors that should have been generated, but
weren't\n" no-error-failures))
@@ -285,14 +285,14 @@
(basename (file-name-nondirectory filename))
(summary-msg
(if (> total 0)
- (format "%s: %d of %d (%d%%) tests successful."
+ (format "%s: %d of %d tests successful (%d%%)."
basename passes total (/ (* 100 passes) total))
(format "%s: No tests run" basename)))
(reasons ""))
(maphash (lambda (key value)
(setq reasons
(concat reasons
- (format "\n %d tests skipped because %s"
+ (format "\n %d tests skipped because %s."
value key))))
skipped-test-reasons)
(when (> (length reasons) 1)
@@ -309,7 +309,9 @@
(fmakunbound 'Check-Error-Message)
(fmakunbound 'Ignore-Ebola)
(fmakunbound 'Int-to-Marker)
- )))
+ (and noninteractive
+ (message "%s" (buffer-substring-no-properties
+ nil nil "*Test-Log*"))))))
(defvar test-harness-results-point-max nil)
(defmacro displaying-emacs-test-results (&rest body)
@@ -388,7 +390,6 @@
(setq error t))))
(or (batch-test-emacs-1 file)
(setq error t))))
- ;;(message "%s" (buffer-string nil nil "*Test-Log*"))
(message "Done")
(kill-emacs (if error 1 0))))
--
Adrian Aichner
mailto:adrian@xemacs.org
http://www.xemacs.org/