Jeff> When clicking on the toolbar colors I get: Hi Jeff, what exactlty did you do to get this problem? Is it reproducible in xemacs -vanilla? What version of XEmacs are you using? What is your version of (package-get-package-provider 'xpm-mode) (text-modes "1.32") All these questions would be answered by a proper M-x report-emacs-bug Best regards, Adrian Jeff> Signaling: (wrong-type-argument toolbar-button-p nil) Jeff> toolbar-button-help-string(nil) Jeff> xpm-toolbar-select-colour(#<misc-user-event (call-interactively (lambda (event) (interactive "e") (xpm-toolbar-select-colour event "C")))> "C") Jeff> (lambda (event) (interactive "e") (xpm-toolbar-select-colour event "C"))(#<misc-user-event (call-interactively (lambda (event) (interactive "e") (xpm-toolbar-select-colour event "C")))>) Jeff> call-interactively((lambda (event) (interactive "e") (xpm-toolbar-select-colour event "C"))) Jeff> When opening a non existent file, fubar.xpm, xpm-mode goes into an Jeff> infinite while loop in xpm-init. Jeff> I'm sending a patch. Jeff> -jeff -- Adrian Aichner mailto:adrian＠xemacs.org http://www.xemacs.org/

Jeff> On 03 Mar 2002, Adrian.Aichner(a)t-online.de wrote: Jeff> When clicking on the toolbar colors I get: Jeff> Yes, (I had to remember to take out my patch though). How? Please give me a simple recipe. Oops, i was acidentally using a local package-index file with an old text-modes package of version 1.32 in the index. 1.38 is the latest of course and I do have it installed. Jeff> text-modes 1.38 xemacs 21.4.6 on windows build. Jeff> It is fine on Unix. Jeff> So, there may be an underlying toolbar issue on windows. I'm on Windows as well and want to take a look if I can reproduce the problem. Jeff> Yea, well, I already had the patch... Jeff> -jeff Jeff> Signaling: (wrong-type-argument toolbar-button-p nil) Jeff> toolbar-button-help-string(nil) Jeff> xpm-toolbar-select-colour(#<misc-user-event (call-interactively (lambda (event) (interactive "e") (xpm-toolbar-select-colour event "C")))> "C") Jeff> (lambda (event) (interactive "e") (xpm-toolbar-select-colour event "C"))(#<misc-user-event (call-interactively (lambda (event) (interactive "e") (xpm-toolbar-select-colour event "C")))>) Jeff> call-interactively((lambda (event) (interactive "e") (xpm-toolbar-select-colour event "C"))) Jeff> When opening a non existent file, fubar.xpm, xpm-mode goes into an Jeff> infinite while loop in xpm-init. Jeff> I'm sending a patch. Jeff> -jeff -- Adrian Aichner mailto:adrian＠xemacs.org http://www.xemacs.org/

Jeff> On 03 Mar 2002, Adrian.Aichner(a)t-online.de wrote: >> Jeff> On 03 Mar 2002, Adrian.Aichner(a)t-online.de wrote: Jeff> When clicking on the toolbar colors I get: Jeff> Yes, (I had to remember to take out my patch though). Jeff> xemacs -vanilla (actually Jeff> c:/PROGRA~1/XEmacs/XEmacs-21.4.6/i586-pc-win32/xemacs.exe -vanilla Jeff> from a cygwin bash shell), open an xpm file, say etc/xemacs-icon3.xpm: Jeff> My path is: c:/PROGRA~1/XEMACS/XEMACS-21.4.6/etc/xemacs-icon3.xpm You Jeff> should be in xpm-mode if you are using the latest package. Jeff> You get a row of little color buttons (in this case, Jeff> different shades of gray), you should get the error when you Jeff> click on them. Clicking on the button is supposed to print Jeff> a message like 'Toolbar selected #b2b2b2 (o)' Without the Jeff> patch I get wrong-type-argument toolbar-button-p nil, with Jeff> the patch I get 'Toolbar selected nil (o)'. Thanks, Jeff. I can reproduce this. There is another flaw: With a top gutter, the toolbar is starting above to image window. A picture says more than a thousand words, as they say: More later, Adrian Jeff> text-modes 1.38 xemacs 21.4.6 on windows build. Jeff> It is fine on Unix. Jeff> So, there may be an underlying toolbar issue on windows. Jeff> Are you using the cygwin or the windows build? This was using the Jeff> *windows* build, even though I'm also running cygwin. Jeff> -jeff Jeff> Yea, well, I already had the patch... Jeff> -jeff >> >> Adrian Jeff> Signaling: (wrong-type-argument toolbar-button-p nil) Jeff> toolbar-button-help-string(nil) Jeff> xpm-toolbar-select-colour(#<misc-user-event (call-interactively (lambda (event) (interactive "e") (xpm-toolbar-select-colour event "C")))> "C") Jeff> (lambda (event) (interactive "e") (xpm-toolbar-select-colour event "C"))(#<misc-user-event (call-interactively (lambda (event) (interactive "e") (xpm-toolbar-select-colour event "C")))>) Jeff> call-interactively((lambda (event) (interactive "e") (xpm-toolbar-select-colour event "C"))) Jeff> When opening a non existent file, fubar.xpm, xpm-mode goes into an Jeff> infinite while loop in xpm-init. Jeff> I'm sending a patch. Jeff> -jeff -- Adrian Aichner mailto:adrian＠xemacs.org http://www.xemacs.org/

Jeff> Yea, Be very careful if you try to "fix" this that you don't do something that breaks the other orientation. -- Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Don't ask how you can "do" free software business; ask what your business can "do for" free software.

Stephen> Be very careful if you try to "fix" this that you don't Stephen> do something that breaks the other orientation. APA> Huh? Someone with the default toolbar on the left, with the xpm palette toolbar at the top, currently gets the "right" behavior, I'm fairly sure. -- Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Don't ask how you can "do" free software business; ask what your business can "do for" free software.