6:06 p.m.
With this patch, the native XEmacs setup kit can be installed to a
directory of the user's choosing and the packages can be found without
setting the EMACSPACKAGEPATH environment variable.
The idea is that the setup kit will be built with
INSTALL_DIR=c:\Program Files\XEmacs\XEmacs-$(XEMACS_VERSION_STRING)
PACKAGE_PREFIX=c:\Program Files\XEmacs
and the user can choose whatever installation path he/she likes and
the packages will still be found.
See the thread starting at
http://list-archive.xemacs.org/xemacs-beta/200512/msg00354.html
for more information.
I plan to commit this within a few days and generate a pre-21.4.19 kit
for testing. I will also be submitting a 21.5 version of this patch
when I can generate one - my plan is to generate a 21.5 Windows native
setup kit that will be compatible with the 21.4 kit.
lisp/ChangeLog addition:
2005-12-26 Vin Shelton <acs(a)xemacs.org>
* find-paths.el:
* find-paths.el (paths-emacs-root-p): Add search for package root.
* find-paths.el (paths-find-emacs-root): Replaced with
paths-find-invocation-roots, which returns a list of roots.
* find-paths.el (paths-find-invocation-roots): New.
* find-paths.el (paths-find-emacs-roots): Call paths-find-invocation-roots.
21.4 source patch:
Diff command: cvs -q diff -u
Files affected: lisp/find-paths.el
Index: lisp/find-paths.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/find-paths.el,v
retrieving revision 1.19.2.2
diff -a -u -u -r1.19.2.2 find-paths.el
--- lisp/find-paths.el 2002/08/20 11:34:41 1.19.2.2
+++ lisp/find-paths.el 2005/12/26 17:48:36
＠＠ -108,8 +108,11 ＠＠
;; in-place or windows-nt
(and
(paths-file-readable-directory-p (paths-construct-path (list directory
"lisp")))
- (paths-file-readable-directory-p (paths-construct-path (list directory
"etc"))))))
+ (paths-file-readable-directory-p (paths-construct-path (list directory
"etc"))))
+ ;; searching for a package directory
+ (paths-file-readable-directory-p (paths-construct-path (list directory
"xemacs-packages")))))
+
(defun paths-root-in-place-p (root)
"Check if ROOT is an in-place installation root for XEmacs."
(paths-file-readable-directory-p (paths-construct-path (list root "lisp"))))
＠＠ -123,9 +126,10 ＠＠
(paths-chase-symlink destination))
file-name)))
-(defun paths-find-emacs-root
- (invocation-directory invocation-name)
- "Find the run-time root of XEmacs."
+(defun paths-find-invocation-roots (invocation-directory invocation-name)
+ "Find the list of run-time roots of XEmacs.
+INVOCATION-DIRECTORY is a directory containing the XEmacs executable.
+INVOCATION-NAME is the name of the executable itself."
(let* ((executable-file-name (paths-chase-symlink
(concat invocation-directory
invocation-name)))
＠＠ -134,10 +138,9 ＠＠
(paths-construct-path '("..") executable-directory)))
(maybe-root-2 (file-name-as-directory
(paths-construct-path '(".." "..") executable-directory))))
- (or (and (paths-emacs-root-p maybe-root-1)
- maybe-root-1)
- (and (paths-emacs-root-p maybe-root-2)
- maybe-root-2))))
+
+ (paths-filter #'paths-emacs-root-p
+ (list maybe-root-1 maybe-root-2))))
(defun paths-construct-path (components &optional expand-directory)
"Convert list of path components COMPONENTS into a path.
＠＠ -301,11 +304,8 ＠＠
(defun paths-find-emacs-roots (invocation-directory
invocation-name)
"Find all plausible installation roots for XEmacs."
- (let* ((potential-invocation-root
- (paths-find-emacs-root invocation-directory invocation-name))
- (invocation-roots
- (and potential-invocation-root
- (list potential-invocation-root)))
+ (let* ((invocation-roots
+ (paths-find-invocation-roots invocation-directory invocation-name))
(potential-installation-roots
(paths-uniq-append
(and configure-exec-prefix-directory
Regards,
Vin
6:45 p.m.
Vin Shelton <acs(a)xemacs.org> writes:
With this patch, the native XEmacs setup kit can be installed to a
directory of the user's choosing and the packages can be found without
setting the EMACSPACKAGEPATH environment variable.
[...]
I plan to commit this within a few days and generate a pre-21.4.19 kit
for testing.
Ah, OK---it wasn't clear to me that your intention was to commit it to
the CVS at large. It really needs to be conditionalized on
Windows---we once had a change in to include ../xemacs-packages, and
it caused lots of confusion and problems.
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
8:12 p.m.
Michael,
On 12/26/05, Michael Sperber <sperber(a)informatik.uni-tuebingen.de> wrote:
Vin Shelton <acs(a)xemacs.org> writes:
> With this patch, the native XEmacs setup kit can be installed to a
> directory of the user's choosing and the packages can be found without
> setting the EMACSPACKAGEPATH environment variable.
> [...]
> I plan to commit this within a few days and generate a pre-21.4.19 kit
> for testing.
Ah, OK---it wasn't clear to me that your intention was to commit it to
the CVS at large. It really needs to be conditionalized on
Windows---we once had a change in to include ../xemacs-packages, and
it caused lots of confusion and problems.
(Of course my concern about something like this is why I asked for
your help to start with.) Can you please explain what kinds of
confusion and problems you mean? With this patch in place, everything
works for me on my Windows and Linux machines, both at home and at
work.
BTW, the problem I observed, where EMACSPACKAGEPATH is treated
differently on 21.4 and 21.5 still exists. 21.4 looks under
$EMACSPACKAGEPATH/xemacs-packages for packages, but 21.5 looks only
under EMACSPACKAGEPATH.
Regards,
Vin
--
Whoever you are, no matter how lonely,
the world offers itself to your imagination,
calls to you like the wild geese, harsh and exciting--
over and over announcing your place
in the family of things. Mary Oliver
7:09 a.m.
Vin Shelton <acs(a)xemacs.org> writes:
(Of course my concern about something like this is why I asked for
your help to start with.) Can you please explain what kinds of
confusion and problems you mean?
The problem is that many people (including me) appeared to have
../xemacs-packages directories with something other than a package
hierarchy. (Typically, a checked-out CVS or something.)
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
3:16 p.m.
On 12/27/05, Michael Sperber <sperber(a)informatik.uni-tuebingen.de> wrote:
Vin Shelton <acs(a)xemacs.org> writes:
> (Of course my concern about something like this is why I asked for
> your help to start with.) Can you please explain what kinds of
> confusion and problems you mean?
The problem is that many people (including me) appeared to have
../xemacs-packages directories with something other than a package
hierarchy. (Typically, a checked-out CVS or something.)
Here's the latest patch, searching only for xemacs-packages under
Windows or cygwin. I'm still planning to commit this to 21.4 by the
end of the week.
BTW, Mike, can you please investigate the EMACSPACKAGEPATH problem
that I've referred to:
the problem I observed, where EMACSPACKAGEPATH is treated
differently on 21.4 and 21.5 still exists. 21.4 looks under
$EMACSPACKAGEPATH/xemacs-packages for packages, but 21.5 looks only
under EMACSPACKAGEPATH.
I believe this problem has kept the 21.5 version of this patch from
working. That is, after applying the 21-5 version of this patch,
`paths-find-emacs-roots' locates the root of the package tree, but the
sub-directories of $root/xemacs-packages do not get added to
load-path.
Here's a simple test case:
mkdir -p foo/xemacs-packages
cd foo/xemacs-packages
<unpack packages here>
cd -
EMACSPACKAGEPATH=$PWD/foo xemacs-21.5 -vanilla
will not find the packages unpacked under foo/xemacs-packages. The
same test under 21.4 will find those packages. I think it's desirable
to have the behavior consistent between the 2 versions so installed
packages can be shared.
If you don't want to look into this yourself, just point me in the
right direction and I will investigate.
Thank you,
Vin
--
Whoever you are, no matter how lonely,
the world offers itself to your imagination,
calls to you like the wild geese, harsh and exciting--
over and over announcing your place
in the family of things. Mary Oliver
5:03 p.m.
New subject: EMACSPACKAGEPATH problem
Vin Shelton <acs(a)xemacs.org> writes:
BTW, Mike, can you please investigate the EMACSPACKAGEPATH problem
that I've referred to:
> the problem I observed, where EMACSPACKAGEPATH is treated
> differently on 21.4 and 21.5 still exists. 21.4 looks under
> $EMACSPACKAGEPATH/xemacs-packages for packages, but 21.5 looks only
> under EMACSPACKAGEPATH.
Yes; the problem is that the 21.4 code is a mess. The 21.5 code is
much less of a mess, but gets this detail wrong. (It's a very long
story you don't want to know---the upshot is that
`packages-split-package-path' is the culprit.)
I'll fix this once I've got my pending patch for various
package-related issues committed.
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
5:22 p.m.
New subject: EMACSPACKAGEPATH problem
On 12/27/05, Michael Sperber <sperber(a)informatik.uni-tuebingen.de> wrote:
Vin Shelton <acs(a)xemacs.org> writes:
> BTW, Mike, can you please investigate the EMACSPACKAGEPATH problem
> that I've referred to:
>
>> the problem I observed, where EMACSPACKAGEPATH is treated
>> differently on 21.4 and 21.5 still exists. 21.4 looks under
>> $EMACSPACKAGEPATH/xemacs-packages for packages, but 21.5 looks only
>> under EMACSPACKAGEPATH.
Yes; the problem is that the 21.4 code is a mess. The 21.5 code is
much less of a mess, but gets this detail wrong. (It's a very long
story you don't want to know---the upshot is that
`packages-split-package-path' is the culprit.)
I'll fix this once I've got my pending patch for various
package-related issues committed.
Great. Thank you.
- Vin
--
Whoever you are, no matter how lonely,
the world offers itself to your imagination,
calls to you like the wild geese, harsh and exciting--
over and over announcing your place
in the family of things. Mary Oliver
5:12 p.m.
New subject: [A21.4] 21.4 find packages in ../xemacs-packages at run-time
APPROVE 21.4
Vin Shelton <acs(a)xemacs.org> writes:
Here's the latest patch, searching only for xemacs-packages
under
Windows or cygwin. I'm still planning to commit this to 21.4 by the
end of the week.
By my book, good to go for 21.4.
(Things will need to be different for 21.5, however. Please hold on
until I can get to flush my queue.)
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
6689
days inactive
6690
days old
7 comments
2 participants
participants (2)
-
Michael Sperber -
Vin Shelton