3:31 p.m.
Didier Verna <verna(a)inf.enst.fr> writes:
Note that the same
change as needed to fix your bug needs to apply to the the NT
version was well. Note that top that file claims the function has been
MULE-ized.
You're right, this corrects the bug. This brings me a question
that
might be stupid, but isn't it likely that most use of XSTRING_DATA
through the code will be bogus in the same fashion[1]?
Probably. MULE is totally broken this regard. I looked at a few of
them and most of them indeed look bogus.
bolzano:vroonhof/cvs/xemacs-20/src> grep XSTRING_DATA *.c | wc -l
424
:-(
I am wondering. Suppose we were to redefine XSTRING_DATA such that it
always used 'raw-text' or maybe even 'binary' as the coding
system would that help?
about the coding system ? I mean take the same function,
unix_create_process,
where the environement is massively copied for the child to be forked. What
should we do about it ?
You mean the arguments etc.. Do we really want
'process-argument-coding-system' (this can also be a lisp list op
coding systems such that the n-th item is used as a coding sytem for
the n-th argument) en 'environment-variable-coding-system',
domain-or-host-name-coding-system.
:-(
Jan
7:52 a.m.
New subject: [BUG] with non-ascii characters in dir names
>>>> "Jan" == Jan Vroonhof
<vroonhof(a)math.ethz.ch> writes:
Jan> Didier Verna <verna(a)inf.enst.fr> writes:
Jan> Note that the same
Jan> change as needed to fix your bug needs to apply to the the NT
Jan> version was well. Note that top that file claims the function has been
Jan> MULE-ized.
> You're right, this corrects the bug. This brings me a
question that
> might be stupid, but isn't it likely that most use of XSTRING_DATA
> through the code will be bogus in the same fashion[1]?
Jan> Probably. MULE is totally broken this regard. I looked at a few of
Jan> them and most of them indeed look bogus.
Jan> bolzano:vroonhof/cvs/xemacs-20/src> grep XSTRING_DATA *.c | wc -l
Jan> 424
Jan> :-(
Come on guys. Most uses of XSTRING_DATA in the source code are
entirely OK. Back when I had a Japanese development enviromnent, I
made sure I could use files and directories with Japanese file names.
So the current breakage, probably introduced by the Windows port,
should be relatively easy to fix. A developer that decides to do this
should decide to work in a non-English locale, create files and
directories with non-ASCII characters in them, and make sure they work
with find-file, dired, start-process, etc. etc...
Jan> I am wondering. Suppose we were to redefine XSTRING_DATA such that it
Jan> always used 'raw-text' or maybe even 'binary' as the coding
Jan> system would that help?
Hey, XSTRING_DATA always accesses the contents of a string lisp
object, which must always be in the XEmacs internal encoding. The C
code is responsible for ensuring that random character strings from
the external world are not used to create lisp strings without proper
data conversion. In particular, build_string("foo") is only (barely)
OK because the internal encoding is a superset of ASCII, as are most
of the external encodings. Put one of your favorite European
characters into that string, and you've got yourself a core dump.
Martin
8:44 a.m.
New subject: [BUG] with non-ascii characters in dir names
I hope the cross-post is the right thing to do; if not, my apologies.
>>>> "mb" == Martin Buchholz
<martin(a)xemacs.org> writes:
mb> So the current breakage, probably introduced by the Windows
mb> port,
There seems to be a bit of this going around. Don't get me wrong, the
Windows port is a GoodThang[tm], and should be strongly encouraged.
But I often get the impression (reading only XEmacs-beta, though, a
somewhat one-sided forum) that the Windows port is being done without
_fully_ understanding the existing code, and with little sympathy for
people who are maintaining existing code and delaying approval of
poorly understood patches---which they will be stuck maintaining in
the future---to it.
Are there any XEmacs/Windows developers who _use_ Mule, especially the
Asian language support or multiple character sets? (This is a real
question; if there's _nobody_, I could try building for Windose and
putting it through its paces, but it's a big cost for me as I have
_none_ of the infrastructure required yet, unless DJGPP 1.12/GCC 2.5.8
counts :-P, and would also have to figure out how to unbreak the
network interface to get Canna and/or Wnn, probably requiring a Win95
reinstall :-/)
--
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Institute of Policy and Planning Sciences Tel/fax: +81 (298) 53-5091
__________________________________________________________________________
__________________________________________________________________________
What are those two straight lines for? "Free software rules."
9:26 a.m.
New subject: [BUG] with non-ascii characters in dir names
At 17:44 25/11/98 +0900, Stephen J. Turnbull wrote:
Are there any XEmacs/Windows developers who _use_ Mule, especially
the
Asian language support or multiple character sets?
Not that I know of. I used to build with mule to get the CR/LF conversion
but that has been excised from mule now into file-coding. I don't really
know how the non-X stuff would work anyhow (font-wise). Kirill was pretty
careful about doing mule stuff properly, but again, given that I don't
think he used it, its difficult to tell how correct it is. I am probably
the most guilty having written a lot of new code for the windows port.
(This is a real
question; if there's _nobody_, I could try building for Windose and
putting it through its paces, but it's a big cost for me as I have
_none_ of the infrastructure required yet, unless DJGPP 1.12/GCC 2.5.8
counts :-P, and would also have to figure out how to unbreak the
network interface to get Canna and/or Wnn, probably requiring a Win95
reinstall :-/)
I think this would be a Good Thing. Ben did a review of all the windows
code to highlight points where mule wasn't used. But I guess that's not
particularly useful right now given that he's out of the picture for the
moment.
andy
---------------------------------------------------------------------------
" .sigs are like your face - rarely seen by you and uglier than you think"
Dr Andy Piper, Technical Architect, Parallax Solutions Ltd
mail: andyp(a)parallax.co.uk web: www.parallax.co.uk/~andyp
7:32 p.m.
New subject: [BUG] with non-ascii characters in dir names
"Stephen J. Turnbull" wrote:
[snip]
But I often get the impression (reading only XEmacs-beta, though, a
somewhat one-sided forum) that the Windows port is being done without
_fully_ understanding the existing code,
I don't know how many people can claim to _fully_ understand the whole
of XEmacs. That's partly why we have the xemacs-patches review process.
and with little sympathy for
people who are maintaining existing code and delaying approval of
poorly understood patches---which they will be stuck maintaining in
the future---to it.
I don't think that any of the people who have contributed significant
code towards the Windows port have been irresponsible about considering
existing functionality or maintainability of code shared between X and
Windows. That doesn't mean that we've always got things right.
Are there any XEmacs/Windows developers who _use_ Mule, especially
the
Asian language support or multiple character sets?
The native Windows port doesn't build for Mule because of annoying
configuration issues (the mule packages aren't in the standard place and
it's not trivial to add their location to EMACSBOOTSTRAPLOADPATH). I
don't know what other issues are hiding behind this build problem. I do
know that non-default fonts will not work because I had no idea how
multibyte Windows fonts worked when I wrote the Windows font code.
I now have a box near me at work that can boot into Japanese and Chinese
versions of Windows95, but I'm hampered by the fact that I have no idea
how this input method stuff is supposed to work.
(This is a real
question; if there's _nobody_, I could try building for Windose and
putting it through its paces, but it's a big cost for me as I have
_none_ of the infrastructure required yet, unless DJGPP 1.12/GCC 2.5.8
counts :-P, and would also have to figure out how to unbreak the
network interface to get Canna and/or Wnn, probably requiring a Win95
reinstall :-/)
We could really do with someone like yourself who uses Mule XEmacs on a
day-to-day basis.
Jonathan.
--
Jonathan Harris | jhar(a)tardis.ed.ac.uk
London, England | Jonathan.Harris(a)symbian.com
9306
days inactive
9307
days old
4 comments
5 participants
participants (5)
-
Andy Piper -
Jan Vroonhof -
Jonathan Harris -
Martin Buchholz -
Stephen J. Turnbull