3:32 a.m.
Dear Corinna, et al -
On Wed, Jan 28, 2015 at 8:58 AM, Corinna Vinschen wrote:
On Jan 28 08:20, Vin Shelton wrote:
> On Wed, Jan 28, 2015 at 4:53 AM, Corinna Vinschen wrote:
> > On Jan 27 23:05, Vin Shelton wrote:
> >> I spent some time debugging M-x shell in XEmacs on 32-bit Cygwin.
> >> Here's what I found out.
> >>
> >> In the child after fork() but before exec(), the setsid() call in
> >> disconnect_controlling_terminal() is causing the subprocess not to
> >> function after it gets spawned.
> >
> > Can you define "not function" a bit more detailed? Does no process
work
> > at all, or do only processes requiring a tty not work? For instance,
> > does something like an "echo foo > bar" still work?
>
> M-x shell is specifically designed to spawn an interactive process
> like a shell. The bash subprocess starts, but it accepts no input.
> Here is the output of ps for that process:
>
> S 1740 252 1740 268 pty1 1003 08:10:54 /usr/bin/bash
>
> I think it's only commands requiring a tty, but that's the whole point
> of M-x shell mode. There is a separate command - M-x shell-command -
> which is designed to run and capture the output of individual commands
> like "ls" or "echo". That works fine.
>
> BTW, if I try to spawn gdb as a shell, the behavior is similar, but
> this time the process looks like this:
>
> 3328 3248 3328 3408 pty2 1003 08:15:18
> /usr/bin/gdb <defunct>
>
> HTH.
>
> >>
> >> Thanks for any insight you can offer.
> >
> > Hmm, not off the top of my head. Is there a chance that you could
> > provide a simple, self contained testcase to reproduce the setsid
> > behaviour? I think I have to debug that.
>
> You mean a simpler test case than XEmacs? That seems like a low bar. :-)
LOL.
After thinking about this for awhile, it dawned on me that the problem
is not with setsid() per se, but rather with the sequence of events
_following_ the setsid() call. That is, setsid() causes some of the
ensuing ioctl() (or similar) calls that set up the pty to fail.
I think I have verified this behavior - I restored the old sysdep.c
module and moved the disconnect_controlling_terminal() call [which
calls setsid()] from right after the fork() to just before the exec()
call and M-x shell works on Cygwin as it always has on linux.
I will endeavor to create a STC for Cygwin that includes all the code
involved in setting up the terminal so we can experiment with moving
the setsid() call between the beginning and the end of the function.
- Vin
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
3:02 p.m.
New subject: Cygwin Subprocesses on XEmacs
Vin Shelton writes:
After thinking about this for awhile, it dawned on me that the
problem
is not with setsid() per se, but rather with the sequence of events
_following_ the setsid() call. That is, setsid() causes some of the
ensuing ioctl() (or similar) calls that set up the pty to fail.
I think I have verified this behavior - I restored the old sysdep.c
module and moved the disconnect_controlling_terminal() call [which
calls setsid()] from right after the fork() to just before the exec()
call and M-x shell works on Cygwin as it always has on linux.
I will endeavor to create a STC for Cygwin that includes all the code
involved in setting up the terminal so we can experiment with moving
the setsid() call between the beginning and the end of the function.
I confirm that this works, and eliminates the complaints from bash
about terminal control group and job control.
Thanks again for you help!
Next step -- back to working on 64-bit xemacs. . .
ht
--
Henry S. Thompson, School of Informatics, University of Edinburgh
10 Crichton Street, Edinburgh EH8 9AB, SCOTLAND -- (44) 131 650-4440
Fax: (44) 131 650-4587, e-mail: ht(a)inf.ed.ac.uk
URL: http://www.ltg.ed.ac.uk/~ht/
[mail from me _always_ has a .sig like this -- mail without it is forged spam]
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
7:46 a.m.
New subject: Cygwin Subprocesses on XEmacs
>>>> Henry S Thompson <ht(a)inf.ed.ac.uk> writes:
Next step -- back to working on 64-bit xemacs. . .
When I try to build the latest 21.5 on 64 bit cygwin I get this error.
$ LANG=C make
gcc -c -I/usr/include/noX -I/usr/include/noX -Wall -Wno-switch -Wundef -Wsign-compare
-Wno-char-subscripts -Wpacked -Wpointer-arith -Wshadow -Wmissing-declarations
-Wmissing-prototypes -Wstrict-prototypes -Wdeclaration-after-statement -Wunused-parameter
-g -Demacs -I. -I/src/xemacs/work/testing/src -DHAVE_CONFIG_H glyphs.c
In file included from /usr/include/w32api/winscard.h:11:0,
from /usr/include/w32api/windows.h:97,
from /usr/include/noX/X11/simx.h:42,
from /usr/include/noX/X11/xpm.h:87,
from glyphs.c:68:
/usr/include/w32api/winioctl.h:206:5: error: unknown type name 'DEVICE_TYPE'
DEVICE_TYPE DeviceType;
^
In file included from glyphs.c:46:0:
[...]
Ideas?
Yours
--
%% Mats
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
1:19 p.m.
New subject: Cygwin Subprocesses on XEmacs
Mats -
I am on the road right now and cannot work through this, but I would
recommend, first, to try to build a completely stripped-down XEmacs,
one without any image support (and no X, as it appears you already
are) and try to proceed from there. Failing that, please be sure to
include the Installation file on any trouble reports.
Regards,
Vin
On Thu, Feb 5, 2015 at 2:46 AM, Mats Lidell <matsl(a)xemacs.org> wrote:
>>>>> Henry S Thompson <ht(a)inf.ed.ac.uk> writes:
> Next step -- back to working on 64-bit xemacs. . .
When I try to build the latest 21.5 on 64 bit cygwin I get this error.
$ LANG=C make
gcc -c -I/usr/include/noX -I/usr/include/noX -Wall -Wno-switch -Wundef -Wsign-compare
-Wno-char-subscripts -Wpacked -Wpointer-arith -Wshadow -Wmissing-declarations
-Wmissing-prototypes -Wstrict-prototypes -Wdeclaration-after-statement -Wunused-parameter
-g -Demacs -I. -I/src/xemacs/work/testing/src -DHAVE_CONFIG_H glyphs.c
In file included from /usr/include/w32api/winscard.h:11:0,
from /usr/include/w32api/windows.h:97,
from /usr/include/noX/X11/simx.h:42,
from /usr/include/noX/X11/xpm.h:87,
from glyphs.c:68:
/usr/include/w32api/winioctl.h:206:5: error: unknown type name 'DEVICE_TYPE'
DEVICE_TYPE DeviceType;
^
In file included from glyphs.c:46:0:
[...]
Ideas?
Yours
--
%% Mats
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
5:37 p.m.
New subject: Cygwin Subprocesses on XEmacs
Mats Lidell writes:
>>>>> Henry S Thompson <ht(a)inf.ed.ac.uk> writes:
> Next step -- back to working on 64-bit xemacs. . .
When I try to build the latest 21.5 on 64 bit cygwin I get this error.
$ LANG=C make
gcc -c -I/usr/include/noX -I/usr/include/noX -Wall -Wno-switch -Wundef -Wsign-compare
-Wno-char-subscripts -Wpacked -Wpointer-arith -Wshadow -Wmissing-declarations
-Wmissing-prototypes -Wstrict-prototypes -Wdeclaration-after-statement -Wunused-parameter
-g -Demacs -I. -I/src/xemacs/work/testing/src -DHAVE_CONFIG_H glyphs.c
In file included from /usr/include/w32api/winscard.h:11:0,
from /usr/include/w32api/windows.h:97,
from /usr/include/noX/X11/simx.h:42,
from /usr/include/noX/X11/xpm.h:87,
from glyphs.c:68:
/usr/include/w32api/winioctl.h:206:5: error: unknown type name 'DEVICE_TYPE'
DEVICE_TYPE DeviceType;
My notes from last spring say
Renamed DEVICE_TYPE to DEVICE_TYPE_X in device-impl.h and everywhere
it is used to avoid collision with DEVICE_TYPE in winioctl.h
I did rather a lot of other hacking as well, but please carry on and
let us know how things go.
I just pulled, updated and merged, distclean and recompiled, alas no
change from last April:
src/xemacs -nw
works, but
src/xemacs &
fails with
Fatal error: assertion failed, file event-msw.c, line 4149, !NILP
(Vmswindows_frame_being_created)
I have made a number of 32->64 bit changes in event-msw.c
My notes from April say
the error in event-msw.c inside mswindow_find_frame, inside
intercepted_wnd_proc (a signal handler?),
where we have a
window with no frame saved, appears to happen when the main thread is
in mswindows_init_frame_1 at frame-msw.c:139
at recompute_all_cached_specifiers_in_frame at specifier.c:3483
at recompute_one_cached_specifier_in_frame at specifier.c:3444
around the sixth one
[/me goes back to day job]
ht
--
Henry S. Thompson, School of Informatics, University of Edinburgh
10 Crichton Street, Edinburgh EH8 9AB, SCOTLAND -- (44) 131 650-4440
Fax: (44) 131 650-4587, e-mail: ht(a)inf.ed.ac.uk
URL: http://www.ltg.ed.ac.uk/~ht/
[mail from me _always_ has a .sig like this -- mail without it is forged spam]
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
6:49 p.m.
New subject: Cygwin Subprocesses on XEmacs
Henry -
Is there a repo I can pull from to get your changes?
Thanks in advance,
Vin
On Thu, Feb 5, 2015 at 12:37 PM, Henry S. Thompson <ht(a)inf.ed.ac.uk> wrote:
Mats Lidell writes:
>>>>>> Henry S Thompson <ht(a)inf.ed.ac.uk> writes:
>> Next step -- back to working on 64-bit xemacs. . .
>
> When I try to build the latest 21.5 on 64 bit cygwin I get this error.
>
> $ LANG=C make
> gcc -c -I/usr/include/noX -I/usr/include/noX -Wall -Wno-switch -Wundef -Wsign-compare
-Wno-char-subscripts -Wpacked -Wpointer-arith -Wshadow -Wmissing-declarations
-Wmissing-prototypes -Wstrict-prototypes -Wdeclaration-after-statement -Wunused-parameter
-g -Demacs -I. -I/src/xemacs/work/testing/src -DHAVE_CONFIG_H glyphs.c
> In file included from /usr/include/w32api/winscard.h:11:0,
> from /usr/include/w32api/windows.h:97,
> from /usr/include/noX/X11/simx.h:42,
> from /usr/include/noX/X11/xpm.h:87,
> from glyphs.c:68:
> /usr/include/w32api/winioctl.h:206:5: error: unknown type name 'DEVICE_TYPE'
> DEVICE_TYPE DeviceType;
My notes from last spring say
Renamed DEVICE_TYPE to DEVICE_TYPE_X in device-impl.h and everywhere
it is used to avoid collision with DEVICE_TYPE in winioctl.h
I did rather a lot of other hacking as well, but please carry on and
let us know how things go.
I just pulled, updated and merged, distclean and recompiled, alas no
change from last April:
> src/xemacs -nw
works, but
> src/xemacs &
fails with
Fatal error: assertion failed, file event-msw.c, line 4149, !NILP
(Vmswindows_frame_being_created)
I have made a number of 32->64 bit changes in event-msw.c
My notes from April say
the error in event-msw.c inside mswindow_find_frame, inside
intercepted_wnd_proc (a signal handler?),
where we have a
window with no frame saved, appears to happen when the main thread is
in mswindows_init_frame_1 at frame-msw.c:139
at recompute_all_cached_specifiers_in_frame at specifier.c:3483
at recompute_one_cached_specifier_in_frame at specifier.c:3444
around the sixth one
[/me goes back to day job]
ht
--
Henry S. Thompson, School of Informatics, University of Edinburgh
10 Crichton Street, Edinburgh EH8 9AB, SCOTLAND -- (44) 131 650-4440
Fax: (44) 131 650-4587, e-mail: ht(a)inf.ed.ac.uk
URL: http://www.ltg.ed.ac.uk/~ht/
[mail from me _always_ has a .sig like this -- mail without it is forged spam]
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
9:06 a.m.
New subject: Cygwin Subprocesses on XEmacs
Vin Shelton writes:
Is there a repo I can pull from to get your changes?
Not a public one. I'll happily tar things up and send them to you,
_but_ I'm not sure you wouldn't be better off approaching this from a
clean start.
Broadly speaking I made two kinds of changes:
1) changing declarations of pointer vars from int to intptr_t;
2) updating unicode-encapsulate.
I hope most of (1) is OK, although one or two might not be right. But
(2) was done in a bull-in-a-china-shop way, without _really_
understanding how that whole rather complicately layered approach is
supposed to work.
Your call -- I'll put the repo somewhere public, and send you a
pointer in a private message, to spare my blushes.
ht
--
Henry S. Thompson, School of Informatics, University of Edinburgh
10 Crichton Street, Edinburgh EH8 9AB, SCOTLAND -- (44) 131 650-4440
Fax: (44) 131 650-4587, e-mail: ht(a)inf.ed.ac.uk
URL: http://www.ltg.ed.ac.uk/~ht/
[mail from me _always_ has a .sig like this -- mail without it is forged spam]
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
3361
days inactive
3369
days old
6 comments
3 participants
participants (3)
-
Henry S. Thompson -
The XEmacs Package Smoketest -
Vin Shelton