8:30 p.m.
I am not commiting this before I getting an expert opinion on the
correctness of this fix for:
From: "Christian Nybø" <ch.qr(a)nybo.no>
Subject: set-coding-system undefined
To: xemacs-beta(a)xemacs.org
Date: Wed, 27 Feb 2002 19:14:23 +0100
Message-Id: <E16g8at-0002GR-00＠lapchr>
Best regards,
Adrian
xemacs-21.5 Patch (cvs -f -z3 -q diff -u lisp/files.el):
Index: lisp/files.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/files.el,v
retrieving revision 1.46
diff -u -r1.46 files.el
--- lisp/files.el 2002/01/10 00:24:29 1.46
+++ lisp/files.el 2002/02/27 20:24:52
＠＠ -605,7 +605,7 ＠＠
coding system to use when decoding the file. Interactively,
with a prefix argument, you will be prompted for the coding system."
(interactive "FFind file: \nZCoding system: ")
- (if codesys
+ (if (and codesys (featurep 'file-coding))
(let ((coding-system-for-read
(get-coding-system codesys)))
(switch-to-buffer (find-file-noselect filename)))
＠＠ -619,7 +619,7 ＠＠
coding system to use when decoding the file. Interactively,
with a prefix argument, you will be prompted for the coding system."
(interactive "FFind file in other window: \nZCoding system: ")
- (if codesys
+ (if (and codesys (featurep 'file-coding))
(let ((coding-system-for-read
(get-coding-system codesys)))
(switch-to-buffer-other-window (find-file-noselect filename)))
＠＠ -631,7 +631,7 ＠＠
coding system to use when decoding the file. Interactively,
with a prefix argument, you will be prompted for the coding system."
(interactive "FFind file in other frame: \nZCoding system: ")
- (if codesys
+ (if (and codesys (featurep 'file-coding))
(let ((coding-system-for-read
(get-coding-system codesys)))
(switch-to-buffer-other-frame (find-file-noselect filename)))
＠＠ -645,7 +645,7 ＠＠
coding system to use when decoding the file. Interactively,
with a prefix argument, you will be prompted for the coding system."
(interactive "fFind file read-only: \nZCoding system: ")
- (if codesys
+ (if (and codesys (featurep 'file-coding))
(let ((coding-system-for-read
(get-coding-system codesys)))
(find-file filename))
＠＠ -661,7 +661,7 ＠＠
coding system to use when decoding the file. Interactively,
with a prefix argument, you will be prompted for the coding system."
(interactive "fFind file read-only other window: \nZCoding system: ")
- (if codesys
+ (if (and codesys (featurep 'file-coding))
(let ((coding-system-for-read
(get-coding-system codesys)))
(find-file-other-window filename))
＠＠ -677,7 +677,7 ＠＠
coding system to use when decoding the file. Interactively,
with a prefix argument, you will be prompted for the coding system."
(interactive "fFind file read-only other frame: \nZCoding system: ")
- (if codesys
+ (if (and codesys (featurep 'file-coding))
(let ((coding-system-for-read
(get-coding-system codesys)))
(find-file-other-frame filename))
＠＠ -748,7 +748,7 ＠＠
(unwind-protect
(progn
(unlock-buffer)
- (if codesys
+ (if (and codesys (featurep 'file-coding))
(let ((coding-system-for-read
(get-coding-system codesys)))
(find-file filename))
＠＠ -1919,7 +1919,7 ＠＠
(set-visited-file-name filename)))
(set-buffer-modified-p t)
(setq buffer-read-only nil)
- (if codesys
+ (if (and codesys (featurep 'file-coding))
(let ((buffer-file-coding-system (get-coding-system codesys)))
(save-buffer))
(save-buffer)))
＠＠ -2592,7 +2592,7 ＠＠
(signal 'file-error (list "Opening input file" "file is a
directory"
filename)))
(let ((tem
- (if codesys
+ (if (and codesys (featurep 'file-coding))
(let ((coding-system-for-read
(get-coding-system codesys)))
(insert-file-contents filename))
＠＠ -2608,7 +2608,7 ＠＠
coding system to use when encoding the file. Interactively,
with a prefix argument, you will be prompted for the coding system."
(interactive "r\nFAppend to file: \nZCoding system: ")
- (if codesys
+ (if (and codesys (featurep 'file-coding))
(let ((buffer-file-coding-system (get-coding-system codesys)))
(write-region start end filename t))
(write-region start end filename t)))
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
9:08 p.m.
>>>> "APA" == Adrian Aichner
<Adrian.Aichner(a)t-online.de> writes:
Should I test for
(or (featurep 'file-coding) (featurep 'mule))
instead?
Here's the ChangeLog for the current patch:
Index: ChangeLog
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/ChangeLog,v
retrieving revision 1.357
diff -u -u -r1.357 ChangeLog
--- ChangeLog 2002/02/12 14:24:39 1.357
+++ ChangeLog 2002/02/27 20:56:46
＠＠ -1,3 +1,17 ＠＠
+2002-02-27 Adrian Aichner <adrian(a)xemacs.org>
+
+ * files.el (find-file): Test for file-coding feature before using
+ it.
+ * files.el (find-file-other-window): Done.
+ * files.el (find-file-other-frame): Done.
+ * files.el (find-file-read-only): Done.
+ * files.el (find-file-read-only-other-window): Done.
+ * files.el (find-file-read-only-other-frame): Done.
+ * files.el (find-alternate-file): Done.
+ * files.el (write-file): Done.
+ * files.el (insert-file): Done.
+ * files.el (append-to-file): Done.
+
APA> I am not commiting this before I getting an expert opinion on the
APA> correctness of this fix for:
> From: "Christian Nybø" <ch.qr(a)nybo.no>
> Subject: set-coding-system undefined
> To: xemacs-beta(a)xemacs.org
> Date: Wed, 27 Feb 2002 19:14:23 +0100
> Message-Id: <E16g8at-0002GR-00＠lapchr>
APA> Best regards,
APA> Adrian
APA> xemacs-21.5 Patch (cvs -f -z3 -q diff -u lisp/files.el):
APA> Index: lisp/files.el
APA> ===================================================================
APA> RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/files.el,v
APA> retrieving revision 1.46
APA> diff -u -r1.46 files.el
APA> --- lisp/files.el 2002/01/10 00:24:29 1.46
APA> +++ lisp/files.el 2002/02/27 20:24:52
APA> ＠＠ -605,7 +605,7 ＠＠
APA> coding system to use when decoding the file. Interactively,
APA> with a prefix argument, you will be prompted for the coding system."
APA> (interactive "FFind file: \nZCoding system: ")
APA> - (if codesys
APA> + (if (and codesys (featurep 'file-coding))
APA> (let ((coding-system-for-read
APA> (get-coding-system codesys)))
APA> (switch-to-buffer (find-file-noselect filename)))
APA> ＠＠ -619,7 +619,7 ＠＠
APA> coding system to use when decoding the file. Interactively,
APA> with a prefix argument, you will be prompted for the coding system."
APA> (interactive "FFind file in other window: \nZCoding system: ")
APA> - (if codesys
APA> + (if (and codesys (featurep 'file-coding))
APA> (let ((coding-system-for-read
APA> (get-coding-system codesys)))
APA> (switch-to-buffer-other-window (find-file-noselect filename)))
APA> ＠＠ -631,7 +631,7 ＠＠
APA> coding system to use when decoding the file. Interactively,
APA> with a prefix argument, you will be prompted for the coding system."
APA> (interactive "FFind file in other frame: \nZCoding system: ")
APA> - (if codesys
APA> + (if (and codesys (featurep 'file-coding))
APA> (let ((coding-system-for-read
APA> (get-coding-system codesys)))
APA> (switch-to-buffer-other-frame (find-file-noselect filename)))
APA> ＠＠ -645,7 +645,7 ＠＠
APA> coding system to use when decoding the file. Interactively,
APA> with a prefix argument, you will be prompted for the coding system."
APA> (interactive "fFind file read-only: \nZCoding system: ")
APA> - (if codesys
APA> + (if (and codesys (featurep 'file-coding))
APA> (let ((coding-system-for-read
APA> (get-coding-system codesys)))
APA> (find-file filename))
APA> ＠＠ -661,7 +661,7 ＠＠
APA> coding system to use when decoding the file. Interactively,
APA> with a prefix argument, you will be prompted for the coding system."
APA> (interactive "fFind file read-only other window: \nZCoding system:
")
APA> - (if codesys
APA> + (if (and codesys (featurep 'file-coding))
APA> (let ((coding-system-for-read
APA> (get-coding-system codesys)))
APA> (find-file-other-window filename))
APA> ＠＠ -677,7 +677,7 ＠＠
APA> coding system to use when decoding the file. Interactively,
APA> with a prefix argument, you will be prompted for the coding system."
APA> (interactive "fFind file read-only other frame: \nZCoding system:
")
APA> - (if codesys
APA> + (if (and codesys (featurep 'file-coding))
APA> (let ((coding-system-for-read
APA> (get-coding-system codesys)))
APA> (find-file-other-frame filename))
APA> ＠＠ -748,7 +748,7 ＠＠
APA> (unwind-protect
APA> (progn
APA> (unlock-buffer)
APA> - (if codesys
APA> + (if (and codesys (featurep 'file-coding))
APA> (let ((coding-system-for-read
APA> (get-coding-system codesys)))
APA> (find-file filename))
APA> ＠＠ -1919,7 +1919,7 ＠＠
APA> (set-visited-file-name filename)))
APA> (set-buffer-modified-p t)
APA> (setq buffer-read-only nil)
APA> - (if codesys
APA> + (if (and codesys (featurep 'file-coding))
APA> (let ((buffer-file-coding-system (get-coding-system codesys)))
APA> (save-buffer))
APA> (save-buffer)))
APA> ＠＠ -2592,7 +2592,7 ＠＠
APA> (signal 'file-error (list "Opening input file" "file
is a directory"
APA> filename)))
APA> (let ((tem
APA> - (if codesys
APA> + (if (and codesys (featurep 'file-coding))
APA> (let ((coding-system-for-read
APA> (get-coding-system codesys)))
APA> (insert-file-contents filename))
APA> ＠＠ -2608,7 +2608,7 ＠＠
APA> coding system to use when encoding the file. Interactively,
APA> with a prefix argument, you will be prompted for the coding system."
APA> (interactive "r\nFAppend to file: \nZCoding system: ")
APA> - (if codesys
APA> + (if (and codesys (featurep 'file-coding))
APA> (let ((buffer-file-coding-system (get-coding-system codesys)))
APA> (write-region start end filename t))
APA> (write-region start end filename t)))
APA> --
APA> Adrian Aichner
APA> mailto:adrian＠xemacs.org
APA> http://www.xemacs.org/
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
10:41 p.m.
>>>> "APA" == Adrian Aichner
<Adrian.Aichner(a)t-online.de> writes:
Perhaps we should just wait for this?
From: Ben Wing <ben(a)666.com>
Subject: Re: hexl breaks without FILE_CODING
To: Charles G Waldman <cgw(a)alum.mit.edu>
CC: xemacs-review(a)xemacs.org
Date: Wed, 19 Sep 2001 23:16:40 -0700
Message-ID: <3BA989C8.17497E65(a)666.com>
Organization: Amor e Saudade
References: <15189.60382.971638.428086(a)nyx.dyndns.org>
Adrian
>>>> "APA" == Adrian Aichner
<Adrian.Aichner(a)t-online.de> writes:
APA> Should I test for
APA> (or (featurep 'file-coding) (featurep 'mule))
APA> instead?
APA> Here's the ChangeLog for the current patch:
APA> Index: ChangeLog
APA> ===================================================================
APA> RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/ChangeLog,v
APA> retrieving revision 1.357
APA> diff -u -u -r1.357 ChangeLog
APA> --- ChangeLog 2002/02/12 14:24:39 1.357
APA> +++ ChangeLog 2002/02/27 20:56:46
APA> ＠＠ -1,3 +1,17 ＠＠
APA> +2002-02-27 Adrian Aichner <adrian(a)xemacs.org>
APA> +
APA> + * files.el (find-file): Test for file-coding feature before using
APA> + it.
APA> + * files.el (find-file-other-window): Done.
APA> + * files.el (find-file-other-frame): Done.
APA> + * files.el (find-file-read-only): Done.
APA> + * files.el (find-file-read-only-other-window): Done.
APA> + * files.el (find-file-read-only-other-frame): Done.
APA> + * files.el (find-alternate-file): Done.
APA> + * files.el (write-file): Done.
APA> + * files.el (insert-file): Done.
APA> + * files.el (append-to-file): Done.
APA> +
APA> I am not commiting this before I getting an expert opinion on the
APA> correctness of this fix for:
>> From: "Christian Nybø" <ch.qr(a)nybo.no>
>> Subject: set-coding-system undefined
>> To: xemacs-beta(a)xemacs.org
>> Date: Wed, 27 Feb 2002 19:14:23 +0100
>> Message-Id: <E16g8at-0002GR-00＠lapchr>
APA> Best regards,
APA> Adrian
APA> xemacs-21.5 Patch (cvs -f -z3 -q diff -u lisp/files.el):
APA> Index: lisp/files.el
APA> ===================================================================
APA> RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/files.el,v
APA> retrieving revision 1.46
APA> diff -u -r1.46 files.el
APA> --- lisp/files.el 2002/01/10 00:24:29 1.46
APA> +++ lisp/files.el 2002/02/27 20:24:52
APA> ＠＠ -605,7 +605,7 ＠＠
APA> coding system to use when decoding the file. Interactively,
APA> with a prefix argument, you will be prompted for the coding system."
APA> (interactive "FFind file: \nZCoding system: ")
APA> - (if codesys
APA> + (if (and codesys (featurep 'file-coding))
APA> (let ((coding-system-for-read
APA> (get-coding-system codesys)))
APA> (switch-to-buffer (find-file-noselect filename)))
APA> ＠＠ -619,7 +619,7 ＠＠
APA> coding system to use when decoding the file. Interactively,
APA> with a prefix argument, you will be prompted for the coding system."
APA> (interactive "FFind file in other window: \nZCoding system: ")
APA> - (if codesys
APA> + (if (and codesys (featurep 'file-coding))
APA> (let ((coding-system-for-read
APA> (get-coding-system codesys)))
APA> (switch-to-buffer-other-window (find-file-noselect filename)))
APA> ＠＠ -631,7 +631,7 ＠＠
APA> coding system to use when decoding the file. Interactively,
APA> with a prefix argument, you will be prompted for the coding system."
APA> (interactive "FFind file in other frame: \nZCoding system: ")
APA> - (if codesys
APA> + (if (and codesys (featurep 'file-coding))
APA> (let ((coding-system-for-read
APA> (get-coding-system codesys)))
APA> (switch-to-buffer-other-frame (find-file-noselect filename)))
APA> ＠＠ -645,7 +645,7 ＠＠
APA> coding system to use when decoding the file. Interactively,
APA> with a prefix argument, you will be prompted for the coding system."
APA> (interactive "fFind file read-only: \nZCoding system: ")
APA> - (if codesys
APA> + (if (and codesys (featurep 'file-coding))
APA> (let ((coding-system-for-read
APA> (get-coding-system codesys)))
APA> (find-file filename))
APA> ＠＠ -661,7 +661,7 ＠＠
APA> coding system to use when decoding the file. Interactively,
APA> with a prefix argument, you will be prompted for the coding system."
APA> (interactive "fFind file read-only other window: \nZCoding system:
")
APA> - (if codesys
APA> + (if (and codesys (featurep 'file-coding))
APA> (let ((coding-system-for-read
APA> (get-coding-system codesys)))
APA> (find-file-other-window filename))
APA> ＠＠ -677,7 +677,7 ＠＠
APA> coding system to use when decoding the file. Interactively,
APA> with a prefix argument, you will be prompted for the coding system."
APA> (interactive "fFind file read-only other frame: \nZCoding system:
")
APA> - (if codesys
APA> + (if (and codesys (featurep 'file-coding))
APA> (let ((coding-system-for-read
APA> (get-coding-system codesys)))
APA> (find-file-other-frame filename))
APA> ＠＠ -748,7 +748,7 ＠＠
APA> (unwind-protect
APA> (progn
APA> (unlock-buffer)
APA> - (if codesys
APA> + (if (and codesys (featurep 'file-coding))
APA> (let ((coding-system-for-read
APA> (get-coding-system codesys)))
APA> (find-file filename))
APA> ＠＠ -1919,7 +1919,7 ＠＠
APA> (set-visited-file-name filename)))
APA> (set-buffer-modified-p t)
APA> (setq buffer-read-only nil)
APA> - (if codesys
APA> + (if (and codesys (featurep 'file-coding))
APA> (let ((buffer-file-coding-system (get-coding-system codesys)))
APA> (save-buffer))
APA> (save-buffer)))
APA> ＠＠ -2592,7 +2592,7 ＠＠
APA> (signal 'file-error (list "Opening input file" "file is a
directory"
APA> filename)))
APA> (let ((tem
APA> - (if codesys
APA> + (if (and codesys (featurep 'file-coding))
APA> (let ((coding-system-for-read
APA> (get-coding-system codesys)))
APA> (insert-file-contents filename))
APA> ＠＠ -2608,7 +2608,7 ＠＠
APA> coding system to use when encoding the file. Interactively,
APA> with a prefix argument, you will be prompted for the coding system."
APA> (interactive "r\nFAppend to file: \nZCoding system: ")
APA> - (if codesys
APA> + (if (and codesys (featurep 'file-coding))
APA> (let ((buffer-file-coding-system (get-coding-system codesys)))
APA> (write-region start end filename t))
APA> (write-region start end filename t)))
APA> --
APA> Adrian Aichner
APA> mailto:adrian＠xemacs.org
APA> http://www.xemacs.org/
APA> --
APA> Adrian Aichner
APA> mailto:adrian＠xemacs.org
APA> http://www.xemacs.org/
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
4:03 a.m.
>>>> "APA" == Adrian Aichner
<Adrian.Aichner(a)t-online.de> writes:
APA> Should I test for (or (featurep 'file-coding) (featurep
APA> 'mule)) instead?
I'm fairly sure (featurep 'mule) => (featurep 'file-coding). However,
the straight forward thing to do is to test for (fboundp 'get-coding-system).
This (the hexl thing) is a natural mistake for mule programmers to
make; as long as we support building without mule and without
file-coding, we should make some test like this.
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Don't ask how you can "do" free software business;
ask what your business can "do for" free software.
9:13 a.m.
don't commit. file-coding is always enabled in ben-mule-21-5.
Adrian Aichner wrote:
I am not commiting this before I getting an expert opinion on the
correctness of this fix for:
> From: "Christian Nybø" <ch.qr(a)nybo.no>
> Subject: set-coding-system undefined
> To: xemacs-beta(a)xemacs.org
> Date: Wed, 27 Feb 2002 19:14:23 +0100
> Message-Id: <E16g8at-0002GR-00＠lapchr>
Best regards,
Adrian
xemacs-21.5 Patch (cvs -f -z3 -q diff -u lisp/files.el):
Index: lisp/files.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/files.el,v
retrieving revision 1.46
diff -u -r1.46 files.el
--- lisp/files.el 2002/01/10 00:24:29 1.46
+++ lisp/files.el 2002/02/27 20:24:52
＠＠ -605,7 +605,7 ＠＠
coding system to use when decoding the file. Interactively,
with a prefix argument, you will be prompted for the coding system."
(interactive "FFind file: \nZCoding system: ")
- (if codesys
+ (if (and codesys (featurep 'file-coding))
(let ((coding-system-for-read
(get-coding-system codesys)))
(switch-to-buffer (find-file-noselect filename)))
＠＠ -619,7 +619,7 ＠＠
coding system to use when decoding the file. Interactively,
with a prefix argument, you will be prompted for the coding system."
(interactive "FFind file in other window: \nZCoding system: ")
- (if codesys
+ (if (and codesys (featurep 'file-coding))
(let ((coding-system-for-read
(get-coding-system codesys)))
(switch-to-buffer-other-window (find-file-noselect filename)))
＠＠ -631,7 +631,7 ＠＠
coding system to use when decoding the file. Interactively,
with a prefix argument, you will be prompted for the coding system."
(interactive "FFind file in other frame: \nZCoding system: ")
- (if codesys
+ (if (and codesys (featurep 'file-coding))
(let ((coding-system-for-read
(get-coding-system codesys)))
(switch-to-buffer-other-frame (find-file-noselect filename)))
＠＠ -645,7 +645,7 ＠＠
coding system to use when decoding the file. Interactively,
with a prefix argument, you will be prompted for the coding system."
(interactive "fFind file read-only: \nZCoding system: ")
- (if codesys
+ (if (and codesys (featurep 'file-coding))
(let ((coding-system-for-read
(get-coding-system codesys)))
(find-file filename))
＠＠ -661,7 +661,7 ＠＠
coding system to use when decoding the file. Interactively,
with a prefix argument, you will be prompted for the coding system."
(interactive "fFind file read-only other window: \nZCoding system: ")
- (if codesys
+ (if (and codesys (featurep 'file-coding))
(let ((coding-system-for-read
(get-coding-system codesys)))
(find-file-other-window filename))
＠＠ -677,7 +677,7 ＠＠
coding system to use when decoding the file. Interactively,
with a prefix argument, you will be prompted for the coding system."
(interactive "fFind file read-only other frame: \nZCoding system: ")
- (if codesys
+ (if (and codesys (featurep 'file-coding))
(let ((coding-system-for-read
(get-coding-system codesys)))
(find-file-other-frame filename))
＠＠ -748,7 +748,7 ＠＠
(unwind-protect
(progn
(unlock-buffer)
- (if codesys
+ (if (and codesys (featurep 'file-coding))
(let ((coding-system-for-read
(get-coding-system codesys)))
(find-file filename))
＠＠ -1919,7 +1919,7 ＠＠
(set-visited-file-name filename)))
(set-buffer-modified-p t)
(setq buffer-read-only nil)
- (if codesys
+ (if (and codesys (featurep 'file-coding))
(let ((buffer-file-coding-system (get-coding-system codesys)))
(save-buffer))
(save-buffer)))
＠＠ -2592,7 +2592,7 ＠＠
(signal 'file-error (list "Opening input file" "file is a
directory"
filename)))
(let ((tem
- (if codesys
+ (if (and codesys (featurep 'file-coding))
(let ((coding-system-for-read
(get-coding-system codesys)))
(insert-file-contents filename))
＠＠ -2608,7 +2608,7 ＠＠
coding system to use when encoding the file. Interactively,
with a prefix argument, you will be prompted for the coding system."
(interactive "r\nFAppend to file: \nZCoding system: ")
- (if codesys
+ (if (and codesys (featurep 'file-coding))
(let ((buffer-file-coding-system (get-coding-system codesys)))
(write-region start end filename t))
(write-region start end filename t)))
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
10:37 a.m.
>>>> "Ben" == Ben Wing <ben(a)666.com>
writes:
Ben> don't commit. file-coding is always enabled in ben-mule-21-5.
I won't.
Ben> Adrian Aichner wrote:
>
> I am not commiting this before I getting an expert opinion on the
> correctness of this fix for:
>
> > From: "Christian Nybø" <ch.qr(a)nybo.no>
> > Subject: set-coding-system undefined
> > To: xemacs-beta(a)xemacs.org
> > Date: Wed, 27 Feb 2002 19:14:23 +0100
> > Message-Id: <E16g8at-0002GR-00＠lapchr>
>
> Best regards,
>
> Adrian
>
> xemacs-21.5 Patch (cvs -f -z3 -q diff -u lisp/files.el):
>
> Index: lisp/files.el
> ===================================================================
> RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/files.el,v
> retrieving revision 1.46
> diff -u -r1.46 files.el
> --- lisp/files.el 2002/01/10 00:24:29 1.46
> +++ lisp/files.el 2002/02/27 20:24:52
> ＠＠ -605,7 +605,7 ＠＠
> coding system to use when decoding the file. Interactively,
> with a prefix argument, you will be prompted for the coding system."
> (interactive "FFind file: \nZCoding system: ")
> - (if codesys
> + (if (and codesys (featurep 'file-coding))
> (let ((coding-system-for-read
> (get-coding-system codesys)))
> (switch-to-buffer (find-file-noselect filename)))
> ＠＠ -619,7 +619,7 ＠＠
> coding system to use when decoding the file. Interactively,
> with a prefix argument, you will be prompted for the coding system."
> (interactive "FFind file in other window: \nZCoding system: ")
> - (if codesys
> + (if (and codesys (featurep 'file-coding))
> (let ((coding-system-for-read
> (get-coding-system codesys)))
> (switch-to-buffer-other-window (find-file-noselect filename)))
> ＠＠ -631,7 +631,7 ＠＠
> coding system to use when decoding the file. Interactively,
> with a prefix argument, you will be prompted for the coding system."
> (interactive "FFind file in other frame: \nZCoding system: ")
> - (if codesys
> + (if (and codesys (featurep 'file-coding))
> (let ((coding-system-for-read
> (get-coding-system codesys)))
> (switch-to-buffer-other-frame (find-file-noselect filename)))
> ＠＠ -645,7 +645,7 ＠＠
> coding system to use when decoding the file. Interactively,
> with a prefix argument, you will be prompted for the coding system."
> (interactive "fFind file read-only: \nZCoding system: ")
> - (if codesys
> + (if (and codesys (featurep 'file-coding))
> (let ((coding-system-for-read
> (get-coding-system codesys)))
> (find-file filename))
> ＠＠ -661,7 +661,7 ＠＠
> coding system to use when decoding the file. Interactively,
> with a prefix argument, you will be prompted for the coding system."
> (interactive "fFind file read-only other window: \nZCoding system: ")
> - (if codesys
> + (if (and codesys (featurep 'file-coding))
> (let ((coding-system-for-read
> (get-coding-system codesys)))
> (find-file-other-window filename))
> ＠＠ -677,7 +677,7 ＠＠
> coding system to use when decoding the file. Interactively,
> with a prefix argument, you will be prompted for the coding system."
> (interactive "fFind file read-only other frame: \nZCoding system: ")
> - (if codesys
> + (if (and codesys (featurep 'file-coding))
> (let ((coding-system-for-read
> (get-coding-system codesys)))
> (find-file-other-frame filename))
> ＠＠ -748,7 +748,7 ＠＠
> (unwind-protect
> (progn
> (unlock-buffer)
> - (if codesys
> + (if (and codesys (featurep 'file-coding))
> (let ((coding-system-for-read
> (get-coding-system codesys)))
> (find-file filename))
> ＠＠ -1919,7 +1919,7 ＠＠
> (set-visited-file-name filename)))
> (set-buffer-modified-p t)
> (setq buffer-read-only nil)
> - (if codesys
> + (if (and codesys (featurep 'file-coding))
> (let ((buffer-file-coding-system (get-coding-system codesys)))
> (save-buffer))
> (save-buffer)))
> ＠＠ -2592,7 +2592,7 ＠＠
> (signal 'file-error (list "Opening input file" "file is a
directory"
> filename)))
> (let ((tem
> - (if codesys
> + (if (and codesys (featurep 'file-coding))
> (let ((coding-system-for-read
> (get-coding-system codesys)))
> (insert-file-contents filename))
> ＠＠ -2608,7 +2608,7 ＠＠
> coding system to use when encoding the file. Interactively,
> with a prefix argument, you will be prompted for the coding system."
> (interactive "r\nFAppend to file: \nZCoding system: ")
> - (if codesys
> + (if (and codesys (featurep 'file-coding))
> (let ((buffer-file-coding-system (get-coding-system codesys)))
> (write-region start end filename t))
> (write-region start end filename t)))
>
> --
> Adrian Aichner
> mailto:adrian＠xemacs.org
> http://www.xemacs.org/
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
3:19 p.m.
Ben Wing writes:
don't commit. file-coding is always enabled in ben-mule-21-5.
Since it's now Wednesday, I imagine it's too late to object to this?
(I almost never handle MS-DOS format files, and when I do, I don't
like the idea of magic going on in the background).
--
Robert Pluim
2:11 a.m.
Robert Pluim wrote:
Ben Wing writes:
> don't commit. file-coding is always enabled in ben-mule-21-5.
Since it's now Wednesday, I imagine it's too late to object to this?
(I almost never handle MS-DOS format files, and when I do, I don't
like the idea of magic going on in the background).
the eol stuff is not enabled by default. it's just that the capability
to enable it is always present. [it's a command-line option or a menu
option]
--
Robert Pluim
3:30 a.m.
>>>> "Robert" == Robert Pluim
<rpluim(a)bigfoot.com> writes:
Robert> Since it's now Wednesday, I imagine it's too late to
Robert> object to this? (I almost never handle MS-DOS format
Robert> files, and when I do, I don't like the idea of magic going
Robert> on in the background).
(setq file-coding-system-alist '(("." . binary)))
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Don't ask how you can "do" free software business;
ask what your business can "do for" free software.
8090
days inactive
8105
days old
9 comments
5 participants
participants (5)
-
Adrian Aichner -
Adrian Aichner -
Ben Wing -
Robert Pluim -
Stephen J. Turnbull