1:34 p.m.
Hi,
I'm relatively new to XEmacs, so apologies if this issue is already known - I did
search the archives and couldn't find an obvious
reference...
The native build of 21.2.20 on Win32 has a redraw bug. I checked 20.2.19, and the bug
isn't in there, so it appeared between 19 and
20.
To demonstrate the bug, just start 21.2.20, and then immediately drag the right hand edge
of the window out. The newly exposed area
doesn't redraw. Actually, it does redraw a few seconds later.
I haven't any experience with the XEmacs sources, so I'm afraid I don't know
where to begin to look for a solution. Also, I haven't
got CVS access set up, so I can't check whether it's been fixed since 20.
Hope this is useful,
Paul Moore.
5 a.m.
At 1:34 PM +0000 11/21/99, Paul Moore wrote:
Hi,
I'm relatively new to XEmacs, so apologies if this issue is already
known - I did search the archives and couldn't find an obvious
reference...
The native build of 21.2.20 on Win32 has a redraw bug. I checked
20.2.19, and the bug isn't in there, so it appeared between 19 and
20.
To demonstrate the bug, just start 21.2.20, and then immediately
drag the right hand edge of the window out. The newly exposed area
doesn't redraw. Actually, it does redraw a few seconds later.
I haven't any experience with the XEmacs sources, so I'm afraid I
don't know where to begin to look for a solution. Also, I haven't
got CVS access set up, so I can't check whether it's been fixed since 20.
Hope this is useful,
Paul Moore.
I've noticed this too. Here's a patch that makes resize work. It
probably isn't the right patch since I haven't spent much time
figuring out how this code is supposed to work, but it does make
resize work and it hasn't caused any crashes that I know of. All I
did was add size_changed to REDISPLAY_FLAGS. It may need to go into
RESET_CHANGED_FLAGS too, but it seems to work without that.
Mike Alexander
Index: src/redisplay.h
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs/src/redisplay.h,v
retrieving revision 1.7.2.14
diff -u -r1.7.2.14 redisplay.h
--- redisplay.h 1999/11/20 20:29:17 1.7.2.14
+++ redisplay.h 1999/11/23 04:35:25
＠＠ -526,7 +526,6 ＠＠
#define MARK_SUBWINDOWS_CHANGED MARK_TYPE_CHANGED (subwindows)
#define MARK_SUBWINDOWS_STATE_CHANGED MARK_TYPE_CHANGED (subwindows_state)
-
#define CLASS_RESET_CHANGED_FLAGS(p) do { \
(p)->buffers_changed = 0; \
(p)->clip_changed = 0; \
＠＠ -575,6 +574,7 ＠＠
(p)->menubar_changed || \
(p)->modeline_changed || \
(p)->point_changed || \
+ (p)->size_changed || \
(p)->toolbar_changed || \
(p)->gutter_changed || \
(p)->glyphs_changed || \
＠＠ -593,6 +593,7 ＠＠
menubar_changed || \
modeline_changed || \
point_changed || \
+ size_changed || \
toolbar_changed || \
gutter_changed || \
glyphs_changed || \
1:43 p.m.
Oops. This looks like the correct fix and is definitely my fault.
andy
At 12:00 AM 11/23/99 -0500, Mike Alexander wrote:
At 1:34 PM +0000 11/21/99, Paul Moore wrote:
>Hi,
>I'm relatively new to XEmacs, so apologies if this issue is already
>known - I did search the archives and couldn't find an obvious
>reference...
>
>The native build of 21.2.20 on Win32 has a redraw bug. I checked
>20.2.19, and the bug isn't in there, so it appeared between 19 and
>20.
>
>To demonstrate the bug, just start 21.2.20, and then immediately
>drag the right hand edge of the window out. The newly exposed area
>doesn't redraw. Actually, it does redraw a few seconds later.
>
>I haven't any experience with the XEmacs sources, so I'm afraid I
>don't know where to begin to look for a solution. Also, I haven't
>got CVS access set up, so I can't check whether it's been fixed since 20.
>
>Hope this is useful,
>Paul Moore.
I've noticed this too. Here's a patch that makes resize work. It
probably isn't the right patch since I haven't spent much time
figuring out how this code is supposed to work, but it does make
resize work and it hasn't caused any crashes that I know of. All I
did was add size_changed to REDISPLAY_FLAGS. It may need to go into
RESET_CHANGED_FLAGS too, but it seems to work without that.
Mike Alexander
Index: src/redisplay.h
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs/src/redisplay.h,v
retrieving revision 1.7.2.14
diff -u -r1.7.2.14 redisplay.h
--- redisplay.h 1999/11/20 20:29:17 1.7.2.14
+++ redisplay.h 1999/11/23 04:35:25
＠＠ -526,7 +526,6 ＠＠
#define MARK_SUBWINDOWS_CHANGED MARK_TYPE_CHANGED (subwindows)
#define MARK_SUBWINDOWS_STATE_CHANGED MARK_TYPE_CHANGED (subwindows_state)
-
#define CLASS_RESET_CHANGED_FLAGS(p) do { \
(p)->buffers_changed = 0; \
(p)->clip_changed = 0; \
＠＠ -575,6 +574,7 ＠＠
(p)->menubar_changed || \
(p)->modeline_changed || \
(p)->point_changed || \
+ (p)->size_changed || \
(p)->toolbar_changed || \
(p)->gutter_changed || \
(p)->glyphs_changed || \
＠＠ -593,6 +593,7 ＠＠
menubar_changed || \
modeline_changed || \
point_changed || \
+ size_changed || \
toolbar_changed || \
gutter_changed || \
glyphs_changed || \
--------------------------------------------------------------
Dr Andy Piper
Senior Consultant Architect, BEA Systems Ltd
10:08 p.m.
From: Andy Piper [mailto:andy＠xemacs.org]
Oops. This looks like the correct fix and is definitely my fault.
At 12:00 AM 11/23/99 -0500, Mike Alexander wrote:
>I've noticed this too. Here's a patch that makes resize work. It
>probably isn't the right patch since I haven't spent much time
>figuring out how this code is supposed to work, but it does make
>resize work and it hasn't caused any crashes that I know of. All I
>did was add size_changed to REDISPLAY_FLAGS. It may need to go into
>RESET_CHANGED_FLAGS too, but it seems to work without that.
I can confirm that this patch fixes the problem. Thanks for the quick replies!
Paul.
9:35 p.m.
From: Andy Piper [mailto:andy＠xemacs.org]
Oops. This looks like the correct fix and is definitely my fault.
This didn't make it into 2.1.22, I notice...
BTW, the xemacs.mak file doesn't work - it has dependencies on files
..\man\{lispref,internals}\index.{uperm,perm}
which don't exist.
The attached patch fixes this, but it probably isn't right...
Paul Moore.
--- xemacs.mak.orig Fri Oct 15 11:20:55 1999
+++ xemacs.mak Thu Dec 02 21:24:06 1999
＠＠ -994,7 +994,7 ＠＠
$(INFODIR)\lispref.info: $(MANDIR)\lispref\lispref.texi
- copy $(MANDIR)\lispref\index.perm $(MANDIR)\lispref\index.texi
+ # copy $(MANDIR)\lispref\index.perm $(MANDIR)\lispref\index.texi
$(MAKEINFO) $**
$(MANDIR)\lispref\lispref.texi: \
＠＠ -1025,8 +1025,7 ＠＠
$(MANDIR)\lispref\hash-tables.texi \
$(MANDIR)\lispref\help.texi \
$(MANDIR)\lispref\hooks.texi \
- $(MANDIR)\lispref\index.perm \
- $(MANDIR)\lispref\index.unperm \
+ $(MANDIR)\lispref\index.texi \
$(MANDIR)\lispref\internationalization.texi \
$(MANDIR)\lispref\intro.texi \
$(MANDIR)\lispref\keymaps.texi \
＠＠ -1062,9 +1061,7 ＠＠
$(MANDIR)\lispref\tooltalk.texi \
$(MANDIR)\lispref\variables.texi \
$(MANDIR)\lispref\windows.texi \
- $(MANDIR)\lispref\x-windows.texi \
- $(MANDIR)\lispref\index.unperm \
- $(MANDIR)\lispref\index.perm
+ $(MANDIR)\lispref\x-windows.texi
$(INFODIR)\new-users-guide.info: $(MANDIR)\new-users-guide\new-users-guide.texi
＠＠ -1084,12 +1081,12 ＠＠
$(INFODIR)\internals.info: $(MANDIR)\internals\internals.texi
- copy $(MANDIR)\internals\index.perm $(MANDIR)\internals\index.texi
+ # copy $(MANDIR)\internals\index.perm $(MANDIR)\internals\index.texi
$(MAKEINFO) $**
-$(MANDIR)\internals\internals.texi: \
- $(MANDIR)\internals\index.unperm \
- $(MANDIR)\internals\index.perm
+#$(MANDIR)\internals\internals.texi: \
+# $(MANDIR)\internals\index.unperm \
+# $(MANDIR)\internals\index.perm
info: $(INFO_FILES)
7:32 p.m.
From: Andy Piper [mailto:andy＠xemacs.org]
Oops. This looks like the correct fix and is definitely my fault.
Here's an updated version for 21.2.22.
Paul.
diff -u xemacs-21.2.22\src\redisplay.h~ xemacs-21.2.22\src\redisplay.h
--- xemacs-21.2.22\src\redisplay.h~ Sat Nov 20 20:29:17 1999
+++ xemacs-21.2.22\src\redisplay.h Sat Dec 04 23:30:53 1999
＠＠ -526,7 +526,6 ＠＠
#define MARK_SUBWINDOWS_CHANGED MARK_TYPE_CHANGED (subwindows)
#define MARK_SUBWINDOWS_STATE_CHANGED MARK_TYPE_CHANGED (subwindows_state)
-
#define CLASS_RESET_CHANGED_FLAGS(p) do { \
(p)->buffers_changed = 0; \
(p)->clip_changed = 0; \
＠＠ -537,6 +536,7 ＠＠
(p)->menubar_changed = 0; \
(p)->modeline_changed = 0; \
(p)->point_changed = 0; \
+ (p)->size_changed = 0; \
(p)->toolbar_changed = 0; \
(p)->gutter_changed = 0; \
(p)->glyphs_changed = 0; \
＠＠ -556,6 +556,7 ＠＠
menubar_changed = 0; \
modeline_changed = 0; \
point_changed = 0; \
+ size_changed = 0; \
toolbar_changed = 0; \
gutter_changed = 0; \
glyphs_changed = 0; \
＠＠ -575,6 +576,7 ＠＠
(p)->menubar_changed || \
(p)->modeline_changed || \
(p)->point_changed || \
+ (p)->size_changed || \
(p)->toolbar_changed || \
(p)->gutter_changed || \
(p)->glyphs_changed || \
＠＠ -593,6 +595,7 ＠＠
menubar_changed || \
modeline_changed || \
point_changed || \
+ size_changed || \
toolbar_changed || \
gutter_changed || \
glyphs_changed || \
8902
days inactive
8916
days old
5 comments
3 participants
participants (3)
-
Andy Piper -
Mike Alexander -
Paul Moore