Re: Caught a squirmer! (The PNG bug)
SL Baur <steve(a)xemacs.org> writes:
Here's the recipe to reproduce it assuming a copy of Karl's
PNG is
around.
$ xemacs -vanilla
C-x C-f /tmp/info-display.png
C-x k
M-: (garbage-collect)
--- Boom! ---
xemacs: Fatal I/O Error 14 (Bad address) on display connection ":0.0"
after 1719 requests (1712 known processed) with 0 events remaining.
Here's the c-stack backtrace when heavy-duty malloc & free checking is
enabled (compile src/emacs.c by hand with -DLOSING_GCC_DESTRUCTOR_FREE_BUG).
I *love* Doug Lea malloc!
And here's the patch... (how's this for speed?)
1998-04-28 P. E. Jareth Hein <jareth(a)camelot-soft.com>
* glyphs-x.c (x_init_image_instance_from_eimage): Make sure
automatic pointers are null...
Index: glyphs-x.c
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs-20/src/glyphs-x.c,v
retrieving revision 1.44
diff -u -r1.44 glyphs-x.c
--- glyphs-x.c 1998/04/28 00:24:58 1.44
+++ glyphs-x.c 1998/04/28 16:45:41
＠＠ -825,7 +825,7 ＠＠
{
Lisp_Object device = IMAGE_INSTANCE_DEVICE (ii);
Colormap cmap = DEVICE_X_COLORMAP (XDEVICE(device));
- unsigned long *pixtbl;
+ unsigned long *pixtbl = NULL;
int pixcount;
int npixels;
XImage* ximage;
--
Jareth Hein | jareth(a)camelot-soft.com | ハイン ジェラス
Toolsmith & Program lead | http://www.camelot-soft.com | 開発部チーフ
Camelot Software, Ltd. | |（株）キャメロット
"Contrary to popular belief, penguins are not the salvation of modern
technology. Neither do they throw parties for the urban proletariat."