Re: [Success] XEmacs 21.5-b6 "bok choi", i586-pc-win32

Nick> Thank you for your feedback! Thanks for working on this! Nick> The patch below is against cus-edit from CVS. If you find Nick> it suitable then I will attach a ChangeLog entry and submit Nick> it to xemacs-patches. Two problems: 1. Upon first save after customizing group build-report I got something like: Cannot save face default 2. Some variable values get lost be elison: A value of ... is printed instead of the real one! might be related to long values. Sorry for the crappy report, I'm pretty tired at the moment. More later. Best regards, Adrian Nick> intro: "AA" == Adrian Aichner <adrian(a)xemacs.org&gt; writes: >> Nick> Adrian, sorry for delay. Your patch makes cus-edit compile but it Nick> should ruine custom-save :)) AA> Yes, so I noticed after a second of testing :-( Nick> Try the patch attached below against fresh cus-edit.el from the CVS. Nick> It should work. AA> Works nicely. It's also considerably faster in my (emacs-version) AA> "XEmacs 21.5 (beta6) \"bok choi\" [Lucid] (i586-pc-win32, Mule) of Wed AA> Apr 10 2002 on D5DC120J" AA> One gripe I have: AA> It moves the (custom-set-faces ...) and (custom-set-variables ...) from AA> to the end of custom-file from wherever they where before! AA> I'm not sure this is a desired feature. AA> It's definitely a serious regression! Nick> Fixed, custom again respects surrounding code. Nick> You see, I keep custom values in a separate file so the position of the code in Nick> that file was of a minor importance to me. But now I see the weakness of my Nick> position. AA> Also, are you aware that faces in (custom-set-faces ...) don't get AA> written in alphabetic order? AA> Is this intentional? Nick> Well, it was. But now I tuned `custom-save-faces' to print faces in alphabetic Nick> order. AA> What do you think? AA> Best regards, AA> Adrian Nick> Thank you for your reports. Nick> Nick. -- Adrian Aichner mailto:adrian＠xemacs.org http://www.xemacs.org/