Re: `make-annotation' fix
Hrvoje Niksic writes:
Adrian Aichner <aichner(a)ecf.teradyne.com> writes:
> >>>>> "Hrvoje" == Hrvoje Niksic <hniksic(a)srce.hr>
writes:
>
> Hello Hrvoje,
>
> your patch fixes the problem from me.
>
> Here is the *Backtrace* for my testcase of the (make-annotation ...)
> crash:
>
> Signaling:
> (wrong-type-argument buffer-glyph-p #<glyph (pointer)
[...]
Yup. This is IMO correct -- you shouldn't be able to attach a
`pointer' glyph to an extent.
Steve vetoed the patch for 21.2, but I find his rationale
unsatisfactory.
The image handling code and the objects that related to it were
still evolving in 19.13. I doubt if pointer glyphs existed at
that time. I'm not sure glyphs as we know them today were in
existence then.
Hrvoje's patch looks OK to me, given where we are today.