thanks very much for working on dialog boxes! however, i have some
comments ...
the function make-gutter-only-dialog-frame is bogus. the use of the
gutter here to hold widgets is an implementation detail and should not
be exposed in the interface. similarly, make-search-dialog should not
have to do all the futzing that it does. creating the frame unmapped,
creating an extent and messing with the gutter: all this stuff should be
hidden. you should have a simple function make-dialog-frame that takes
a dialog specification, and that's all you need to do.
also, these dialog boxes, and this function make-dialog-frame, should
(a) be in dialog.el, not gutter-items.el.
(b) when possible, be placed in the interactive spec of standard lisp
functions rather than accessed directly from menubar-items.el
(c) wrapped in calls to should-use-dialog-box-p, so the user has control
over when dialog boxes appear.
finally, once again i implore you to please fix your layout code so it's
not necessary to specify widths and heights all over the place!
--
Ben
In order to save my hands, I am cutting back on my mail. I also write
as succinctly as possible -- please don't be offended. If you send me
mail, you _will_ get a response, but please be patient, especially for
XEmacs-related mail. If you need an immediate response and it is not
apparent in your message, please say so. Thanks for your understanding.
See also
http://www.666.com/ben/typing.html.