Re: pcl-cvs buglet

SY> |--==> "n" == nbecker <nbecker(a)fred.net&gt; writes: >> n> I marked a bunch of files in pcl-cvs mode. Then I chose "undo n> changes" from the menu. It prompts "Delete 8 files?". Rather n> misleading. SY> Actually, this is correct behaviour. The menu item "undo changes" SY> runs 'cvs-mode-undo', that function undoes all the local changes to SY> the marked files in the PCL-CVS buffer. It does it by deleting the SY> local file and then runs 'cvs update FILE'. n> It may be literally correct, but I was surprised and confused by this n> question. I wasn't quite sure whether it was doing just what you n> describe, or whether it had gone insane and was offering to delete 8 n> files at random. IIRC, it didn't tell me which 8 files it wanted to n> delete, which didn't help either. SY> Do you think it would be better and less confusing if you were SY> prompted with something like "Delete local copy of marked SY> files and re check them out of CVS?"? Or words to that SY> effect? Hi Steve, I hate the current behavior for the reasons given above. It's confusing. It does not provide any information about the files affected. I think completion buffer feedback, along the lines of what d runs the command dired-flag-file-deletion and x runs the command dired-expunge-deletions do, would be much better. Stealing from (defun-cvs-mode (cvs-mode-undo . SIMPLE) (flags) in pcl-cvs.el I would reword the message to: "Undo local changes?" The other gripe I have about this command is that it's not bound to a key, right? No, actually it is on cvs-mode-undo is on undo, U, C-/, C-_ so my gripe is that it shows up as bound to undo on the menu. I didn't realize for many months now, that this "undo" means: Same key-binding as "undo" command. How can we get "U" in the menu istead? Other than that, I love PCV-CVS. Best regards, Adrian SY> -- SY> |---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---| SY> | XEmacs - It's not just an editor. | SY> | It's a way of life. | SY> |------------------------------------&lt;youngs(a)xemacs.org&gt;---| -- Adrian Aichner mailto:adrian＠xemacs.org http://www.xemacs.org/