Re: [issue] ./configure --prefix=$prefix --infodir=$prefix/share/info broken
On Thursday 12 March 2009, Stephen J. Turnbull wrote:
Michael Sperber writes:
> "Stephen J. Turnbull" <stephen(a)xemacs.org> writes:
> > I don't think you ever got an answer to this...
> >
> > Ville Skyttä writes:
> > > "./configure --prefix=/usr --infodir=/usr/share/info" results
> > > in info files being installed in
> > > /usr/share/xemacs-21.5-b28/info, --infodir ends up being
> > > ignored (INFODIR_USER_DEFINED undef):
> > >
> > > if test "x$infodir_expanded" !=
"x${prefix_expanded}/share/info"
> > > then
> > > AC_DEFINE(INFODIR_USER_DEFINED)
> > > else
> > > infodir='${datarootdir}/${instvardir}/info'
> > > fi
> >
> > That's a bug. It should be testing for its default.
>
> Sorry, I'm missing context: What's "its" and what would be the
> "default"?
"Its" is infodir, and the default is
"${datarootdir}/${instvardir}/info" (expanded).
I think the configure.ac stanza should be something like
if test "x$infodir_expanded" != "${datarootdir}/${instvardir}/info"
then
AC_DEFINE(INFODIR_USER_DEFINED)
else
infodir='${datarootdir}/${instvardir}/info'
fi
but maybe that doesn't expand properly.
I'm not quite following why it should be testing whether it expands to the
default - INFODIR_USER_DEFINED sounds to me like "did the user define it?".
If the user did define it, just use what the user told no matter what it is
(default or not), otherwise fall back to the built-in lookup would sound
better to me. This works for me (although my builds (done with rpm) always
do set both --prefix and --infodir):
-if test "x$infodir_expanded" != "x${prefix_expanded}/share/info"
+if test "x$infodir" != 'x${datarootdir}/info'
Note the single quotes in the latter. It isn't bullet proof against
doing ./configure --infodir='${datarootdir}/info' (again single quotes or
otherwise getting literal, unexpanded ${datarootdir}/info passed to
configure) but... meh.
If the above interpretation is "correct", I think the same changes should be
applied to the similar $datadir_expanded and $libdir_expanded tests above the
infodir one.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta