Re: [Success] XEmacs 21.5-b6 "bok choi", i586-pc-win32

Nick> Patch below is against fresh cus-edit.el from CVS. Nick> It solves both uncovered problems. Looks good now. I think we're ready for your patch and ChangeLog to xemacs-patches. Would be good if a couple more people could test it then. Best regards, Adrian Nick> intro: "AA" == Adrian Aichner <adrian(a)xemacs.org&gt; writes: Nick> Thank you for your feedback! APA> Thanks for working on this! Nick> The patch below is against cus-edit from CVS. If you find it suitable Nick> then I will attach a ChangeLog entry and submit it to xemacs-patches. APA> Two problems: APA> 1. Upon first save after customizing group build-report I got something APA> like: APA> Cannot save face default Nick> My fault. Fixed. AA> Here's the exact message: AA> Recent minibuffer messages (most recent first): AA> Wrong type argument: Not a customized face, default APA> 2. Some variable values get lost be elison: A value of ... is printed APA> instead of the real one! might be related to long values. Nick> I reproduced it when loaded `edebug'. The problem is that `edebug' sets Nick> variable `print-level' to 3, so all nested lists and lambdas got skipped with Nick> ellipsis '...'. I embraced calls to `prin1' with (let ((print-level nil)) ...) AA> The custom-set-faces form written out is incomplete (because of issue 1 AA> above): AA> (custom-set-faces '(default ((t (:family "Courier New"))) t) AA> '(bbdb-company ((t (:bold t :foreground "brown"))) t) '(bold ((t (:bold AA> t))) t) '(bold-italic ((t (:bold t :italic t))) t) '(comint-input-face AA> ((t (:bold t)))) '(custom-invalid-face ((t (:foreground "yellow" AA> :background "red")))) '(cvs-handled-face ((((class color) (background AA> light)) (:foreground "DarkOrchid" :bold t)))) '(cvs-marked-face ((((class AA> color) (background light)) (:foreground "red" :bold t)))) AA> '(cvs-unknown-face ((((class color) (background light)) (:foreground AA> "ForestGreen" :bold t)))) AA> It's location in the file is preserved now, so that fix seems to work. APA> Sorry for the crappy report, I'm pretty tired at the moment. APA> More later. APA> Best regards, APA> Adrian -- Adrian Aichner mailto:adrian＠xemacs.org http://www.xemacs.org/