Re: new tq.el breaks clearcase.el?
Adrian Aichner <adrian(a)xemacs.org> writes:
Hrvoje Niksic <hniksic(a)xemacs.org> writes:
> David Kastrup <dak(a)gnu.org> writes:
>
>>> As far as I can tell, it only changes from old-style backquotes to
>>> the proper backquote syntax.
>>
>> Well, but it is a half-finished change since the comma operator is
>> still used in the manner for the old backquote syntax.
>
> You're right, I missed that because I didn't look carefully enough.
> Thanks for the correction.
So, should we revert this change based on the grounds to ease syncing?
This breakage has been around for way too long:
1.1 (youngs 09-Dec-01): (set-process-filter process
1.2 (ben 07-Nov-04): `(lambda (proc string)
1.2 (ben 07-Nov-04): (tq-filter '(, tq) string)))
1.1 (youngs 09-Dec-01): tq))
Please advise,
RCS file: /cvsroot/emacs/emacs/lisp/emacs-lisp/tq.el,v
Working file: tq.el
head: 1.18
[...]
EMACS_21_3: 1.13
[...]
keyword substitution: kv
total revisions: 22; selected revisions: 22
description:
;;; tq.el --- utility to maintain a transaction queue
----------------------------
revision 1.18
date: 2003/09/12 15:55:47; author: monnier; state: Exp; lines: +2 -2
(tq-create): Fix mixed up unquote style.
----------------------------
Index: tq.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/emacs-lisp/tq.el,v
retrieving revision 1.13
retrieving revision 1.18
diff -u -r1.13 -r1.18
--- tq.el 26 Sep 2001 18:03:51 -0000 1.13
+++ tq.el 12 Sep 2003 15:55:47 -0000 1.18
[...]
＠＠ -49,8 +49,8 ＠＠
(concat " tq-temp-"
(process-name process)))))))
(set-process-filter process
- (`(lambda (proc string)
- (tq-filter '(, tq) string))))
+ `(lambda (proc string)
+ (tq-filter ',tq string)))
tq))
;;; accessors
[...]
So take your pick. If you intend your next synch to be with the
current trunk or with Emacs-22.x, you can complete the patch. If you
intend your next synch to be with the 21.x code base, you can revert
it.
If you are asking me: it would be complete lunacy to synch XEmacs with
21.x: that way you'd be 4 years behind Emacs development right at the
time of the synch. Anything but a synch to the 22.x code base would
be an enormous waste of resources and detrimental to XEmacs
acceptance.
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum