Vin Shelton <acs(a)xemacs.org> writes:
Thanks for your suggestions. I have applied the 2nd set of patches
for
21.1.8.
I found another old one that never made it into 21.1:
http://www.xemacs.org/list-archives/xemacs-patches/9904/msg00039.html
I think this is safe enough to go into 21.1 and I've seen a couple of
crashes in command_builder_operate_menu_accelerator with 21.1.x,
therefore it's probably a good idea to put this in.
The following is the original patch against 21.2.13, the line numbers
might be slightly off for 21.1
1999-04-23 Gunnar Evermann <ge204(a)eng.cam.ac.uk>
* menubar-x.c (pre_activate_callback): set accelerator field in
"No menu" entries to nil. Avoid crash in
command_builder_operate_menu_accelerator
Index: src/menubar-x.c
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs/src/menubar-x.c,v
retrieving revision 1.18.2.4
diff -u -r1.18.2.4 menubar-x.c
--- menubar-x.c 1998/12/18 23:24:01 1.18.2.4
+++ menubar-x.c 1999/04/23 08:33:14
@@ -465,10 +465,12 @@
wv = xmalloc_widget_value ();
wv->type = CASCADE_TYPE;
wv->next = NULL;
+ wv->accel = LISP_TO_VOID (Qnil);
wv->contents = xmalloc_widget_value ();
wv->contents->type = TEXT_TYPE;
wv->contents->name = (char *) "No menu";
wv->contents->next = NULL;
+ wv->contents->accel = LISP_TO_VOID (Qnil);
}
assert (wv && wv->type == CASCADE_TYPE && wv->contents);
replace_widget_value_tree (hack_wv, wv->contents);