>>>> "Jeff" == Jeff Miller
<jmiller(a)smart.net> writes:
Jeff> a general question regarding patches.
Jeff> Normally, I submit patches generated with diff -ubw, to ignore
Jeff> whitespace changes. This normally makes the patches smaller and they
Jeff> just represent the actual code changes. This is the preferred method,
Jeff> right?
I post diffs for review generated usually with `diff -uw'.
But when I apply them, I just use CVS, so they are correctly indented.
If you are not a CVS committer, you should send in patches with
whitespace changes included, or in rare cases, provide two versions of
the patch (I've done this in the pre-CVS days).
Jeff> Who, if anyone, should be re-indenting the code after patches are
Jeff> applied? Some of it gets pretty sloppy looking after awhile.
This is bad.
Martin