Re: [Q] Re: bug and region patch for diff-reverse-direction in diff-mode.el
On Sun, 2002-04-07 at 20:18, James LewisMoss wrote:
>> So I accidentally hit M-R in diff mode and it attempted to
reverse
>> the patch, but it didn't take into account the --- and +++ and
>> just swapped the first chars making +-- and -++. Which afaik
>> isn't a valid patch. While I was messing with
>> diff-reverse-direction I noticed that it only works on the region
>> when you give it a prefix arg which is not what I've come to
>> expect. So here's the patch:
[...]
Ville> I would appreciate it if you could test if the CVS version
(or
Ville> when an experimental prog-modes package is available, that)
Ville> still has this bug, and post an updated patch if it does.
OK. Checked out the "packages" project from xemacs cvs. Here's an
updated patch. I tested the diff-mode.el from cvs for the same bug
and it's still there. Please use the changelog entry from the last
message it's still appropriate.
[...]
Thanks again, the patch applies ok now. However, I could not reproduce
the problem you described with the non-patched diff-mode, though I only
tried with the patch you sent for it. OTOH, the patch didn't seem to
break anything.
If possible, I'd like to see a sample diff/patch where the problem
occurs; could you send me one (and Cc: xemacs-beta(a)xemacs.org)?
I'll put your diff-mode patch on hold for this.
Additionally, since the XEmacs diff-mode.el is now essentially same as
the GNU Emacs 21.2 one, I suspect they might have these problems too,
and think they'd be grateful for a patch as well :)
Cheers,
--
Ville Skyttä
ville.skytta(a)xemacs.org