Re: [Success] XEmacs 21.5-b6 "bok choi", i586-pc-win32

Nick> Adrian, sorry for delay. Nick> Your patch makes cus-edit compile but it should ruine custom-save :)) Yes, so I noticed after a second of testing :-( Nick> Try the patch attached below against fresh cus-edit.el from the CVS. Nick> It should work. Works nicely. It's also considerably faster in my (emacs-version) "XEmacs 21.5 (beta6) \"bok choi\" [Lucid] (i586-pc-win32, Mule) of Wed Apr 10 2002 on D5DC120J" One gripe I have: It moves the (custom-set-faces ...) and (custom-set-variables ...) from to the end of custom-file from wherever they where before! I'm not sure this is a desired feature. It's definitely a serious regression! Also, are you aware that faces in (custom-set-faces ...) don't get written in alphabetic order? Is this intentional? What do you think? Best regards, Adrian Nick> Thank you for your reports. Nick> Nick. Nick> intro: "AA" == Adrian Aichner <Adrian.Aichner(a)T-Online.De&gt; writes: AA> Built from latest CVS with Nick's patch AA> and this little patch for the patch: AA> diff -u AA> c:\Hacking\cvs.xemacs.org\XEmacs\xemacs-21.5\lisp\cus-edit-nick.el AA> c:\Hacking\cvs.xemacs.org\XEmacs\xemacs-21.5\lisp\cus-edit.el AA> --- c:\Hacking\cvs.xemacs.org\XEmacs\xemacs-21.5\lisp\cus-edit-nick.el AA> Mon Apr 8 23:18:58 2002 AA> +++ c:\Hacking\cvs.xemacs.org\XEmacs\xemacs-21.5\lisp\cus-edit.el Mon Apr AA> 8 23:18:58 2002 AA> ＠＠ -3554,12 +3554,14 ＠＠ (eval-when-compile (list (list 'theme-value AA> 'custom-reset-variables (byte-compile AA> - (make-custom-save-resets-mapper AA> - 'theme-value 'custom-reset-variables))) AA> + (lambda () AA> + (make-custom-save-resets-mapper AA> + 'theme-value 'custom-reset-variables)))) AA> (list 'theme-face 'custom-reset-faces (byte-compile AA> - (make-custom-save-resets-mapper AA> - 'theme-face 'custom-reset-faces))))) AA> + (lambda () AA> + (make-custom-save-resets-mapper AA> + 'theme-face 'custom-reset-faces)))))) AA> "Never use it. Hashes several heavily used functions for AA> `custom-save-resets'") AA> Nick, can you confirm my fix? AA> Best regards, AA> Adrian -- Adrian Aichner mailto:adrian＠xemacs.org http://www.xemacs.org/