Re: [PATCH] x-symbol should have a _real_ binary package

Wednesday, 16 December 1998


        ...
 Upfront I want to thank Christoph for his work on X-symbol since he
 seems to move onto other things soon. 
I, of course, would like to second this.  Thanks Christoph.

...
 > Third, I really think that XEmacs should handle the font path
 > issues itself without asking the user (or administrator) to set it
 > up.  If this means adding X(Set|Get)FontPath primitives to XEmacs
 > then so be it.  I'm not sure if this is reasonable.  I.e. does a
 > "nice X citizen" mess with the font path? 
...
 The problem is that the X server does not necessarily run on the
 same host as the prorgam is running. The proper way to do it (at
 least that is what programs like LyX etc that need their own fonts
 seem to do) seem to be to act as a font server yourself. 
I can see that this might be a problem, but I suspect that often the
machines "see" the same filesystem, so it shouldn't be a problem in
practice.

...
 > +  while (ndirs_return--)
 > +      font_path = Fcons (build_string (directories[ndirs_return]), font_path);

...
 Please read the 'Rules When Writing New C Code' section of
the
 "Internals" manual. Especially the "Coding for Mule" section.
 You need to make sure the strings are property converted to the
 internal MULE string format. I think in this case you need
 build_ext_string with a FORMAT_FILENAME argument. 
...
 We have been busy stamping out bugs like this in the last month so
it
 would be unwise to introduce new ones.
 > +  EXTERNAL_LIST_LOOP (path_entry, font_path)
 > +    {
 > +      GET_C_STRING_CTEXT_DATA_ALLOCA (XCAR (path_entry), directories[i++]); 
...
 Conversely you probably want 
...
 GET_C_CHARPTR_EXT_FILENAME_DATA_ALLOCA 
Thanks for the code suggestions. I'll send a patch to xemacs-patches.

-Jim

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

2000

1999

1998