pc-select & signal-error-on-buffer-boundary
If you are like me and tend to lean on the line keys, you have have
`signal-error-on-buffer-boundary' set to nil (no beeps). However, the
pc-select package overrides the definitions of various functions and
effectively turns this variable off.
For example, `pc-select-move-line-up' calls `next-line'. Next line
will only honour the `signal-error-on-buffer-boundary' if called
interactively, which it is not from the pc-select functions.
My patch changes the calls from:
(next-line arg)
to:
(call-interactively 'next-line arg)
If anybody knows a better way, I would love to know. Until then, here
is my patch:
2000-02-12 Sean MacLennan <seanm(a)storm.ca>
* pc-select.el The following now use `call-interactively':
(pc-select-move|mark-line-up)
(pc-select-move|mark-line-down)
(pc-select-move|mark-page-up)
(pc-select-move|mark-page-down)
--- xemacs/packages/lisp/pc/pc-select.el.orig Mon Mar 29 22:59:15 1999
+++ xemacs/packages/lisp/pc/pc-select.el Mon Mar 29 23:01:00 1999
＠＠ -211,7 +211,7 ＠＠
(interactive "p")
(setq zmacs-region-stays pc-select-keep-regions)
(setq this-command 'previous-line)
- (next-line (- arg)))
+ (call-interactively 'previous-line arg))
(defun pc-select-move-line-down (&optional arg)
"Move point down ARG lines, deselecting any marked region.
＠＠ -219,7 +219,7 ＠＠
(interactive "p")
(setq zmacs-region-stays pc-select-keep-regions)
(setq this-command 'next-line)
- (next-line arg))
+ (call-interactively 'next-line arg))
(defun pc-select-move-bol (&optional arg)
"Move point to the beginning of the line, deselecting any marked region.
＠＠ -247,7 +247,7 ＠＠
(interactive "P")
(setq zmacs-region-stays pc-select-keep-regions)
(setq this-command 'scroll-down)
- (scroll-down arg))
+ (call-interactively 'scroll-down-command arg))
(defun pc-select-move-page-down (&optional arg)
"Scroll text of current window up ARG lines, deselecting any marked region.
＠＠ -257,7 +257,7 ＠＠
(interactive "P")
(setq zmacs-region-stays pc-select-keep-regions)
(setq this-command 'scroll-up)
- (scroll-up arg))
+ (call-interactively 'scroll-up-command arg))
(defun pc-select-move-bob (&optional arg)
"Move point to the beginning of buffer, deselecting any active region.
＠＠ -321,7 +321,7 ＠＠
(interactive "p")
(pc-select-ensure-mark)
(setq this-command 'previous-line)
- (next-line (- arg)))
+ (call-interactively 'previous-line arg))
(defun pc-select-mark-line-down (&optional arg)
"Move point down and select ARG lines.
＠＠ -329,7 +329,7 ＠＠
(interactive "p")
(pc-select-ensure-mark)
(setq this-command 'next-line)
- (next-line arg))
+ (call-interactively 'next-line arg))
(defun pc-select-mark-to-bol (&optional arg)
"Move point and mark to the beginning of the line.
＠＠ -357,7 +357,7 ＠＠
(interactive "P")
(pc-select-ensure-mark)
(setq this-command 'scroll-down)
- (scroll-down arg))
+ (call-interactively 'scroll-down arg))
(defun pc-select-mark-page-down (&optional arg)
"Scroll text of current window up and mark ARG lines.
＠＠ -367,7 +367,7 ＠＠
(interactive "P")
(pc-select-ensure-mark)
(setq this-command 'scroll-up)
- (scroll-up arg))
+ (call-interactively 'scroll-up arg))
(defun pc-select-mark-to-bob (&optional arg)
"Move point and mark to the beginning of buffer.
--