Re: [PATCH] Minor msw widget glitches
At 11:52 PM 1/12/00 -0800, Kirill 'Big K' Katsnelson wrote:
This patch fixes a problem: focus disappears after pressing Done
in a customize buffer, and does not reappear until a click on
a buffer (focus lost: it was on a "Done" button, destroyed).
Kirill it is fantastic that someone who actually understands mswindows is
reviewing this code :)
The flag WS_EX_CONTROLPARENT applied to parents, not children.
It affects the behavior of GetNextDlgTabItem. Suppose A,B,C are
children of W, and B1, B2 and B3 are children of B. If all of
the windows are tab stops (WS_TABSTOP), GetNextDlgTabItem
will traverse A,B,C if B does not have the WS_EX_CONTROLPARENT
flag, and A,B1,B2,B3,C if it does.
Ok. I tended to just experiment with flags and leave them in if no problem
was found.
In mswindows_subwindow_instantiate, this flag is not necessary
as long as its child is STATIC.
Ok.
Andy (I suppose you wrote the code, did you?), why there are
sandwiches of two windows to represent each widget? If there
Because you want to be able to clip the widgets and I could find no way of
doing this unless the widget happened to be up against a GUI artifact.
So for instance without this I could not clip widgets that were obscured by
the modeline. I also found that letting the window system clip the widgets
led to some very bad lockups related to event / redisplay cycles.
is a rationale behind this which I overlook, then it has to be
documented - the code looks quite cryptic now... :)
Ok :)
It is customary in Windows to make all controls accessible equally
using mouse and keyboard. Now, should I click on a widget, there
is no way to move focus away from it using keyboard (neither to
sibling widget nor back to the buffer). Symmetrically there is
no way to activate a widget from a buffer using only keyboard.
I have no idea how to make it better (it's midnight here, and I
haven't been xemacsing for a long time), but this should be
discussed.
Right. I have no idea how to do this either.
andy
2000-01-12 Kirill 'Big K' Katsnelson <kkm(a)dtmx.com>
(mswindows_button_instantiate): Removed redundant check for
a disabled gui item.
Why is this redundant?
andy
--------------------------------------------------------------
Dr Andy Piper
Senior Consultant Architect, BEA Systems Ltd